Skip to content

Commit 4f18e5f

Browse files
committed
Reinstate GraphQL tests
Closes gh-45392
1 parent 7ca0323 commit 4f18e5f

File tree

6 files changed

+4
-15
lines changed

6 files changed

+4
-15
lines changed

module/spring-boot-graphql/src/main/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfiguration.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
import org.springframework.http.HttpMethod;
6161
import org.springframework.http.HttpStatus;
6262
import org.springframework.http.MediaType;
63-
import org.springframework.http.converter.GenericHttpMessageConverter;
6463
import org.springframework.http.converter.HttpMessageConverter;
6564
import org.springframework.util.Assert;
6665
import org.springframework.web.cors.CorsConfiguration;
@@ -190,12 +189,12 @@ GraphQlWebSocketHandler graphQlWebSocketHandler(WebGraphQlHandler webGraphQlHand
190189
properties.getWebsocket().getConnectionInitTimeout(), properties.getWebsocket().getKeepAlive());
191190
}
192191

193-
private GenericHttpMessageConverter<Object> getJsonConverter(HttpMessageConverters converters) {
192+
private HttpMessageConverter<Object> getJsonConverter(HttpMessageConverters converters) {
194193
return converters.getConverters()
195194
.stream()
196195
.filter(this::canReadJsonMap)
197196
.findFirst()
198-
.map(this::asGenericHttpMessageConverter)
197+
.map(this::asObjectHttpMessageConverter)
199198
.orElseThrow(() -> new IllegalStateException("No JSON converter"));
200199
}
201200

@@ -204,8 +203,8 @@ private boolean canReadJsonMap(HttpMessageConverter<?> candidate) {
204203
}
205204

206205
@SuppressWarnings("unchecked")
207-
private GenericHttpMessageConverter<Object> asGenericHttpMessageConverter(HttpMessageConverter<?> converter) {
208-
return (GenericHttpMessageConverter<Object>) converter;
206+
private HttpMessageConverter<Object> asObjectHttpMessageConverter(HttpMessageConverter<?> converter) {
207+
return (HttpMessageConverter<Object>) converter;
209208
}
210209

211210
@Bean

module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/reactive/GraphQlWebFluxAutoConfigurationTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.util.function.Consumer;
2323

2424
import graphql.schema.idl.TypeRuntimeWiring;
25-
import org.junit.jupiter.api.Disabled;
2625
import org.junit.jupiter.api.Test;
2726

2827
import org.springframework.aot.hint.RuntimeHints;
@@ -79,7 +78,6 @@
7978
booksOnSale(minPages: Int) : Book!
8079
}
8180
""")
82-
@Disabled("Waiting on compatible release")
8381
class GraphQlWebFluxAutoConfigurationTests {
8482

8583
private static final String BASE_URL = "https://spring.example.org/";

module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebFluxSecurityAutoConfigurationTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.util.function.Consumer;
2121

2222
import graphql.schema.idl.TypeRuntimeWiring;
23-
import org.junit.jupiter.api.Disabled;
2423
import org.junit.jupiter.api.Test;
2524
import reactor.core.publisher.Mono;
2625

@@ -80,7 +79,6 @@
8079
booksOnSale(minPages: Int) : Book!
8180
}
8281
""")
83-
@Disabled("Waiting on compatible release")
8482
class GraphQlWebFluxSecurityAutoConfigurationTests {
8583

8684
private static final String BASE_URL = "https://spring.example.org/graphql";

module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebMvcSecurityAutoConfigurationTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import graphql.schema.idl.TypeRuntimeWiring;
2020
import org.assertj.core.api.ThrowingConsumer;
21-
import org.junit.jupiter.api.Disabled;
2221
import org.junit.jupiter.api.Test;
2322

2423
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -80,7 +79,6 @@
8079
booksOnSale(minPages: Int) : Book!
8180
}
8281
""")
83-
@Disabled("Waiting on compatible release")
8482
class GraphQlWebMvcSecurityAutoConfigurationTests {
8583

8684
private final WebApplicationContextRunner contextRunner = new WebApplicationContextRunner()

module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfigurationTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import graphql.schema.idl.TypeRuntimeWiring;
2323
import org.assertj.core.api.ThrowingConsumer;
24-
import org.junit.jupiter.api.Disabled;
2524
import org.junit.jupiter.api.Test;
2625

2726
import org.springframework.aot.hint.RuntimeHints;
@@ -81,7 +80,6 @@
8180
booksOnSale(minPages: Int) : Book!
8281
}
8382
""")
84-
@Disabled("Waiting on compatible release")
8583
class GraphQlWebMvcAutoConfigurationTests {
8684

8785
private final WebApplicationContextRunner contextRunner = new WebApplicationContextRunner()

smoke-test/spring-boot-smoke-test-graphql/src/test/java/smoketest/graphql/GreetingControllerTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package smoketest.graphql;
1818

19-
import org.junit.jupiter.api.Disabled;
2019
import org.junit.jupiter.api.Test;
2120

2221
import org.springframework.beans.factory.annotation.Autowired;
@@ -29,7 +28,6 @@
2928

3029
@SpringBootTest
3130
@AutoConfigureHttpGraphQlTester
32-
@Disabled("Waiting on compatible release")
3331
class GreetingControllerTests {
3432

3533
@Autowired

0 commit comments

Comments
 (0)