Skip to content

Commit 507fae5

Browse files
committed
Merge branch '2.2.x' into 2.3.x
Closes gh-23258
2 parents 62cb87b + 018cc1c commit 507fae5

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/error/ErrorMvcAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.boot.autoconfigure.web.servlet.error;
1818

1919
import java.nio.charset.StandardCharsets;
20-
import java.util.Date;
2120
import java.util.Map;
2221
import java.util.stream.Collectors;
2322

@@ -207,7 +206,7 @@ public void render(Map<String, ?> model, HttpServletRequest request, HttpServlet
207206
}
208207
response.setContentType(TEXT_HTML_UTF8.toString());
209208
StringBuilder builder = new StringBuilder();
210-
Date timestamp = (Date) model.get("timestamp");
209+
Object timestamp = model.get("timestamp");
211210
Object message = model.get("message");
212211
Object trace = model.get("trace");
213212
if (response.getContentType() == null) {

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/servlet/error/ErrorMvcAutoConfigurationTests.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616

1717
package org.springframework.boot.autoconfigure.web.servlet.error;
1818

19+
import java.time.Clock;
20+
import java.util.Map;
21+
1922
import org.junit.jupiter.api.Test;
2023
import org.junit.jupiter.api.extension.ExtendWith;
2124

@@ -65,6 +68,22 @@ void renderContainsViewWithExceptionDetails() {
6568
});
6669
}
6770

71+
@Test
72+
void renderCanUseJavaTimeTypeAsTimestamp() throws Exception { // gh-23256
73+
this.contextRunner.run((context) -> {
74+
View errorView = context.getBean("error", View.class);
75+
ErrorAttributes errorAttributes = context.getBean(ErrorAttributes.class);
76+
DispatcherServletWebRequest webRequest = createWebRequest(new IllegalStateException("Exception message"),
77+
false);
78+
Map<String, Object> attributes = errorAttributes.getErrorAttributes(webRequest, true);
79+
attributes.put("timestamp", Clock.systemUTC().instant());
80+
errorView.render(attributes, webRequest.getRequest(), webRequest.getResponse());
81+
assertThat(webRequest.getResponse().getContentType()).isEqualTo("text/html;charset=UTF-8");
82+
String responseString = ((MockHttpServletResponse) webRequest.getResponse()).getContentAsString();
83+
assertThat(responseString).contains("This application has no explicit mapping for /error");
84+
});
85+
}
86+
6887
@Test
6988
void renderWhenAlreadyCommittedLogsMessage(CapturedOutput output) {
7089
this.contextRunner.run((context) -> {

0 commit comments

Comments
 (0)