Add nullability annotations to module/spring-boot-liquibase

See gh-46587

Author: mhalbritter

module/spring-boot-liquibase/src/main/java/org/springframework/boot/liquibase/LiquibaseChangelogMissingFailureAnalyzer.java

@@ -17,6 +17,7 @@
 package org.springframework.boot.liquibase;
 
 import liquibase.exception.ChangeLogParseException;
+import org.jspecify.annotations.Nullable;
 
 import org.springframework.boot.diagnostics.AbstractFailureAnalyzer;
 import org.springframework.boot.diagnostics.FailureAnalysis;
@@ -32,17 +33,18 @@ class LiquibaseChangelogMissingFailureAnalyzer extends AbstractFailureAnalyzer<C
 	private static final String MESSAGE_SUFFIX = " does not exist";
 
 	@Override
-	protected FailureAnalysis analyze(Throwable rootFailure, ChangeLogParseException cause) {
-		if (cause.getMessage().endsWith(MESSAGE_SUFFIX)) {
-			String changelogPath = extractChangelogPath(cause);
+	protected @Nullable FailureAnalysis analyze(Throwable rootFailure, ChangeLogParseException cause) {
+		String message = cause.getMessage();
+		if (message != null && message.endsWith(MESSAGE_SUFFIX)) {
+			String changelogPath = extractChangelogPath(message);
 			return new FailureAnalysis(getDescription(changelogPath),
 					"Make sure a Liquibase changelog is present at the configured path.", cause);
 		}
 		return null;
 	}
 
-	private String extractChangelogPath(ChangeLogParseException cause) {
-		return cause.getMessage().substring(0, cause.getMessage().length() - MESSAGE_SUFFIX.length());
+	private String extractChangelogPath(String message) {
+		return message.substring(0, message.length() - MESSAGE_SUFFIX.length());
 	}
 
 	private String getDescription(String changelogPath) {

module/spring-boot-liquibase/src/main/java/org/springframework/boot/liquibase/autoconfigure/LiquibaseAutoConfiguration.java

@@ -25,6 +25,7 @@
 import liquibase.integration.spring.Customizer;
 import liquibase.integration.spring.SpringLiquibase;
 import liquibase.ui.UIServiceEnum;
+import org.jspecify.annotations.Nullable;
 
 import org.springframework.aot.hint.RuntimeHints;
 import org.springframework.aot.hint.RuntimeHintsRegistrar;
@@ -142,8 +143,8 @@ SpringLiquibase liquibase(ObjectProvider<DataSource> dataSource,
 			return liquibase;
 		}
 
-		private SpringLiquibase createSpringLiquibase(DataSource liquibaseDataSource, DataSource dataSource,
-				LiquibaseConnectionDetails connectionDetails) {
+		private SpringLiquibase createSpringLiquibase(@Nullable DataSource liquibaseDataSource,
+				@Nullable DataSource dataSource, LiquibaseConnectionDetails connectionDetails) {
 			DataSource migrationDataSource = getMigrationDataSource(liquibaseDataSource, dataSource, connectionDetails);
 			SpringLiquibase liquibase = (migrationDataSource == liquibaseDataSource
 					|| migrationDataSource == dataSource) ? new SpringLiquibase()
@@ -152,8 +153,8 @@ private SpringLiquibase createSpringLiquibase(DataSource liquibaseDataSource, Da
 			return liquibase;
 		}
 
-		private DataSource getMigrationDataSource(DataSource liquibaseDataSource, DataSource dataSource,
-				LiquibaseConnectionDetails connectionDetails) {
+		private DataSource getMigrationDataSource(@Nullable DataSource liquibaseDataSource,
+				@Nullable DataSource dataSource, LiquibaseConnectionDetails connectionDetails) {
 			if (liquibaseDataSource != null) {
 				return liquibaseDataSource;
 			}
@@ -224,7 +225,7 @@ private static final class LiquibaseUrlCondition {
 	static class LiquibaseAutoConfigurationRuntimeHints implements RuntimeHintsRegistrar {
 
 		@Override
-		public void registerHints(RuntimeHints hints, ClassLoader classLoader) {
+		public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader) {
 			hints.resources().registerPattern("db/changelog/**");
 		}
 
@@ -242,22 +243,22 @@ static final class PropertiesLiquibaseConnectionDetails implements LiquibaseConn
 		}
 
 		@Override
-		public String getUsername() {
+		public @Nullable String getUsername() {
 			return this.properties.getUser();
 		}
 
 		@Override
-		public String getPassword() {
+		public @Nullable String getPassword() {
 			return this.properties.getPassword();
 		}
 
 		@Override
-		public String getJdbcUrl() {
+		public @Nullable String getJdbcUrl() {
 			return this.properties.getUrl();
 		}
 
 		@Override
-		public String getDriverClassName() {
+		public @Nullable String getDriverClassName() {
 			String driverClassName = this.properties.getDriverClassName();
 			return (driverClassName != null) ? driverClassName : LiquibaseConnectionDetails.super.getDriverClassName();
 		}

module/spring-boot-liquibase/src/main/java/org/springframework/boot/liquibase/autoconfigure/LiquibaseConnectionDetails.java

@@ -16,6 +16,8 @@
 
 package org.springframework.boot.liquibase.autoconfigure;
 
+import org.jspecify.annotations.Nullable;
+
 import org.springframework.boot.autoconfigure.service.connection.ConnectionDetails;
 import org.springframework.boot.jdbc.DatabaseDriver;
 
@@ -32,21 +34,21 @@ public interface LiquibaseConnectionDetails extends ConnectionDetails {
 	 * required.
 	 * @return the username for the database or {@code null}
 	 */
-	String getUsername();
+	@Nullable String getUsername();
 
 	/**
 	 * Password for the database or {@code null} if no Liquibase-specific configuration is
 	 * required.
 	 * @return the password for the database or {@code null}
 	 */
-	String getPassword();
+	@Nullable String getPassword();
 
 	/**
 	 * JDBC URL for the database or {@code null} if no Liquibase-specific configuration is
 	 * required.
 	 * @return the JDBC URL for the database or {@code null}
 	 */
-	String getJdbcUrl();
+	@Nullable String getJdbcUrl();
 
 	/**
 	 * The name of the JDBC driver class. Defaults to the class name of the driver
@@ -56,7 +58,7 @@ public interface LiquibaseConnectionDetails extends ConnectionDetails {
 	 * @see DatabaseDriver#fromJdbcUrl(String)
 	 * @see DatabaseDriver#getDriverClassName()
 	 */
-	default String getDriverClassName() {
+	@Nullable default String getDriverClassName() {
 		String jdbcUrl = getJdbcUrl();
 		return (jdbcUrl != null) ? DatabaseDriver.fromJdbcUrl(jdbcUrl).getDriverClassName() : null;
 	}