Skip to content

Commit 5dfe0aa

Browse files
committed
Polish tests in buildSrc
`gradle :buildSrc:test` is passed with Gradle 9 now. Fix: ``` Could not set unknown property 'sourceCompatibility' for root project 'junit-5112049806825616538' of type org.gradle.api.Project. ``` and ``` Failed to load JUnit Platform. Please ensure that the JUnit Platform is available on the test runtime classpath. ``` Signed-off-by: Yanming Zhou <[email protected]>
1 parent 426e563 commit 5dfe0aa

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

buildSrc/src/test/java/org/springframework/boot/build/ConventionsPluginTests.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
* Integration tests for {@link ConventionsPlugin}.
4242
*
4343
* @author Christoph Dreis
44+
* @author Yanming Zhou
4445
*/
4546
class ConventionsPluginTests {
4647

@@ -77,7 +78,9 @@ void jarIncludesLegalFiles() throws IOException {
7778
out.println(" id 'org.springframework.boot.conventions'");
7879
out.println("}");
7980
out.println("version = '1.2.3'");
80-
out.println("sourceCompatibility = '17'");
81+
out.println("java {");
82+
out.println(" sourceCompatibility = '17'");
83+
out.println("}");
8184
out.println("description 'Test project for manifest customization'");
8285
out.println("jar.archiveFileName = 'test.jar'");
8386
}
@@ -107,7 +110,9 @@ void sourceJarIsBuilt() throws IOException {
107110
out.println(" id 'org.springframework.boot.conventions'");
108111
out.println("}");
109112
out.println("version = '1.2.3'");
110-
out.println("sourceCompatibility = '17'");
113+
out.println("java {");
114+
out.println(" sourceCompatibility = '17'");
115+
out.println("}");
111116
out.println("description 'Test'");
112117
}
113118
runGradle("assemble");
@@ -136,7 +141,9 @@ void javadocJarIsBuilt() throws IOException {
136141
out.println(" id 'org.springframework.boot.conventions'");
137142
out.println("}");
138143
out.println("version = '1.2.3'");
139-
out.println("sourceCompatibility = '17'");
144+
out.println("java {");
145+
out.println(" sourceCompatibility = '17'");
146+
out.println("}");
140147
out.println("description 'Test'");
141148
}
142149
runGradle("assemble");

buildSrc/src/test/java/org/springframework/boot/build/testing/TestFailuresPluginIntegrationTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
* Integrations tests for {@link TestFailuresPlugin}.
3838
*
3939
* @author Andy Wilkinson
40+
* @author Yanming Zhou
4041
*/
4142
class TestFailuresPluginIntegrationTests {
4243

@@ -166,6 +167,7 @@ private void createBuildScript(File dir) {
166167
writer.println("dependencies {");
167168
writer.println(" testImplementation 'org.junit.jupiter:junit-jupiter:5.6.0'");
168169
writer.println(" testImplementation 'org.assertj:assertj-core:3.11.1'");
170+
writer.println(" testRuntimeOnly 'org.junit.platform:junit-platform-launcher'");
169171
writer.println("}");
170172
writer.println();
171173
writer.println("test {");

0 commit comments

Comments
 (0)