Skip to content

Commit 5e463a9

Browse files
committed
Address review feedback: focus solely on devtools exclusion
- Remove spring-boot-docker-compose exclusions as they are out of scope - Remove verbose comments from tests per Spring Boot conventions Signed-off-by: academey <[email protected]>
1 parent d34f176 commit 5e463a9

File tree

2 files changed

+0
-21
lines changed
  • build-plugin/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven
  • starter/spring-boot-starter-parent

2 files changed

+0
-21
lines changed

build-plugin/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/AotTests.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -198,14 +198,8 @@ protected String buildLog(File project) {
198198
@TestTemplate
199199
void whenAotRunsWithDevtoolsInClasspathItIsExcluded(MavenBuild mavenBuild) {
200200
mavenBuild.project("aot-exclude-devtools").goals("package").execute((project) -> {
201-
// The test passes if the build completes successfully.
202-
// If devtools were included, the AOT processing would fail because devtools
203-
// uses features (like class proxies) that are not compatible with native
204-
// images.
205201
Path aotDirectory = project.toPath().resolve("target/spring-aot/main");
206202
assertThat(aotDirectory).exists();
207-
// Verify that source files were generated, indicating successful AOT
208-
// processing
209203
Path sourcesDirectory = aotDirectory.resolve("sources");
210204
assertThat(sourcesDirectory).exists();
211205
assertThat(collectRelativePaths(sourcesDirectory)).isNotEmpty();
@@ -215,15 +209,8 @@ void whenAotRunsWithDevtoolsInClasspathItIsExcluded(MavenBuild mavenBuild) {
215209
@TestTemplate
216210
void whenTestAotRunsWithDevtoolsInClasspathItIsExcluded(MavenBuild mavenBuild) {
217211
mavenBuild.project("aot-test-exclude-devtools").goals("process-test-classes").execute((project) -> {
218-
// The test passes if the build completes successfully.
219-
// If devtools were included, the test AOT processing would fail because
220-
// devtools
221-
// uses features (like class proxies) that are not compatible with native
222-
// images.
223212
Path aotDirectory = project.toPath().resolve("target/spring-aot/test");
224213
assertThat(aotDirectory).exists();
225-
// Verify that source files were generated, indicating successful AOT
226-
// processing
227214
Path sourcesDirectory = aotDirectory.resolve("sources");
228215
assertThat(sourcesDirectory).exists();
229216
assertThat(collectRelativePaths(sourcesDirectory)).isNotEmpty();

starter/spring-boot-starter-parent/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -303,10 +303,6 @@ publishing.publications.withType(MavenPublication) {
303303
delegate.groupId('org.springframework.boot')
304304
delegate.artifactId('spring-boot-devtools')
305305
}
306-
exclusion {
307-
delegate.groupId('org.springframework.boot')
308-
delegate.artifactId('spring-boot-docker-compose')
309-
}
310306
}
311307
}
312308
executions {
@@ -357,10 +353,6 @@ publishing.publications.withType(MavenPublication) {
357353
delegate.groupId('org.springframework.boot')
358354
delegate.artifactId('spring-boot-devtools')
359355
}
360-
exclusion {
361-
delegate.groupId('org.springframework.boot')
362-
delegate.artifactId('spring-boot-docker-compose')
363-
}
364356
}
365357
}
366358
executions {

0 commit comments

Comments
 (0)