Skip to content

Commit 67b66f5

Browse files
wilkinsonaphilwebb
authored andcommitted
Move HTTP exchange auto-config into appropriate modules
Issue: 46071
1 parent 0578046 commit 67b66f5

File tree

33 files changed

+310
-234
lines changed

33 files changed

+310
-234
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/main/resources/META-INF/additional-spring-configuration-metadata.json

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,6 @@
66
"type": "java.lang.Boolean",
77
"description": "Whether to enable SSL certificate health check.",
88
"defaultValue": true
9-
},
10-
{
11-
"name": "management.httpexchanges.recording.enabled",
12-
"type": "java.lang.Boolean",
13-
"description": "Whether to enable HTTP request-response exchange recording.",
14-
"defaultValue": true
15-
},
16-
{
17-
"name": "management.httpexchanges.recording.include",
18-
"defaultValue": [
19-
"request-headers",
20-
"response-headers",
21-
"errors"
22-
]
239
},
2410
{
2511
"name": "management.otlp.tracing.export.enabled",

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,3 @@ org.springframework.boot.actuate.autoconfigure.tracing.OpenTelemetryTracingAutoC
1212
org.springframework.boot.actuate.autoconfigure.tracing.otlp.OtlpTracingAutoConfiguration
1313
org.springframework.boot.actuate.autoconfigure.tracing.prometheus.PrometheusExemplarsAutoConfiguration
1414
org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinTracingAutoConfiguration
15-
org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesAutoConfiguration
16-
org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesEndpointAutoConfiguration

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/integrationtest/JmxEndpointAccessIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.springframework.boot.actuate.autoconfigure.endpoint.EndpointAutoConfiguration;
2727
import org.springframework.boot.actuate.autoconfigure.endpoint.jmx.JmxEndpointAutoConfiguration;
2828
import org.springframework.boot.actuate.autoconfigure.health.HealthContributorAutoConfiguration;
29-
import org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesAutoConfiguration;
3029
import org.springframework.boot.actuate.endpoint.annotation.DeleteOperation;
3130
import org.springframework.boot.actuate.endpoint.annotation.ReadOperation;
3231
import org.springframework.boot.actuate.endpoint.annotation.WriteOperation;
@@ -47,8 +46,7 @@ class JmxEndpointAccessIntegrationTests {
4746

4847
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
4948
.withConfiguration(AutoConfigurations.of(JmxAutoConfiguration.class, EndpointAutoConfiguration.class,
50-
JmxEndpointAutoConfiguration.class, HealthContributorAutoConfiguration.class,
51-
HttpExchangesAutoConfiguration.class))
49+
JmxEndpointAutoConfiguration.class, HealthContributorAutoConfiguration.class))
5250
.withUserConfiguration(CustomJmxEndpoint.class)
5351
.withPropertyValues("spring.jmx.enabled=true")
5452
.withConfiguration(AutoConfigurations.of(EndpointAutoConfigurationClasses.ALL));

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/integrationtest/JmxEndpointIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.springframework.boot.actuate.autoconfigure.endpoint.EndpointAutoConfiguration;
3232
import org.springframework.boot.actuate.autoconfigure.endpoint.jmx.JmxEndpointAutoConfiguration;
3333
import org.springframework.boot.actuate.autoconfigure.health.HealthContributorAutoConfiguration;
34-
import org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesAutoConfiguration;
3534
import org.springframework.boot.actuate.web.exchanges.InMemoryHttpExchangeRepository;
3635
import org.springframework.boot.autoconfigure.AutoConfigurations;
3736
import org.springframework.boot.autoconfigure.jmx.JmxAutoConfiguration;
@@ -52,8 +51,7 @@ class JmxEndpointIntegrationTests {
5251

5352
private final WebApplicationContextRunner contextRunner = new WebApplicationContextRunner()
5453
.withConfiguration(AutoConfigurations.of(JmxAutoConfiguration.class, EndpointAutoConfiguration.class,
55-
JmxEndpointAutoConfiguration.class, HealthContributorAutoConfiguration.class,
56-
HttpExchangesAutoConfiguration.class))
54+
JmxEndpointAutoConfiguration.class, HealthContributorAutoConfiguration.class))
5755
.withUserConfiguration(HttpExchangeRepositoryConfiguration.class, AuditEventRepositoryConfiguration.class)
5856
.withPropertyValues("spring.jmx.enabled=true")
5957
.withConfiguration(AutoConfigurations.of(EndpointAutoConfigurationClasses.ALL));

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/integrationtest/WebMvcEndpointExposureIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
import org.springframework.boot.actuate.autoconfigure.endpoint.EndpointAutoConfiguration;
3131
import org.springframework.boot.actuate.autoconfigure.endpoint.web.WebEndpointAutoConfiguration;
3232
import org.springframework.boot.actuate.autoconfigure.health.HealthContributorAutoConfiguration;
33-
import org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesAutoConfiguration;
3433
import org.springframework.boot.actuate.autoconfigure.web.server.ManagementContextAutoConfiguration;
3534
import org.springframework.boot.actuate.web.exchanges.InMemoryHttpExchangeRepository;
3635
import org.springframework.boot.autoconfigure.AutoConfigurations;
3736
import org.springframework.boot.http.converter.autoconfigure.HttpMessageConvertersAutoConfiguration;
3837
import org.springframework.boot.jackson.autoconfigure.JacksonAutoConfiguration;
3938
import org.springframework.boot.servlet.actuate.autoconfigure.ServletManagementContextAutoConfiguration;
39+
import org.springframework.boot.servlet.actuate.autoconfigure.exchanges.ServletHttpExchangesAutoConfiguration;
4040
import org.springframework.boot.test.context.assertj.AssertableWebApplicationContext;
4141
import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
4242
import org.springframework.boot.tomcat.autoconfigure.servlet.TomcatServletWebServerAutoConfiguration;
@@ -70,7 +70,7 @@ class WebMvcEndpointExposureIntegrationTests {
7070
JacksonAutoConfiguration.class, HttpMessageConvertersAutoConfiguration.class,
7171
WebMvcAutoConfiguration.class, EndpointAutoConfiguration.class, WebEndpointAutoConfiguration.class,
7272
ManagementContextAutoConfiguration.class, ManagementContextAutoConfiguration.class,
73-
ServletManagementContextAutoConfiguration.class, HttpExchangesAutoConfiguration.class,
73+
ServletManagementContextAutoConfiguration.class, ServletHttpExchangesAutoConfiguration.class,
7474
HealthContributorAutoConfiguration.class))
7575
.withConfiguration(AutoConfigurations.of(EndpointAutoConfigurationClasses.ALL))
7676
.withUserConfiguration(CustomMvcEndpoint.class, CustomServletEndpoint.class,

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/web/exchanges/HttpExchangesAutoConfigurationTests.java

Lines changed: 0 additions & 161 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* @author Phillip Webb
3333
* @since 3.0.0
3434
*/
35-
@AutoConfiguration(after = HttpExchangesAutoConfiguration.class)
35+
@AutoConfiguration
3636
@ConditionalOnAvailableEndpoint(HttpExchangesEndpoint.class)
3737
public class HttpExchangesEndpointAutoConfiguration {
3838

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,20 @@
138138
"description": "Whether to enable readiness state health check.",
139139
"defaultValue": false
140140
},
141+
{
142+
"name": "management.httpexchanges.recording.enabled",
143+
"type": "java.lang.Boolean",
144+
"description": "Whether to enable HTTP request-response exchange recording.",
145+
"defaultValue": true
146+
},
147+
{
148+
"name": "management.httpexchanges.recording.include",
149+
"defaultValue": [
150+
"request-headers",
151+
"response-headers",
152+
"errors"
153+
]
154+
},
141155
{
142156
"name": "management.info.build.enabled",
143157
"type": "java.lang.Boolean",

0 commit comments

Comments
 (0)