Make all @bean methods public

This is a continuation of the changes made in 611f978. It makes some
more @bean methods public and adds tests to spring-boot-actuator and
spring-boot-autoconfigure to prevent against non-public methods being
introduced in the future

Closes gh-1571

Author: wilkinsona

spring-boot-actuator/src/test/java/org/springframework/boot/actuate/ActuatorConfigurationClassTests.java

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.actuate;
+
+import org.springframework.boot.test.AbstractConfigurationClassTests;
+
+/**
+ * Tests for the actuator module's @Configuration classes
+ * @author Andy Wilkinson
+ */
+public class ActuatorConfigurationClassTests extends AbstractConfigurationClassTests {
+
+}

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java

@@ -101,7 +101,7 @@ static class JodaModuleAutoConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean
-		JodaModule jacksonJodaModule() {
+		public JodaModule jacksonJodaModule() {
 			return new JodaModule();
 		}
 
@@ -114,7 +114,7 @@ static class Jsr310ModuleAutoConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean
-		JSR310Module jacksonJsr310Module() {
+		public JSR310Module jacksonJsr310Module() {
 			return new JSR310Module();
 		}
 

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/redis/RedisAutoConfiguration.java

@@ -58,7 +58,8 @@ protected static class RedisConnectionConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean
-		RedisConnectionFactory redisConnectionFactory() throws UnknownHostException {
+		public RedisConnectionFactory redisConnectionFactory()
+				throws UnknownHostException {
 			JedisConnectionFactory factory = new JedisConnectionFactory();
 			factory.setHostName(this.properties.getHost());
 			factory.setPort(this.properties.getPort());
@@ -79,7 +80,8 @@ protected static class RedisPooledConnectionConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean
-		RedisConnectionFactory redisConnectionFactory() throws UnknownHostException {
+		public RedisConnectionFactory redisConnectionFactory()
+				throws UnknownHostException {
 			JedisConnectionFactory factory = createJedisConnectionFactory();
 			factory.setHostName(this.properties.getHost());
 			factory.setPort(this.properties.getPort());
@@ -124,7 +126,7 @@ protected static class RedisConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean(name = "redisTemplate")
-		RedisOperations<Object, Object> redisTemplate(
+		public RedisOperations<Object, Object> redisTemplate(
 				RedisConnectionFactory redisConnectionFactory)
 				throws UnknownHostException {
 			RedisTemplate<Object, Object> template = new RedisTemplate<Object, Object>();
@@ -134,7 +136,7 @@ RedisOperations<Object, Object> redisTemplate(
 
 		@Bean
 		@ConditionalOnMissingBean(StringRedisTemplate.class)
-		StringRedisTemplate stringRedisTemplate(
+		public StringRedisTemplate stringRedisTemplate(
 				RedisConnectionFactory redisConnectionFactory)
 				throws UnknownHostException {
 			StringRedisTemplate template = new StringRedisTemplate();

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/AutoConfigureConfigurationClassTests.java

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.autoconfigure;
+
+import org.springframework.boot.test.AbstractConfigurationClassTests;
+
+/**
+ * Tests for the autoconfigure module's @Configuration classes
+ * @author Andy Wilkinson
+ */
+public class AutoConfigureConfigurationClassTests extends AbstractConfigurationClassTests {
+
+}

spring-boot/src/test/java/org/springframework/boot/test/AbstractConfigurationClassTests.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright 2012-2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.test;
+
+import java.io.IOException;
+import java.util.HashSet;
+import java.util.Set;
+
+import org.junit.Test;
+import org.springframework.asm.Opcodes;
+import org.springframework.beans.DirectFieldAccessor;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.io.Resource;
+import org.springframework.core.io.support.PathMatchingResourcePatternResolver;
+import org.springframework.core.io.support.ResourcePatternResolver;
+import org.springframework.core.type.AnnotationMetadata;
+import org.springframework.core.type.MethodMetadata;
+import org.springframework.core.type.classreading.MetadataReader;
+import org.springframework.core.type.classreading.SimpleMetadataReaderFactory;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * @author Andy Wilkinson
+ */
+public abstract class AbstractConfigurationClassTests {
+
+	private ResourcePatternResolver resolver = new PathMatchingResourcePatternResolver();
+
+	@Test
+	public void allBeanMethodsArePublic() throws IOException, ClassNotFoundException {
+		Set<String> nonPublicBeanMethods = new HashSet<String>();
+		for (AnnotationMetadata configurationClass : findConfigurationClasses()) {
+			Set<MethodMetadata> beanMethods = configurationClass
+					.getAnnotatedMethods(Bean.class.getName());
+			for (MethodMetadata methodMetadata : beanMethods) {
+				if (!isPublic(methodMetadata)) {
+					nonPublicBeanMethods.add(methodMetadata.getDeclaringClassName() + "."
+							+ methodMetadata.getMethodName());
+				}
+			}
+		}
+
+		assertEquals("Found non-public @Bean methods: " + nonPublicBeanMethods, 0,
+				nonPublicBeanMethods.size());
+	}
+
+	private Set<AnnotationMetadata> findConfigurationClasses() throws IOException {
+		Set<AnnotationMetadata> configurationClasses = new HashSet<AnnotationMetadata>();
+		Resource[] resources = this.resolver.getResources("classpath*:"
+				+ getClass().getPackage().getName().replace(".", "/") + "/**/*.class");
+
+		for (Resource resource : resources) {
+			if (!isTestClass(resource)) {
+				MetadataReader metadataReader = new SimpleMetadataReaderFactory()
+						.getMetadataReader(resource);
+				AnnotationMetadata annotationMetadata = metadataReader
+						.getAnnotationMetadata();
+				if (annotationMetadata.getAnnotationTypes().contains(
+						Configuration.class.getName())) {
+					configurationClasses.add(annotationMetadata);
+				}
+			}
+		}
+		return configurationClasses;
+	}
+
+	private boolean isTestClass(Resource resource) throws IOException {
+		return resource.getFile().getAbsolutePath().contains("target/test-classes");
+	}
+
+	private boolean isPublic(MethodMetadata methodMetadata) {
+		int access = (Integer) new DirectFieldAccessor(methodMetadata)
+				.getPropertyValue("access");
+
+		return (access & Opcodes.ACC_PUBLIC) != 0;
+	}
+
+}