Skip to content

Commit 6ee16a7

Browse files
wilkinsonaphilwebb
authored andcommitted
Move GraphQL observation support into spring-boot-graphql
Issue: 46141
1 parent 71a7868 commit 6ee16a7

File tree

7 files changed

+10
-9
lines changed

7 files changed

+10
-9
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure-all/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ dependencies {
118118
optional("org.springframework:spring-webmvc")
119119
optional("org.springframework.data:spring-data-couchbase")
120120
optional("org.springframework.data:spring-data-jpa")
121-
optional("org.springframework.graphql:spring-graphql")
122121
optional("org.springframework.kafka:spring-kafka")
123122
optional("org.springframework.security:spring-security-config")
124123
optional("org.springframework.security:spring-security-web")

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ org.springframework.boot.actuate.autoconfigure.management.ThreadDumpEndpointAuto
1616
org.springframework.boot.actuate.autoconfigure.metrics.data.RepositoryMetricsAutoConfiguration
1717
org.springframework.boot.actuate.autoconfigure.metrics.task.TaskExecutorMetricsAutoConfiguration
1818
org.springframework.boot.actuate.autoconfigure.observability.ObservabilityAutoConfiguration
19-
org.springframework.boot.actuate.autoconfigure.observation.graphql.GraphQlObservationAutoConfiguration
2019
org.springframework.boot.actuate.autoconfigure.observation.web.client.HttpClientObservationsAutoConfiguration
2120
org.springframework.boot.actuate.autoconfigure.observation.web.reactive.WebFluxObservationAutoConfiguration
2221
org.springframework.boot.actuate.autoconfigure.observation.web.servlet.WebMvcObservationAutoConfiguration

spring-boot-project/spring-boot-graphql/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ dependencies {
3333

3434
optional(project(":spring-boot-project:spring-boot-autoconfigure"))
3535
optional(project(":spring-boot-project:spring-boot-http-converter"))
36+
optional(project(":spring-boot-project:spring-boot-micrometer-observation"))
3637
optional(project(":spring-boot-project:spring-boot-rsocket"))
3738
optional(project(":spring-boot-project:spring-boot-security"))
3839
optional(project(":spring-boot-project:spring-boot-webflux"))
@@ -50,6 +51,7 @@ dependencies {
5051
testImplementation(project(":spring-boot-project:spring-boot-reactor-netty"))
5152
testImplementation(project(":spring-boot-project:spring-boot-test"))
5253
testImplementation(project(":spring-boot-project:spring-boot-tools:spring-boot-test-support"))
54+
testImplementation("io.micrometer:micrometer-observation-test")
5355
testImplementation("org.springframework.graphql:spring-graphql-test")
5456
testImplementation("org.springframework.security:spring-security-test")
5557

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.actuate.autoconfigure.observation.graphql;
17+
package org.springframework.boot.graphql.autoconfigure.observation;
1818

1919
import graphql.GraphQL;
2020
import io.micrometer.observation.Observation;
@@ -26,7 +26,6 @@
2626
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
2727
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2828
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
29-
import org.springframework.boot.micrometer.observation.autoconfigure.ObservationAutoConfiguration;
3029
import org.springframework.context.annotation.Bean;
3130
import org.springframework.graphql.execution.GraphQlSource;
3231
import org.springframework.graphql.observation.DataFetcherObservationConvention;
@@ -39,16 +38,17 @@
3938
* GraphQL endpoints.
4039
*
4140
* @author Brian Clozel
42-
* @since 3.0.0
41+
* @since 4.0.0
4342
*/
44-
@AutoConfiguration(after = ObservationAutoConfiguration.class)
43+
@AutoConfiguration(
44+
afterName = "org.springframework.boot.micrometer.observation.autoconfigure.ObservationAutoConfiguration")
4545
@ConditionalOnBean(ObservationRegistry.class)
4646
@ConditionalOnClass({ GraphQL.class, GraphQlSource.class, Observation.class })
4747
public class GraphQlObservationAutoConfiguration {
4848

4949
@Bean
5050
@ConditionalOnMissingBean
51-
public GraphQlObservationInstrumentation graphQlObservationInstrumentation(ObservationRegistry observationRegistry,
51+
GraphQlObservationInstrumentation graphQlObservationInstrumentation(ObservationRegistry observationRegistry,
5252
ObjectProvider<ExecutionRequestObservationConvention> executionConvention,
5353
ObjectProvider<DataFetcherObservationConvention> dataFetcherConvention,
5454
ObjectProvider<DataLoaderObservationConvention> dataLoaderObservationConvention) {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
/**
1818
* Auto-configuration for Spring GraphQL observations.
1919
*/
20-
package org.springframework.boot.actuate.autoconfigure.observation.graphql;
20+
package org.springframework.boot.graphql.autoconfigure.observation;

spring-boot-project/spring-boot-graphql/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ org.springframework.boot.graphql.autoconfigure.data.GraphQlQueryByExampleAutoCon
33
org.springframework.boot.graphql.autoconfigure.data.GraphQlQuerydslAutoConfiguration
44
org.springframework.boot.graphql.autoconfigure.data.GraphQlReactiveQueryByExampleAutoConfiguration
55
org.springframework.boot.graphql.autoconfigure.data.GraphQlReactiveQuerydslAutoConfiguration
6+
org.springframework.boot.graphql.autoconfigure.observation.GraphQlObservationAutoConfiguration
67
org.springframework.boot.graphql.autoconfigure.reactive.GraphQlWebFluxAutoConfiguration
78
org.springframework.boot.graphql.autoconfigure.rsocket.GraphQlRSocketAutoConfiguration
89
org.springframework.boot.graphql.autoconfigure.rsocket.RSocketGraphQlClientAutoConfiguration
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.actuate.autoconfigure.observation.graphql;
17+
package org.springframework.boot.graphql.autoconfigure.observation;
1818

1919
import io.micrometer.observation.ObservationRegistry;
2020
import io.micrometer.observation.tck.TestObservationRegistry;

0 commit comments

Comments
 (0)