Skip to content

Commit 76157c7

Browse files
committed
Improve null-safety of module/spring-boot-web-server
See gh-46926
1 parent 007720d commit 76157c7

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

module/spring-boot-web-server/src/main/java/org/springframework/boot/web/server/reactive/context/ReactiveWebServerApplicationContext.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,11 @@ private void createWebServer() {
102102
ReactiveWebServerFactory webServerFactory = getWebServerFactory(webServerFactoryBeanName);
103103
createWebServer.tag("factory", webServerFactory.getClass().toString());
104104
boolean lazyInit = getBeanFactory().getBeanDefinition(webServerFactoryBeanName).isLazyInit();
105-
this.serverManager = new WebServerManager(this, webServerFactory, this::getHttpHandler, lazyInit);
105+
serverManager = new WebServerManager(this, webServerFactory, this::getHttpHandler, lazyInit);
106+
this.serverManager = serverManager;
106107
getBeanFactory().registerSingleton("webServerGracefulShutdown",
107-
new WebServerGracefulShutdownLifecycle(this.serverManager.getWebServer()));
108-
getBeanFactory().registerSingleton("webServerStartStop",
109-
new WebServerStartStopLifecycle(this.serverManager));
108+
new WebServerGracefulShutdownLifecycle(serverManager.getWebServer()));
109+
getBeanFactory().registerSingleton("webServerStartStop", new WebServerStartStopLifecycle(serverManager));
110110
createWebServer.end();
111111
}
112112
initPropertySources();

module/spring-boot-web-server/src/main/java/org/springframework/boot/web/server/servlet/context/ServletWebServerApplicationContext.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,12 @@ private void createWebServer() {
187187
StartupStep createWebServer = getApplicationStartup().start("spring.boot.webserver.create");
188188
ServletWebServerFactory factory = getWebServerFactory();
189189
createWebServer.tag("factory", factory.getClass().toString());
190-
this.webServer = factory.getWebServer(getSelfInitializer());
190+
webServer = factory.getWebServer(getSelfInitializer());
191+
this.webServer = webServer;
191192
createWebServer.end();
192193
getBeanFactory().registerSingleton("webServerGracefulShutdown",
193-
new WebServerGracefulShutdownLifecycle(this.webServer));
194-
getBeanFactory().registerSingleton("webServerStartStop",
195-
new WebServerStartStopLifecycle(this, this.webServer));
194+
new WebServerGracefulShutdownLifecycle(webServer));
195+
getBeanFactory().registerSingleton("webServerStartStop", new WebServerStartStopLifecycle(this, webServer));
196196
}
197197
else if (servletContext != null) {
198198
try {

0 commit comments

Comments
 (0)