Skip to content

Commit 7afb70d

Browse files
wilkinsonaphilwebb
authored andcommitted
Move task metrics auto-configuration into spring-boot-metrics
Issue: 46147
1 parent 3581f6e commit 7afb70d

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ org.springframework.boot.actuate.autoconfigure.env.EnvironmentEndpointAutoConfig
1414
org.springframework.boot.actuate.autoconfigure.management.HeapDumpWebEndpointAutoConfiguration
1515
org.springframework.boot.actuate.autoconfigure.management.ThreadDumpEndpointAutoConfiguration
1616
org.springframework.boot.actuate.autoconfigure.metrics.data.RepositoryMetricsAutoConfiguration
17-
org.springframework.boot.actuate.autoconfigure.metrics.task.TaskExecutorMetricsAutoConfiguration
1817
org.springframework.boot.actuate.autoconfigure.observability.ObservabilityAutoConfiguration
1918
org.springframework.boot.actuate.autoconfigure.sbom.SbomEndpointAutoConfiguration
2019
org.springframework.boot.actuate.autoconfigure.scheduling.ScheduledTasksEndpointAutoConfiguration
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.actuate.autoconfigure.metrics.task;
17+
package org.springframework.boot.metrics.autoconfigure.task;
1818

1919
import java.util.Collections;
2020
import java.util.concurrent.Executor;
@@ -47,7 +47,7 @@
4747
*
4848
* @author Stephane Nicoll
4949
* @author Scott Frederick
50-
* @since 2.6.0
50+
* @since 4.0.0
5151
*/
5252
@AutoConfiguration(after = { MetricsAutoConfiguration.class, SimpleMetricsExportAutoConfiguration.class,
5353
TaskExecutionAutoConfiguration.class, TaskSchedulingAutoConfiguration.class })
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
/**
1818
* Auto-configuration for task execution and scheduling metrics.
1919
*/
20-
package org.springframework.boot.actuate.autoconfigure.metrics.task;
20+
package org.springframework.boot.metrics.autoconfigure.task;

spring-boot-project/spring-boot-metrics/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ org.springframework.boot.metrics.autoconfigure.logging.log4j2.Log4J2MetricsAutoC
2424
org.springframework.boot.metrics.autoconfigure.logging.logback.LogbackMetricsAutoConfiguration
2525
org.springframework.boot.metrics.autoconfigure.startup.StartupTimeMetricsListenerAutoConfiguration
2626
org.springframework.boot.metrics.autoconfigure.system.SystemMetricsAutoConfiguration
27+
org.springframework.boot.metrics.autoconfigure.task.TaskExecutorMetricsAutoConfiguration
Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@
2121
import io.micrometer.core.instrument.FunctionCounter;
2222
import io.micrometer.core.instrument.MeterRegistry;
2323
import io.micrometer.core.instrument.search.MeterNotFoundException;
24+
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
2425
import org.junit.jupiter.api.Test;
2526

2627
import org.springframework.boot.LazyInitializationBeanFactoryPostProcessor;
27-
import org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun;
2828
import org.springframework.boot.autoconfigure.AutoConfigurations;
2929
import org.springframework.boot.autoconfigure.task.TaskExecutionAutoConfiguration;
3030
import org.springframework.boot.autoconfigure.task.TaskSchedulingAutoConfiguration;
31+
import org.springframework.boot.metrics.autoconfigure.MetricsAutoConfiguration;
32+
import org.springframework.boot.metrics.autoconfigure.task.TaskExecutorMetricsAutoConfiguration;
3133
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3234
import org.springframework.context.annotation.Bean;
3335
import org.springframework.context.annotation.Configuration;
@@ -48,8 +50,11 @@
4850
*/
4951
class TaskExecutorMetricsAutoConfigurationTests {
5052

51-
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner().with(MetricsRun.simple())
52-
.withConfiguration(AutoConfigurations.of(TaskExecutorMetricsAutoConfiguration.class));
53+
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
54+
.withBean(SimpleMeterRegistry.class)
55+
.withConfiguration(
56+
AutoConfigurations.of(TaskExecutorMetricsAutoConfiguration.class, MetricsAutoConfiguration.class))
57+
.withPropertyValues("management.metrics.use-global-registry=false");
5358

5459
@Test
5560
void taskExecutorUsingAutoConfigurationIsInstrumented() {

0 commit comments

Comments
 (0)