Skip to content

Commit 92e420a

Browse files
committed
Merge branch '2.7.x' into 3.0.x
2 parents fc8abf1 + 57e45df commit 92e420a

File tree

13 files changed

+151
-69
lines changed

13 files changed

+151
-69
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/observation/graphql/GraphQlObservationAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2022 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/mail/MailHealthIndicator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ public MailHealthIndicator(JavaMailSenderImpl mailSender) {
3939
@Override
4040
protected void doHealthCheck(Builder builder) throws Exception {
4141
int port = this.mailSender.getPort();
42-
builder.withDetail("location", (port == JavaMailSenderImpl.DEFAULT_PORT) ? this.mailSender.getHost()
43-
: this.mailSender.getHost() + ":" + this.mailSender.getPort());
42+
builder.withDetail("location", (port != JavaMailSenderImpl.DEFAULT_PORT)
43+
? this.mailSender.getHost() + ":" + this.mailSender.getPort() : this.mailSender.getHost());
4444
this.mailSender.testConnection();
4545
builder.up();
4646
}

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/r2dbc/R2dbcProperties.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,6 @@ public static class Pool {
138138

139139
/**
140140
* Minimal number of idle connections.
141-
*
142-
* @since 2.7.12
143141
*/
144142
private int minIdle = 0;
145143

@@ -163,8 +161,6 @@ public static class Pool {
163161
/**
164162
* Maximum time to validate a connection from the pool. By default, wait
165163
* indefinitely.
166-
*
167-
* @since 2.7.12
168164
*/
169165
private Duration maxValidationTime;
170166

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/docker/DockerApi.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import java.util.HashMap;
3434
import java.util.List;
3535
import java.util.Map;
36+
import java.util.Objects;
3637
import java.util.stream.Collectors;
3738

3839
import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
@@ -121,16 +122,16 @@ private JsonStream jsonStream() {
121122
return this.jsonStream;
122123
}
123124

124-
private URI buildUrl(String path, Collection<String> params) {
125-
return buildUrl(path, StringUtils.toStringArray(params));
125+
private URI buildUrl(String path, Collection<?> params) {
126+
return buildUrl(path, (params != null) ? params.toArray() : null);
126127
}
127128

128-
private URI buildUrl(String path, String... params) {
129+
private URI buildUrl(String path, Object... params) {
129130
try {
130131
URIBuilder builder = new URIBuilder("/" + API_VERSION + path);
131132
int param = 0;
132133
while (param < params.length) {
133-
builder.addParameter(params[param++], params[param++]);
134+
builder.addParameter(Objects.toString(params[param++]), Objects.toString(params[param++]));
134135
}
135136
return builder.build();
136137
}
@@ -190,7 +191,7 @@ public Image pull(ImageReference reference, UpdateListener<PullImageUpdateEvent>
190191
throws IOException {
191192
Assert.notNull(reference, "Reference must not be null");
192193
Assert.notNull(listener, "Listener must not be null");
193-
URI createUri = buildUrl("/images/create", "fromImage", reference.toString());
194+
URI createUri = buildUrl("/images/create", "fromImage", reference);
194195
DigestCaptureUpdateListener digestCapture = new DigestCaptureUpdateListener();
195196
listener.onStart();
196197
try {
@@ -348,14 +349,9 @@ public void tag(ImageReference sourceReference, ImageReference targetReference)
348349
Assert.notNull(sourceReference, "SourceReference must not be null");
349350
Assert.notNull(targetReference, "TargetReference must not be null");
350351
String tag = targetReference.getTag();
351-
URI uri;
352-
if (tag == null) {
353-
uri = buildUrl("/images/" + sourceReference + "/tag", "repo", targetReference.toString());
354-
}
355-
else {
356-
uri = buildUrl("/images/" + sourceReference + "/tag", "repo",
357-
targetReference.inTaglessForm().toString(), "tag", tag);
358-
}
352+
String path = "/images/" + sourceReference + "/tag";
353+
URI uri = (tag != null) ? buildUrl(path, "repo", targetReference.inTaglessForm(), "tag", tag)
354+
: buildUrl(path, "repo", targetReference);
359355
http().post(uri).close();
360356
}
361357

@@ -437,7 +433,7 @@ public void start(ContainerReference reference) throws IOException {
437433
public void logs(ContainerReference reference, UpdateListener<LogUpdateEvent> listener) throws IOException {
438434
Assert.notNull(reference, "Reference must not be null");
439435
Assert.notNull(listener, "Listener must not be null");
440-
String[] params = { "stdout", "1", "stderr", "1", "follow", "1" };
436+
Object[] params = { "stdout", "1", "stderr", "1", "follow", "1" };
441437
URI uri = buildUrl("/containers/" + reference + "/logs", params);
442438
listener.onStart();
443439
try {

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/docker/ssl/PrivateKeyParser.java

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import java.security.GeneralSecurityException;
2424
import java.security.KeyFactory;
2525
import java.security.PrivateKey;
26+
import java.security.spec.InvalidKeySpecException;
2627
import java.security.spec.PKCS8EncodedKeySpec;
2728
import java.util.ArrayList;
2829
import java.util.Base64;
@@ -37,6 +38,7 @@
3738
*
3839
* @author Scott Frederick
3940
* @author Phillip Webb
41+
* @author Moritz Halbritter
4042
*/
4143
final class PrivateKeyParser {
4244

@@ -57,9 +59,9 @@ final class PrivateKeyParser {
5759
private static final List<PemParser> PEM_PARSERS;
5860
static {
5961
List<PemParser> parsers = new ArrayList<>();
60-
parsers.add(new PemParser(PKCS1_HEADER, PKCS1_FOOTER, "RSA", PrivateKeyParser::createKeySpecForPkcs1));
61-
parsers.add(new PemParser(EC_HEADER, EC_FOOTER, "EC", PrivateKeyParser::createKeySpecForEc));
62-
parsers.add(new PemParser(PKCS8_HEADER, PKCS8_FOOTER, "RSA", PKCS8EncodedKeySpec::new));
62+
parsers.add(new PemParser(PKCS1_HEADER, PKCS1_FOOTER, PrivateKeyParser::createKeySpecForPkcs1, "RSA"));
63+
parsers.add(new PemParser(EC_HEADER, EC_FOOTER, PrivateKeyParser::createKeySpecForEc, "EC"));
64+
parsers.add(new PemParser(PKCS8_HEADER, PKCS8_FOOTER, PKCS8EncodedKeySpec::new, "RSA", "EC", "DSA", "Ed25519"));
6365
PEM_PARSERS = Collections.unmodifiableList(parsers);
6466
}
6567

@@ -134,14 +136,14 @@ private static class PemParser {
134136

135137
private final Pattern pattern;
136138

137-
private final String algorithm;
138-
139139
private final Function<byte[], PKCS8EncodedKeySpec> keySpecFactory;
140140

141-
PemParser(String header, String footer, String algorithm,
142-
Function<byte[], PKCS8EncodedKeySpec> keySpecFactory) {
141+
private final String[] algorithms;
142+
143+
PemParser(String header, String footer, Function<byte[], PKCS8EncodedKeySpec> keySpecFactory,
144+
String... algorithms) {
143145
this.pattern = Pattern.compile(header + BASE64_TEXT + footer, Pattern.CASE_INSENSITIVE);
144-
this.algorithm = algorithm;
146+
this.algorithms = algorithms;
145147
this.keySpecFactory = keySpecFactory;
146148
}
147149

@@ -158,8 +160,15 @@ private static byte[] decodeBase64(String content) {
158160
private PrivateKey parse(byte[] bytes) {
159161
try {
160162
PKCS8EncodedKeySpec keySpec = this.keySpecFactory.apply(bytes);
161-
KeyFactory keyFactory = KeyFactory.getInstance(this.algorithm);
162-
return keyFactory.generatePrivate(keySpec);
163+
for (String algorithm : this.algorithms) {
164+
KeyFactory keyFactory = KeyFactory.getInstance(algorithm);
165+
try {
166+
return keyFactory.generatePrivate(keySpec);
167+
}
168+
catch (InvalidKeySpecException ex) {
169+
}
170+
}
171+
return null;
163172
}
164173
catch (GeneralSecurityException ex) {
165174
throw new IllegalArgumentException("Unexpected key format", ex);

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/ssl/PemFileWriter.java

Lines changed: 72 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
* Utility to write certificate and key PEM files for testing.
2929
*
3030
* @author Scott Frederick
31+
* @author Moritz Halbritter
3132
*/
3233
public class PemFileWriter {
3334

@@ -52,24 +53,6 @@ public class PemFileWriter {
5253
-----END TRUSTED CERTIFICATE-----
5354
""";
5455

55-
public static final String CA_PRIVATE_KEY = """
56-
%s-----BEGIN PRIVATE KEY-----
57-
MIICdwIBADANBgkqhkiG9w0BAQEFAASCAmEwggJdAgEAAoGBANWM4sVhKMs63dtA
58-
tkdYI8jwqD3xS5RulGE8k9Lbnjcuso7+qmyfJXGYO+tejtyPS7jh4WYfVPnwgwoD
59-
34g3ciXwxFvz/nbDjBcjFFz6yT83tsj6Tp71fIieQzPd7nxFYQgssy3WLtD9j94V
60-
Nlvk9/yJvQwOxTjwNrxdUqyCdqrVAgMBAAECgYEAyJTlZ8nj3Eg1nLxCue6C5jmN
61-
fWkIuanH+zFAE/0utdxJ4WA4yYAOVo1MMr8FZwu9bzHTWe2yDnWnT5/ltPeHYX2X
62-
9Pg5cY0tjq07utaMwLKWgJ0Xoh2UpVM799t/rSvMWmLaZ2c8nipX+gQfYJFpX8Vg
63-
mR3QPxwdmNyFo13qif0CQQD4z2SqCfARuxscTCJDZ6wReikMQxaJvq74lPEtT26L
64-
rBr/bN+mG7+rMEHxs5wtU47aNjUKuVVC0Qfhsf95ahvHAkEA27inSlxrwGvhvFsD
65-
FWdgDsfYpPZdL4YgpVSEvcoypRGg2suJw2omcKcY56XpkmWUqZc06QirumtnEC0P
66-
HfnsgwJBAMVhEURrOc13FxytsQiz96atuF6H4htH79o3ndQKDXI0B/7VSd6maLjP
67-
QaESkTTL8qldE1r8h4zH8m6zHC4fZQUCQFWJ+8bdWC2fUlBr9jVc+26Fqvf92aVo
68-
yEjVMKBamYDd7gt/9fAX4UM2KmH0m4wc89VaQoT+lSyMJ6GKiToYVFUCQEXcyoeO
69-
zWqtSgEX/eXQXzmMKxYnjv1O//ba3Q7UiHd/XO5j4QXAJpcB6h0h00uC5KY2d0Zy
70-
JQ1kB1C2l6l9tyc=
71-
-----END PRIVATE KEY-----""".formatted(EXAMPLE_SECRET_QUALIFIER);
72-
7356
public static final String CERTIFICATE = """
7457
-----BEGIN CERTIFICATE-----
7558
MIICjzCCAfgCAQEwDQYJKoZIhvcNAQEFBQAwgY8xCzAJBgNVBAYTAlVTMRMwEQYD
@@ -114,6 +97,77 @@ public class PemFileWriter {
11497
hOhjWFCQjnewR98Y8pEb1fnORll4LhHPlQ==
11598
-----END EC PRIVATE KEY-----""".formatted(EXAMPLE_SECRET_QUALIFIER);
11699

100+
public static final String PRIVATE_DSA_KEY = EXAMPLE_SECRET_QUALIFIER + "-----BEGIN PRIVATE KEY-----\n"
101+
+ "MIICXAIBADCCAjUGByqGSM44BAEwggIoAoIBAQCPeTXZuarpv6vtiHrPSVG28y7F\n"
102+
+ "njuvNxjo6sSWHz79NgbnQ1GpxBgzObgJ58KuHFObp0dbhdARrbi0eYd1SYRpXKwO\n"
103+
+ "jxSzNggooi/6JxEKPWKpk0U0CaD+aWxGWPhL3SCBnDcJoBBXsZWtzQAjPbpUhLYp\n"
104+
+ "H51kjviDRIZ3l5zsBLQ0pqwudemYXeI9sCkvwRGMn/qdgYHnM423krcw17njSVkv\n"
105+
+ "aAmYchU5Feo9a4tGU8YzRY+AOzKkwuDycpAlbk4/ijsIOKHEUOThjBopo33fXqFD\n"
106+
+ "3ktm/wSQPtXPFiPhWNSHxgjpfyEc2B3KI8tuOAdl+CLjQr5ITAV2OTlgHNZnAh0A\n"
107+
+ "uvaWpoV499/e5/pnyXfHhe8ysjO65YDAvNVpXQKCAQAWplxYIEhQcE51AqOXVwQN\n"
108+
+ "NNo6NHjBVNTkpcAtJC7gT5bmHkvQkEq9rI837rHgnzGC0jyQQ8tkL4gAQWDt+coJ\n"
109+
+ "syB2p5wypifyRz6Rh5uixOdEvSCBVEy1W4AsNo0fqD7UielOD6BojjJCilx4xHjG\n"
110+
+ "jQUntxyaOrsLC+EsRGiWOefTznTbEBplqiuH9kxoJts+xy9LVZmDS7TtsC98kOmk\n"
111+
+ "ltOlXVNb6/xF1PYZ9j897buHOSXC8iTgdzEpbaiH7B5HSPh++1/et1SEMWsiMt7l\n"
112+
+ "U92vAhErDR8C2jCXMiT+J67ai51LKSLZuovjntnhA6Y8UoELxoi34u1DFuHvF9ve\n"
113+
+ "BB4CHHBQgJ3ST6U8rIxoTqGe42TiVckPf1PoSiJy8GY=\n" + "-----END PRIVATE KEY-----\n";
114+
115+
public static final String PKCS8_PRIVATE_EC_NIST_P256_KEY = EXAMPLE_SECRET_QUALIFIER
116+
+ "-----BEGIN PRIVATE KEY-----\n" + "MIGTAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBHkwdwIBAQQgd6SePFfpaTKFd1Gm\n"
117+
+ "+WeHZNkORkot5hx6X9elPdICL9ygCgYIKoZIzj0DAQehRANCAASnMAMgeFBv9ks0\n"
118+
+ "d0jP+utQ3mohwmxY93xljfaBofdg1IeHgDd4I4pBzPxEnvXrU3kcz+SgPZyH1ybl\n" + "P6mSXDXu\n"
119+
+ "-----END PRIVATE KEY-----\n";
120+
121+
public static final String PKCS8_PRIVATE_EC_NIST_P384_KEY = EXAMPLE_SECRET_QUALIFIER
122+
+ "-----BEGIN PRIVATE KEY-----\n" + "MIG/AgEAMBAGByqGSM49AgEGBSuBBAAiBIGnMIGkAgEBBDCexXiWKrtrqV1+d1Tv\n"
123+
+ "t1n5huuw2A+204mQHRuPL9UC8l0XniJjx/PVELCciyJM/7+gBwYFK4EEACKhZANi\n"
124+
+ "AASHEELZSdrHiSXqU1B+/jrOCr6yjxCMqQsetTb0q5WZdCXOhggGXfbzlRynqphQ\n"
125+
+ "i4G7azBUklgLaXfxN5eFk6C+E38SYOR7iippcQsSR2ZsCiTk7rnur4b40gQ7IgLA\n" + "/sU=\n"
126+
+ "-----END PRIVATE KEY-----\n";
127+
128+
public static final String PKCS8_PRIVATE_EC_PRIME256V1_KEY = EXAMPLE_SECRET_QUALIFIER
129+
+ "-----BEGIN PRIVATE KEY-----\n" + "MIGTAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBHkwdwIBAQQg4dVuddgQ6enDvPPw\n"
130+
+ "Dd1mmS6FMm/kzTJjDVsltrNmRuSgCgYIKoZIzj0DAQehRANCAAR1WMrRADEaVj9m\n"
131+
+ "uoUfPhUefJK+lS89NHikQ0ZdkHkybyVKLFMLe1hCynhzpKQmnpgud3E10F0P2PZQ\n" + "L9RCEpGf\n"
132+
+ "-----END PRIVATE KEY-----\n";
133+
134+
public static final String PKCS8_PRIVATE_EC_SECP256R1_KEY = EXAMPLE_SECRET_QUALIFIER
135+
+ "-----BEGIN PRIVATE KEY-----\n" + "MIGTAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBHkwdwIBAQQgU9+v5hUNnTKix8fe\n"
136+
+ "Pfz+NfXFlGxQZMReSCT2Id9PfKagCgYIKoZIzj0DAQehRANCAATeJg+YS4BrJ35A\n"
137+
+ "KgRlZ59yKLDpmENCMoaYUuWbQ9hqHzdybQGzQsrNJqgH0nzWghPwP4nFaLPN+pgB\n" + "bqiRgbjG\n"
138+
+ "-----END PRIVATE KEY-----\n";
139+
140+
public static final String PKCS8_PRIVATE_RSA_KEY = EXAMPLE_SECRET_QUALIFIER + "-----BEGIN PRIVATE KEY-----\n"
141+
+ "MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQDR0KfxUw7MF/8R\n"
142+
+ "B5/YXOM7yLnoHYb/M/6dyoulMbtEdKKhQhU28o5FiDkHcEG9PJQLgqrRgAjl3VmC\n"
143+
+ "C9omtfZJQ2EpfkTttkJjnKOOroXhYE51/CYSckapBYCVh8GkjUEJuEfnp07cTfYZ\n"
144+
+ "FqViIgIWPZyjkzl3w4girS7kCuzNdDntVJVx5F/EsFwMA8n3C0QazHQoM5s00Fer\n"
145+
+ "6aTwd6AW0JD5QkADavpfzZ554e4HrVGwHlM28WKQQkFzzGu44FFXyVuEF3HeyVPu\n"
146+
+ "g8GRHAc8UU7ijVgJB5TmbvRGYowIErD5i4VvGLuOv9mgR3aVyN0SdJ1N7aJnXpeS\n"
147+
+ "QjAgf03jAgMBAAECggEBAIhQyzwj3WJGWOZkkLqOpufJotcmj/Wwf0VfOdkq9WMl\n"
148+
+ "cB/bAlN/xWVxerPVgDCFch4EWBzi1WUaqbOvJZ2u7QNubmr56aiTmJCFTVI/GyZx\n"
149+
+ "XqiTGN01N6lKtN7xo6LYTyAUhUsBTWAemrx0FSErvTVb9C/mUBj6hbEZ2XQ5kN5t\n"
150+
+ "7qYX4Lu0zyn7s1kX5SLtm5I+YRq7HSwB6wLy+DSroO71izZ/VPwME3SwT5SN+c87\n"
151+
+ "3dkklR7fumNd9dOpSWKrLPnq4aMko00rvIGc63xD1HrEpXUkB5v24YEn7HwCLEH7\n"
152+
+ "b8jrp79j2nCvvR47inpf+BR8FIWAHEOUUqCEzjQkdiECgYEA6ifjMM0f02KPeIs7\n"
153+
+ "zXd1lI7CUmJmzkcklCIpEbKWf/t/PHv3QgqIkJzERzRaJ8b+GhQ4zrSwAhrGUmI8\n"
154+
+ "kDkXIqe2/2ONgIOX2UOHYHyTDQZHnlXyDecvHUTqs2JQZCGBZkXyZ9i0j3BnTymC\n"
155+
+ "iZ8DvEa0nxsbP+U3rgzPQmXiQVMCgYEA5WN2Y/RndbriNsNrsHYRldbPO5nfV9rp\n"
156+
+ "cDzcQU66HRdK5VIdbXT9tlMYCJIZsSqE0tkOwTgEB/sFvF/tIHSCY5iO6hpIyk6g\n"
157+
+ "kkUzPcld4eM0dEPAge7SYUbakB9CMvA7MkDQSXQNFyZ0mH83+UikwT6uYHFh7+ox\n"
158+
+ "N1P+psDhXzECgYEA1gXLVQnIcy/9LxMkgDMWV8j8uMyUZysDthpbK3/uq+A2dhRg\n"
159+
+ "9g4msPd5OBQT65OpIjElk1n4HpRWfWqpLLHiAZ0GWPynk7W0D7P3gyuaRSdeQs0P\n"
160+
+ "x8FtgPVDCN9t13gAjHiWjnC26Py2kNbCKAQeJ/MAmQTvrUFX2VCACJKTcV0CgYAj\n"
161+
+ "xJWSUmrLfb+GQISLOG3Xim434e9keJsLyEGj4U29+YLRLTOvfJ2PD3fg5j8hU/rw\n"
162+
+ "Ea5uTHi8cdTcIa0M8X3fX8txD3YoLYh2JlouGTcNYOst8d6TpBSj3HN6I5Wj8beZ\n"
163+
+ "R2fy/CiKYpGtsbCdq0kdZNO18BgQW9kewncjs1GxEQKBgQCf8q34h6KuHpHSDh9h\n"
164+
+ "YkDTypk0FReWBAVJCzDNDUMhVLFivjcwtaMd2LiC3FMKZYodr52iKg60cj43vbYI\n"
165+
+ "frmFFxoL37rTmUocCTBKc0LhWj6MicI+rcvQYe1uwTrpWdFf1aZJMYRLRczeKtev\n" + "OWaE/9hVZ5+9pild1NukGpOydw==\n"
166+
+ "-----END PRIVATE KEY-----\n";
167+
168+
public static final String PKCS8_PRIVATE_EC_ED25519_KEY = EXAMPLE_SECRET_QUALIFIER + "-----BEGIN PRIVATE KEY-----\n"
169+
+ "MC4CAQAwBQYDK2VwBCIEIJOKNTaIJQTVuEqZ+yvclnjnlWJG6F+K+VsNCOlWRda+\n" + "-----END PRIVATE KEY-----";
170+
117171
private final Path tempDir;
118172

119173
public PemFileWriter() throws IOException {

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/ssl/PrivateKeyParserTests.java

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
import org.junit.jupiter.api.BeforeEach;
2929
import org.junit.jupiter.api.Nested;
3030
import org.junit.jupiter.api.Test;
31+
import org.junit.jupiter.params.ParameterizedTest;
32+
import org.junit.jupiter.params.provider.ValueSource;
3133

3234
import org.springframework.boot.buildpack.platform.docker.ssl.PrivateKeyParser.DerEncoder;
3335

@@ -39,6 +41,7 @@
3941
*
4042
* @author Scott Frederick
4143
* @author Phillip Webb
44+
* @author Moritz Halbritter
4245
*/
4346
class PrivateKeyParserTests {
4447

@@ -55,14 +58,34 @@ void tearDown() throws IOException {
5558
}
5659

5760
@Test
58-
void parsePkcs8KeyFile() throws IOException {
59-
Path path = this.fileWriter.writeFile("key.pem", PemFileWriter.CA_PRIVATE_KEY);
61+
void parsePkcs8RsaKeyFile() throws IOException {
62+
Path path = this.fileWriter.writeFile("key.pem", PemFileWriter.PKCS8_PRIVATE_RSA_KEY);
6063
PrivateKey privateKey = PrivateKeyParser.parse(path);
6164
assertThat(privateKey).isNotNull();
6265
assertThat(privateKey.getFormat()).isEqualTo("PKCS#8");
6366
Files.delete(path);
6467
}
6568

69+
@ParameterizedTest
70+
@ValueSource(strings = { PemFileWriter.PKCS8_PRIVATE_EC_NIST_P256_KEY, PemFileWriter.PKCS8_PRIVATE_EC_NIST_P384_KEY,
71+
PemFileWriter.PKCS8_PRIVATE_EC_PRIME256V1_KEY, PemFileWriter.PKCS8_PRIVATE_EC_SECP256R1_KEY })
72+
void parsePkcs8EcKeyFile(String contents) throws IOException {
73+
Path path = this.fileWriter.writeFile("key.pem", contents);
74+
PrivateKey privateKey = PrivateKeyParser.parse(path);
75+
assertThat(privateKey).isNotNull();
76+
assertThat(privateKey.getFormat()).isEqualTo("PKCS#8");
77+
assertThat(privateKey.getAlgorithm()).isEqualTo("EC");
78+
}
79+
80+
@Test
81+
void parsePkcs8DsaKeyFile() throws IOException {
82+
Path path = this.fileWriter.writeFile("key.pem", PemFileWriter.PRIVATE_DSA_KEY);
83+
PrivateKey privateKey = PrivateKeyParser.parse(path);
84+
assertThat(privateKey).isNotNull();
85+
assertThat(privateKey.getFormat()).isEqualTo("PKCS#8");
86+
assertThat(privateKey.getAlgorithm()).isEqualTo("DSA");
87+
}
88+
6689
@Test
6790
void parsePkcs1RsaKeyFile() throws IOException {
6891
Path path = this.fileWriter.writeFile("key.pem", PemFileWriter.PRIVATE_RSA_KEY);
@@ -83,6 +106,15 @@ void parsePkcs1EcKeyFile() throws IOException {
83106
Files.delete(path);
84107
}
85108

109+
@Test
110+
void parsePkcs8Ed25519KeyFile() throws IOException {
111+
Path path = this.fileWriter.writeFile("key.pem", PemFileWriter.PKCS8_PRIVATE_EC_ED25519_KEY);
112+
PrivateKey privateKey = PrivateKeyParser.parse(path);
113+
assertThat(privateKey).isNotNull();
114+
assertThat(privateKey.getFormat()).isEqualTo("PKCS#8");
115+
assertThat(privateKey.getAlgorithm()).isEqualTo("EdDSA");
116+
}
117+
86118
@Test
87119
void parseWithNonKeyFileWillThrowException() throws IOException {
88120
Path path = this.fileWriter.writeFile("text.pem", "plain text");

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/tasks/bundling/BootArchive.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2022 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/AbstractPackagerMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2022 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/junit/DisabledOnOs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2022 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)