Skip to content

Commit 96ff9e5

Browse files
committed
Remove non-transitive dependencies from spring-boot-starter-test
transitive = false maps to a wildcard exclusion in the published pom. Unfortunately, this causes problems with Maven as any dependency on one of the transitive = false modules then has all of its dependencies excluded, even when it appears elsewhere in the dependency graph without any exclusions. Gradle is not affected as it requires an exclusion to be declared on every route to a dependency for it to be effective. Maven is affected as it requires the exclusion to be present on only one route.
1 parent 84712fa commit 96ff9e5

File tree

40 files changed

+40
-13
lines changed

40 files changed

+40
-13
lines changed

smoke-test/spring-boot-smoke-test-actuator-custom-security/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ dependencies {
2626
implementation(project(":starter:spring-boot-starter-security"))
2727
implementation(project(":starter:spring-boot-starter-webmvc"))
2828

29+
testImplementation(project(":starter:spring-boot-starter-restclient"))
2930
testImplementation(project(":starter:spring-boot-starter-test"))
3031

3132
testRuntimeOnly("org.apache.httpcomponents.client5:httpclient5")

smoke-test/spring-boot-smoke-test-actuator-extension/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,6 @@ dependencies {
2424
implementation(project(":starter:spring-boot-starter-actuator"))
2525
implementation(project(":starter:spring-boot-starter-webmvc"))
2626

27+
testImplementation(project(":starter:spring-boot-starter-restclient"))
2728
testImplementation(project(":starter:spring-boot-starter-test"))
2829
}

smoke-test/spring-boot-smoke-test-actuator-ui/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,6 @@ dependencies {
2626
implementation(project(":starter:spring-boot-starter-security"))
2727
implementation(project(":starter:spring-boot-starter-webmvc"))
2828

29+
testImplementation(project(":starter:spring-boot-starter-restclient"))
2930
testImplementation(project(":starter:spring-boot-starter-test"))
3031
}

smoke-test/spring-boot-smoke-test-actuator/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ dependencies {
3030

3131
runtimeOnly("com.h2database:h2")
3232

33+
testImplementation(project(":starter:spring-boot-starter-restclient"))
3334
testImplementation(project(":starter:spring-boot-starter-test"))
3435
testRuntimeOnly("org.apache.httpcomponents.client5:httpclient5")
3536
}

smoke-test/spring-boot-smoke-test-devtools/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,6 @@ dependencies {
3030

3131
implementation(project(":starter:spring-boot-starter-webmvc"))
3232

33+
testImplementation(project(":starter:spring-boot-starter-restclient"))
3334
testImplementation(project(":starter:spring-boot-starter-test"))
3435
}

smoke-test/spring-boot-smoke-test-hateoas/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@ description = "Spring Boot HATEOAS smoke test"
2323
dependencies {
2424
implementation(project(":starter:spring-boot-starter-hateoas"))
2525

26+
testImplementation(project(":starter:spring-boot-starter-restclient"))
2627
testImplementation(project(":starter:spring-boot-starter-test"))
2728
}

smoke-test/spring-boot-smoke-test-jersey/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,6 @@ dependencies {
2727

2828
runtimeOnly("jakarta.xml.bind:jakarta.xml.bind-api")
2929

30+
testImplementation(project(":starter:spring-boot-starter-restclient"))
3031
testImplementation(project(":starter:spring-boot-starter-test"))
3132
}

smoke-test/spring-boot-smoke-test-jetty-jsp/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ dependencies {
3737

3838
runtimeOnly("org.glassfish.web:jakarta.servlet.jsp.jstl")
3939

40-
testImplementation(project(":starter:spring-boot-starter-test"))
4140
testImplementation(project(":starter:spring-boot-starter-jetty"))
41+
testImplementation(project(":starter:spring-boot-starter-restclient"))
42+
testImplementation(project(":starter:spring-boot-starter-test"))
4243
}

smoke-test/spring-boot-smoke-test-jetty-ssl/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ dependencies {
2626
exclude module: "spring-boot-starter-tomcat"
2727
}
2828

29+
testImplementation(project(":starter:spring-boot-starter-restclient"))
2930
testImplementation(project(":starter:spring-boot-starter-test"))
3031

3132
testRuntimeOnly("org.apache.httpcomponents.client5:httpclient5")

smoke-test/spring-boot-smoke-test-jetty/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,6 @@ dependencies {
2626
}
2727
implementation(project(":starter:spring-boot-starter-jetty"))
2828

29+
testImplementation(project(":starter:spring-boot-starter-restclient"))
2930
testImplementation(project(":starter:spring-boot-starter-test"))
3031
}

0 commit comments

Comments
 (0)