Skip to content

Commit 9a589ea

Browse files
committed
Fix passing of repository username and password into verify
See gh-40407
1 parent e75c931 commit 9a589ea

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,11 @@ jobs:
3838
needs: build-and-stage-release
3939
uses: ./.github/workflows/verify.yml
4040
with:
41-
repository-username: ${{ secrets.ARTIFACTORY_USERNAME }}
42-
repository-password: ${{ secrets.ARTIFACTORY_PASSWORD }}
4341
staging: true
4442
version: ${{ needs.build-and-stage-release.outputs.version }}
43+
secrets:
44+
repository-username: ${{ secrets.ARTIFACTORY_USERNAME }}
45+
repository-password: ${{ secrets.ARTIFACTORY_PASSWORD }}
4546
sync-to-maven-central:
4647
name: Sync to Maven Central
4748
needs:

.github/workflows/verify.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@ on:
99
required: false
1010
default: false
1111
type: boolean
12+
secrets:
13+
repository-username:
14+
required: false
15+
type: string
16+
repository-password:
17+
required: false
18+
type: string
1219
jobs:
1320
verify:
1421
name: Verify
@@ -46,8 +53,8 @@ jobs:
4653
RVT_VERSION: ${{ inputs.version }}
4754
RVT_RELEASE_TYPE: oss
4855
RVT_STAGING: ${{ inputs.staging }}
49-
RVT_OSS_REPOSITORY_USERNAME: ${{ inputs.repository-username }}
50-
RVT_OSS_REPOSITORY_PASSWORD: ${{ inputs.repository-password }}
56+
RVT_OSS_REPOSITORY_USERNAME: ${{ secrets.repository-username }}
57+
RVT_OSS_REPOSITORY_PASSWORD: ${{ secrets.repository-password }}
5158
run: ./gradlew spring-boot-release-verification-tests:test
5259
- name: Upload Build Reports on Failure
5360
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)