Skip to content

Commit 9bb90c9

Browse files
Fix for issue #45001 - ServletRegistrationBean has those properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <[email protected]>
Signed-off-by: Dmytro Danilenkov <[email protected]>
1 parent 839b087 commit 9bb90c9

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/servlet/ServletContextInitializerBeans.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -323,21 +323,13 @@ private void configureFromAnnotation(ServletRegistrationBean<Servlet> bean, Serv
323323
bean.setLoadOnStartup(registration.loadOnStartup());
324324
bean.setUrlMappings(Arrays.asList(registration.urlMappings()));
325325

326-
if (registration.initParameters().length > 0) {
327-
Map<String, String> initParams = new LinkedHashMap<>();
328-
for (WebInitParam param : registration.initParameters()) {
329-
initParams.put(param.name(), param.value());
330-
}
331-
bean.setInitParameters(initParams);
326+
for (WebInitParam param : registration.initParameters()) {
327+
bean.addInitParameter(param.name(), param.value());
332328
}
333329

334330
MultipartConfig multipart = registration.multipartConfig();
335-
boolean isMultipartConfigUsed = !(multipart.location().isEmpty() && multipart.maxFileSize() == -1L
336-
&& multipart.maxRequestSize() == -1L && multipart.fileSizeThreshold() == 0);
337-
if (isMultipartConfigUsed) {
338-
bean.setMultipartConfig(new MultipartConfigElement(multipart.location(), multipart.maxFileSize(),
339-
multipart.maxRequestSize(), multipart.fileSizeThreshold()));
340-
}
331+
bean.setMultipartConfig(new MultipartConfigElement(multipart.location(), multipart.maxFileSize(),
332+
multipart.maxRequestSize(), multipart.fileSizeThreshold()));
341333

342334
}
343335

0 commit comments

Comments
 (0)