Skip to content

Commit 9dccf5b

Browse files
committed
Polish
See gh-13078
1 parent 6e42810 commit 9dccf5b

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsAutoConfigurationWithLog4j2AndLogbackTests.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@
2020
import org.junit.Test;
2121
import org.junit.runner.RunWith;
2222

23-
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
2423
import org.springframework.boot.autoconfigure.AutoConfigurations;
25-
import org.springframework.boot.autoconfigure.condition.ConditionEvaluationReport;
26-
import org.springframework.boot.autoconfigure.logging.ConditionEvaluationReportMessage;
2724
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2825
import org.springframework.boot.testsupport.runner.classpath.ClassPathOverrides;
2926
import org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathRunner;
@@ -47,10 +44,6 @@ public class MetricsAutoConfigurationWithLog4j2AndLogbackTests {
4744
@Test
4845
public void doesNotConfigureLogbackMetrics() {
4946
this.contextRunner.run((context) -> {
50-
System.out.println(
51-
new ConditionEvaluationReportMessage(ConditionEvaluationReport
52-
.get((ConfigurableListableBeanFactory) context
53-
.getAutowireCapableBeanFactory())));
5447
assertThat(context).doesNotHaveBean(LogbackMetrics.class);
5548
});
5649
}

spring-boot-project/spring-boot-docs/src/main/asciidoc/spring-boot-features.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ behalf. The algorithm used to determine a `WebEnvironmentType` is fairly simple:
266266
* If Spring MVC is present, an `AnnotationConfigServletWebServerApplicationContext` is
267267
used
268268
* If Spring MVC is not present and Spring WebFlux is present, an
269-
`AnnotationConfigReactiveWebApplicationContext` is used
269+
`AnnotationConfigReactiveWebServerApplicationContext` is used
270270
* Otherwise, `AnnotationConfigApplicationContext` is used
271271

272272
This means that if you are using Spring MVC and the new `WebClient` from Spring WebFlux in

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/buildinfo/BuildInfoIntegrationTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ public void notUpToDateWhenExecutedTwiceWithFixedTimeAndChangedProjectVersion()
9191
.getOutcome()).isEqualTo(TaskOutcome.SUCCESS);
9292
BuildResult result = this.gradleBuild.build("buildInfo", "-PnullTime",
9393
"-PprojectVersion=0.2.0");
94-
System.out.println(result.getOutput());
9594
assertThat(result.task(":buildInfo").getOutcome()).isEqualTo(TaskOutcome.SUCCESS);
9695
}
9796

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/security/reactive/ApplicationContextServerWebExchangeMatcherTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public void createWhenContextClassIsNullShouldThrowException() {
5757

5858
@Test
5959
public void matchesWhenContextClassIsApplicationContextShouldProvideContext() {
60-
ServerWebExchange exchange = createHttpWebHandlerAdapter();
60+
ServerWebExchange exchange = createExchange();
6161
StaticApplicationContext context = (StaticApplicationContext) exchange
6262
.getApplicationContext();
6363
assertThat(new TestApplicationContextServerWebExchangeMatcher<>(
@@ -67,7 +67,7 @@ public void matchesWhenContextClassIsApplicationContextShouldProvideContext() {
6767

6868
@Test
6969
public void matchesWhenContextClassIsExistingBeanShouldProvideBean() {
70-
ServerWebExchange exchange = createHttpWebHandlerAdapter();
70+
ServerWebExchange exchange = createExchange();
7171
StaticApplicationContext context = (StaticApplicationContext) exchange
7272
.getApplicationContext();
7373
context.registerSingleton("existingBean", ExistingBean.class);
@@ -79,7 +79,7 @@ public void matchesWhenContextClassIsExistingBeanShouldProvideBean() {
7979

8080
@Test
8181
public void matchesWhenContextClassIsMissingBeanShouldProvideException() {
82-
ServerWebExchange exchange = createHttpWebHandlerAdapter();
82+
ServerWebExchange exchange = createExchange();
8383
Supplier<ExistingBean> supplier = new TestApplicationContextServerWebExchangeMatcher<>(
8484
ExistingBean.class).callMatchesAndReturnProvidedContext(exchange);
8585
this.thrown.expect(NoSuchBeanDefinitionException.class);
@@ -96,7 +96,7 @@ public void matchesWhenContextIsNull() {
9696
.callMatchesAndReturnProvidedContext(exchange);
9797
}
9898

99-
private ServerWebExchange createHttpWebHandlerAdapter() {
99+
private ServerWebExchange createExchange() {
100100
StaticApplicationContext context = new StaticApplicationContext();
101101
TestHttpWebHandlerAdapter adapter = new TestHttpWebHandlerAdapter(
102102
mock(WebHandler.class));

0 commit comments

Comments
 (0)