Skip to content

Commit 9f79769

Browse files
committed
Start building against Micrometer 1.14.0 snapshots
See gh-42137
1 parent f88f8f2 commit 9f79769

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/cache/CacheMetricsAutoConfigurationTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2023 the original author or authors.
2+
* Copyright 2012-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -51,7 +51,9 @@ void autoConfiguredCache2kIsInstrumented() {
5151

5252
@Test
5353
void autoConfiguredCacheManagerIsInstrumented() {
54-
this.contextRunner.withPropertyValues("spring.cache.type=caffeine", "spring.cache.cache-names=cache1,cache2")
54+
this.contextRunner
55+
.withPropertyValues("spring.cache.type=caffeine", "spring.cache.cache-names=cache1,cache2",
56+
"spring.cache.caffeine.spec=recordStats")
5557
.run((context) -> {
5658
MeterRegistry registry = context.getBean(MeterRegistry.class);
5759
registry.get("cache.gets").tags("name", "cache1").tags("cache.manager", "cacheManager").meter();

spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/cache/CacheMetricsRegistrarTests.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2023 the original author or authors.
2+
* Copyright 2012-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -41,24 +41,28 @@ class CacheMetricsRegistrarTests {
4141
void bindToSupportedCache() {
4242
CacheMetricsRegistrar registrar = new CacheMetricsRegistrar(this.meterRegistry,
4343
Collections.singleton(new CaffeineCacheMeterBinderProvider()));
44-
assertThat(registrar.bindCacheToRegistry(new CaffeineCache("test", Caffeine.newBuilder().build()))).isTrue();
44+
assertThat(
45+
registrar.bindCacheToRegistry(new CaffeineCache("test", Caffeine.newBuilder().recordStats().build())))
46+
.isTrue();
4547
assertThat(this.meterRegistry.get("cache.gets").tags("name", "test").meter()).isNotNull();
4648
}
4749

4850
@Test
4951
void bindToSupportedCacheWrappedInTransactionProxy() {
5052
CacheMetricsRegistrar registrar = new CacheMetricsRegistrar(this.meterRegistry,
5153
Collections.singleton(new CaffeineCacheMeterBinderProvider()));
52-
assertThat(registrar.bindCacheToRegistry(
53-
new TransactionAwareCacheDecorator(new CaffeineCache("test", Caffeine.newBuilder().build()))))
54+
assertThat(registrar.bindCacheToRegistry(new TransactionAwareCacheDecorator(
55+
new CaffeineCache("test", Caffeine.newBuilder().recordStats().build()))))
5456
.isTrue();
5557
assertThat(this.meterRegistry.get("cache.gets").tags("name", "test").meter()).isNotNull();
5658
}
5759

5860
@Test
5961
void bindToUnsupportedCache() {
6062
CacheMetricsRegistrar registrar = new CacheMetricsRegistrar(this.meterRegistry, Collections.emptyList());
61-
assertThat(registrar.bindCacheToRegistry(new CaffeineCache("test", Caffeine.newBuilder().build()))).isFalse();
63+
assertThat(
64+
registrar.bindCacheToRegistry(new CaffeineCache("test", Caffeine.newBuilder().recordStats().build())))
65+
.isFalse();
6266
assertThat(this.meterRegistry.find("cache.gets").tags("name", "test").meter()).isNull();
6367
}
6468

spring-boot-project/spring-boot-dependencies/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1301,7 +1301,7 @@ bom {
13011301
]
13021302
}
13031303
}
1304-
library("Micrometer", "1.14.0-M2") {
1304+
library("Micrometer", "1.14.0-SNAPSHOT") {
13051305
considerSnapshots()
13061306
group("io.micrometer") {
13071307
modules = [

0 commit comments

Comments
 (0)