Polish

Author: philwebb

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/BeanTypeRegistry.java

@@ -149,6 +149,40 @@ public void afterSingletonsInstantiated() {
 		this.beanDefinitions.clear();
 	}
 
+	private RootBeanDefinition getBeanDefinition(String name) {
+		try {
+			return (RootBeanDefinition) this.beanFactory.getMergedBeanDefinition(name);
+		}
+		catch (BeanDefinitionStoreException ex) {
+			logIgnoredError("unresolvable metadata in bean definition", name, ex);
+			return null;
+		}
+	}
+
+	private void logIgnoredError(String message, String name, Exception ex) {
+		if (BeanTypeRegistry.logger.isDebugEnabled()) {
+			BeanTypeRegistry.logger.debug("Ignoring " + message + " '" + name + "'", ex);
+		}
+	}
+
+	private boolean requiresEagerInit(String factoryBeanName) {
+		return (factoryBeanName != null && this.beanFactory.isFactoryBean(factoryBeanName)
+				&& !this.beanFactory.containsSingleton(factoryBeanName));
+	}
+
+	private void updateTypesIfNecessary() {
+		Iterator<String> names = this.beanFactory.getBeanNamesIterator();
+		while (names.hasNext()) {
+			String name = names.next();
+			if (!this.beanTypes.containsKey(name)) {
+				addBeanType(name);
+			}
+			else {
+				updateBeanType(name);
+			}
+		}
+	}
+
 	private void addBeanType(String name) {
 		if (this.beanFactory.containsSingleton(name)) {
 			this.beanTypes.put(name, this.beanFactory.getType(name));
@@ -165,13 +199,17 @@ private void addBeanTypeForNonAliasDefinition(String name) {
 		}
 	}
 
-	private RootBeanDefinition getBeanDefinition(String name) {
-		try {
-			return (RootBeanDefinition) this.beanFactory.getMergedBeanDefinition(name);
+	private void updateBeanType(String name) {
+		if (this.beanFactory.isAlias(name) || this.beanFactory.containsSingleton(name)) {
+			return;
 		}
-		catch (BeanDefinitionStoreException ex) {
-			logIgnoredError("unresolvable metadata in bean definition", name, ex);
-			return null;
+		RootBeanDefinition beanDefinition = getBeanDefinition(name);
+		if (beanDefinition == null) {
+			return;
+		}
+		RootBeanDefinition previous = this.beanDefinitions.put(name, beanDefinition);
+		if (previous != null && !beanDefinition.equals(previous)) {
+			addBeanTypeForNonAliasDefinition(name, beanDefinition);
 		}
 	}
 
@@ -200,41 +238,6 @@ private void addBeanTypeForNonAliasDefinition(String name,
 		}
 	}
 
-	private void logIgnoredError(String message, String name, Exception ex) {
-		if (BeanTypeRegistry.logger.isDebugEnabled()) {
-			BeanTypeRegistry.logger.debug("Ignoring " + message + " '" + name + "'", ex);
-		}
-	}
-
-	private boolean requiresEagerInit(String factoryBeanName) {
-		return (factoryBeanName != null && this.beanFactory.isFactoryBean(factoryBeanName)
-				&& !this.beanFactory.containsSingleton(factoryBeanName));
-	}
-
-	private void updateTypesIfNecessary() {
-		Iterator<String> names = this.beanFactory.getBeanNamesIterator();
-		while (names.hasNext()) {
-			String name = names.next();
-			if (!this.beanTypes.containsKey(name)) {
-				addBeanType(name);
-			}
-			else {
-				if (!this.beanFactory.isAlias(name)
-						&& !this.beanFactory.containsSingleton(name)) {
-					RootBeanDefinition beanDefinition = getBeanDefinition(name);
-					if (beanDefinition != null) {
-						RootBeanDefinition existingDefinition = this.beanDefinitions
-								.put(name, beanDefinition);
-						if (existingDefinition != null
-								&& !beanDefinition.equals(existingDefinition)) {
-							addBeanTypeForNonAliasDefinition(name, beanDefinition);
-						}
-					}
-				}
-			}
-		}
-	}
-
 	/**
 	 * Attempt to guess the type that a {@link FactoryBean} will return based on the
 	 * generics in its method signature.

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnBeanTests.java

@@ -347,7 +347,6 @@ public Integer testBean() {
 	public static class ConsumingConfiguration {
 
 		ConsumingConfiguration(String testBean) {
-
 		}
 
 	}

spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/classloader/RestartClassLoaderTests.java

@@ -214,8 +214,8 @@ private String readString(InputStream in) throws IOException {
 	}
 
 	private <T> List<T> toList(Enumeration<T> enumeration) {
-		return ((enumeration != null) ? Collections.list(enumeration)
-				: Collections.<T>emptyList());
+		return (enumeration != null) ? Collections.list(enumeration)
+				: Collections.<T>emptyList();
 	}
 
 }

spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/jar/ZipInflaterInputStream.java

@@ -30,19 +30,16 @@
  */
 class ZipInflaterInputStream extends InflaterInputStream {
 
-	private final Inflater inflater;
+	private int available;
 
 	private boolean extraBytesWritten;
 
-	private int available;
-
 	ZipInflaterInputStream(InputStream inputStream, int size) {
 		this(inputStream, new Inflater(true), size);
 	}
 
 	private ZipInflaterInputStream(InputStream inputStream, Inflater inflater, int size) {
-		super(inputStream, inflater, getInflaterBufferSize(size));
-		this.inflater = inflater;
+		super(inputStream, new Inflater(true), getInflaterBufferSize(size));
 		this.available = size;
 	}
 
@@ -66,7 +63,7 @@ public int read(byte[] b, int off, int len) throws IOException {
 	@Override
 	public void close() throws IOException {
 		super.close();
-		this.inflater.end();
+		this.inf.end();
 	}
 
 	@Override

spring-boot/src/main/java/org/springframework/boot/context/embedded/undertow/UndertowEmbeddedServletContainerFactory.java

@@ -450,8 +450,8 @@ public HttpHandler wrap(HttpHandler handler) {
 	private AccessLogHandler createAccessLogHandler(HttpHandler handler,
 			AccessLogReceiver accessLogReceiver) {
 		createAccessLogDirectoryIfNecessary();
-		String formatString = ((this.accessLogPattern != null) ? this.accessLogPattern
-				: "common");
+		String formatString = (this.accessLogPattern != null) ? this.accessLogPattern
+				: "common";
 		return new AccessLogHandler(handler, accessLogReceiver, formatString,
 				Undertow.class.getClassLoader());
 	}

spring-boot/src/main/java/org/springframework/boot/diagnostics/analyzer/NoSuchMethodFailureAnalyzer.java

@@ -48,24 +48,8 @@ protected FailureAnalysis analyze(Throwable rootFailure, NoSuchMethodError cause
 		if (actual == null) {
 			return null;
 		}
-		StringWriter description = new StringWriter();
-		PrintWriter writer = new PrintWriter(description);
-		writer.print("An attempt was made to call the method ");
-		writer.print(cause.getMessage());
-		writer.print(" but it does not exist. Its class, ");
-		writer.print(className);
-		writer.println(", is available from the following locations:");
-		writer.println();
-		for (URL candidate : candidates) {
-			writer.print("    ");
-			writer.println(candidate);
-		}
-		writer.println();
-		writer.println("It was loaded from the following location:");
-		writer.println();
-		writer.print("    ");
-		writer.println(actual);
-		return new FailureAnalysis(description.toString(),
+		String description = getDescription(cause, className, candidates, actual);
+		return new FailureAnalysis(description,
 				"Correct the classpath of your application so that it contains a single,"
 						+ " compatible version of " + className,
 				cause);
@@ -105,4 +89,26 @@ private URL getActual(String className) {
 		}
 	}
 
+	private String getDescription(NoSuchMethodError cause, String className,
+			List<URL> candidates, URL actual) {
+		StringWriter description = new StringWriter();
+		PrintWriter writer = new PrintWriter(description);
+		writer.print("An attempt was made to call the method ");
+		writer.print(cause.getMessage());
+		writer.print(" but it does not exist. Its class, ");
+		writer.print(className);
+		writer.println(", is available from the following locations:");
+		writer.println();
+		for (URL candidate : candidates) {
+			writer.print("    ");
+			writer.println(candidate);
+		}
+		writer.println();
+		writer.println("It was loaded from the following location:");
+		writer.println();
+		writer.print("    ");
+		writer.println(actual);
+		return description.toString();
+	}
+
 }

spring-boot/src/main/java/org/springframework/boot/web/support/SpringBootServletInitializer.java

@@ -195,7 +195,6 @@ public void onApplicationEvent(ApplicationEnvironmentPreparedEvent event) {
 				((ConfigurableWebEnvironment) environment)
 						.initPropertySources(this.servletContext, null);
 			}
-
 		}
 
 		@Override

spring-boot/src/test/java/org/springframework/boot/context/embedded/jetty/JettyEmbeddedServletContainerFactoryTests.java

@@ -383,14 +383,14 @@ public void customize(Server server) {
 				contexts.iterator().next().addEventListener(new ServletContextListener() {
 
 					@Override
-					public void contextInitialized(ServletContextEvent sce) {
+					public void contextInitialized(ServletContextEvent event) {
 						throw new RuntimeException();
 					}
 
 					@Override
-					public void contextDestroyed(ServletContextEvent sce) {
-
+					public void contextDestroyed(ServletContextEvent event) {
 					}
+
 				});
 			}
 

spring-boot/src/test/java/org/springframework/boot/diagnostics/analyzer/NoSuchMethodFailureAnalyzerTests.java

@@ -30,7 +30,9 @@
 import static org.mockito.Mockito.mock;
 
 /**
- * @author awilkinson
+ * Tests for {@link NoSuchMethodFailureAnalyzer}.
+ *
+ * @author Andy Wilkinson
  */
 @RunWith(ModifiedClassPathRunner.class)
 @ClassPathOverrides("javax.servlet:servlet-api:2.5")