Skip to content

Commit a0ffb98

Browse files
wilkinsonaphilwebb
authored andcommitted
Move Jersey metrics to spring-boot-jersey
Issue: 46116
1 parent 50b8db5 commit a0ffb98

File tree

7 files changed

+12
-11
lines changed

7 files changed

+12
-11
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure-all/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ dependencies {
108108
}
109109
optional("org.glassfish.jersey.core:jersey-server")
110110
optional("org.glassfish.jersey.containers:jersey-container-servlet-core")
111-
optional("org.glassfish.jersey.ext:jersey-micrometer")
112111
optional("org.hibernate.orm:hibernate-core")
113112
optional("org.hibernate.orm:hibernate-micrometer")
114113
optional("org.hibernate.validator:hibernate-validator")

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ org.springframework.boot.actuate.autoconfigure.env.EnvironmentEndpointAutoConfig
1414
org.springframework.boot.actuate.autoconfigure.management.HeapDumpWebEndpointAutoConfiguration
1515
org.springframework.boot.actuate.autoconfigure.management.ThreadDumpEndpointAutoConfiguration
1616
org.springframework.boot.actuate.autoconfigure.metrics.data.RepositoryMetricsAutoConfiguration
17-
org.springframework.boot.actuate.autoconfigure.metrics.jersey.JerseyServerMetricsAutoConfiguration
1817
org.springframework.boot.actuate.autoconfigure.metrics.task.TaskExecutorMetricsAutoConfiguration
1918
org.springframework.boot.actuate.autoconfigure.observability.ObservabilityAutoConfiguration
2019
org.springframework.boot.actuate.autoconfigure.observation.batch.BatchObservationAutoConfiguration
@@ -43,4 +42,4 @@ org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinTracingAutoC
4342
org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesAutoConfiguration
4443
org.springframework.boot.actuate.autoconfigure.web.exchanges.HttpExchangesEndpointAutoConfiguration
4544
org.springframework.boot.actuate.autoconfigure.web.mappings.MappingsEndpointAutoConfiguration
46-
org.springframework.boot.actuate.autoconfigure.web.servlet.ServletManagementContextAutoConfiguration
45+
org.springframework.boot.actuate.autoconfigure.web.servlet.ServletManagementContextAutoConfiguration

spring-boot-project/spring-boot-jersey/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ dependencies {
4040
optional(project(":spring-boot-project:spring-boot-actuator-autoconfigure"))
4141
optional(project(":spring-boot-project:spring-boot-autoconfigure"))
4242
optional(project(":spring-boot-project:spring-boot-jackson"))
43+
optional(project(":spring-boot-project:spring-boot-metrics"))
44+
optional(project(":spring-boot-project:spring-boot-micrometer-observation"))
4345
optional("io.projectreactor:reactor-core")
46+
optional("org.glassfish.jersey.ext:jersey-micrometer")
4447

4548
testFixturesApi(testFixtures(project(":spring-boot-project:spring-boot-actuator")))
4649
testFixturesImplementation(project(":spring-boot-project:spring-boot-tomcat"))
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.actuate.autoconfigure.metrics.jersey;
17+
package org.springframework.boot.jersey.autoconfigure.metrics;
1818

1919
import io.micrometer.core.instrument.config.MeterFilter;
2020
import io.micrometer.observation.ObservationRegistry;
@@ -32,7 +32,6 @@
3232
import org.springframework.boot.jersey.autoconfigure.ResourceConfigCustomizer;
3333
import org.springframework.boot.metrics.OnlyOnceLoggingDenyMeterFilter;
3434
import org.springframework.boot.metrics.autoconfigure.MetricsProperties;
35-
import org.springframework.boot.micrometer.observation.autoconfigure.ObservationAutoConfiguration;
3635
import org.springframework.boot.micrometer.observation.autoconfigure.ObservationProperties;
3736
import org.springframework.context.annotation.Bean;
3837
import org.springframework.core.annotation.Order;
@@ -44,9 +43,10 @@
4443
* @author Michael Simons
4544
* @author Andy Wilkinson
4645
* @author Moritz Halbritter
47-
* @since 2.1.0
46+
* @since 4.0.0
4847
*/
49-
@AutoConfiguration(after = { ObservationAutoConfiguration.class })
48+
@AutoConfiguration(
49+
afterName = "org.springframework.boot.micrometer.observation.autoconfigure.ObservationAutoConfiguration")
5050
@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.SERVLET)
5151
@ConditionalOnClass({ ResourceConfig.class, ObservationApplicationEventListener.class })
5252
@ConditionalOnBean({ ResourceConfig.class, ObservationRegistry.class })
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
/**
1818
* Auto-configuration for Jersey actuator metrics.
1919
*/
20-
package org.springframework.boot.actuate.autoconfigure.metrics.jersey;
20+
package org.springframework.boot.jersey.autoconfigure.metrics;
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
org.springframework.boot.jersey.actuate.autoconfigure.health.HealthEndpointJerseyExtensionAutoConfiguration
22
org.springframework.boot.jersey.autoconfigure.JerseyAutoConfiguration
3+
org.springframework.boot.jersey.autoconfigure.metrics.JerseyServerMetricsAutoConfiguration
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.actuate.autoconfigure.metrics.jersey;
17+
package org.springframework.boot.jersey.autoconfigure.metrics;
1818

1919
import java.net.URI;
2020

@@ -30,7 +30,6 @@
3030
import org.glassfish.jersey.server.ResourceConfig;
3131
import org.junit.jupiter.api.Test;
3232

33-
import org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun;
3433
import org.springframework.boot.autoconfigure.AutoConfigurations;
3534
import org.springframework.boot.jersey.autoconfigure.JerseyAutoConfiguration;
3635
import org.springframework.boot.jersey.autoconfigure.ResourceConfigCustomizer;
@@ -58,7 +57,7 @@
5857
*/
5958
class JerseyServerMetricsAutoConfigurationTests {
6059

61-
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner().with(MetricsRun.simple())
60+
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
6261
.withConfiguration(AutoConfigurations.of(JerseyServerMetricsAutoConfiguration.class));
6362

6463
private final WebApplicationContextRunner webContextRunner = new WebApplicationContextRunner(

0 commit comments

Comments
 (0)