Polish ArchitectureCheckTests

Signed-off-by: Dmytro Nosan <[email protected]>

Author: nosan

buildSrc/src/test/java/org/springframework/boot/build/architecture/ArchitectureCheckTests.java

@@ -73,7 +73,7 @@ void whenPackagesAreTangledShouldFailAndWriteReport(Task task) throws IOExceptio
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenPackagesAreNotTangledShouldNotFail(Task task) throws IOException {
+	void whenPackagesAreNotTangledShouldSucceedAndWriteEmptyReport(Task task) throws IOException {
 		prepareTask(task, "untangled");
 		build(this.gradleBuild, task);
 	}
@@ -99,14 +99,16 @@ void whenBeanPostProcessorBeanMethodIsStaticAndHasUnsafeParametersShouldFailAndW
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenBeanPostProcessorBeanMethodIsStaticAndHasSafeParametersShouldNotFail(Task task) throws IOException {
+	void whenBeanPostProcessorBeanMethodIsStaticAndHasSafeParametersShouldSucceedAndWriteEmptyReport(Task task)
+			throws IOException {
 		prepareTask(task, "bpp/safeparameters");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), task);
 	}
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenBeanPostProcessorBeanMethodIsStaticAndHasNoParametersShouldNotFail(Task task) throws IOException {
+	void whenBeanPostProcessorBeanMethodIsStaticAndHasNoParametersShouldSucceedAndWriteEmptyReport(Task task)
+			throws IOException {
 		prepareTask(task, "bpp/noparameters");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), task);
 	}
@@ -132,7 +134,8 @@ void whenBeanFactoryPostProcessorBeanMethodIsStaticAndHasParametersShouldFailAnd
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenBeanFactoryPostProcessorBeanMethodIsStaticAndHasNoParametersShouldNotFail(Task task) throws IOException {
+	void whenBeanFactoryPostProcessorBeanMethodIsStaticAndHasNoParametersShouldSucceedAndWriteEmptyReport(Task task)
+			throws IOException {
 		prepareTask(task, "bfpp/noparameters");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), task);
 	}
@@ -148,14 +151,15 @@ void whenClassLoadsResourceUsingResourceUtilsShouldFailAndWriteReport(Task task)
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenClassUsesResourceUtilsWithoutLoadingResourcesShouldNotFail(Task task) throws IOException {
+	void whenClassUsesResourceUtilsWithoutLoadingResourcesShouldSucceedAndWriteEmptyReport(Task task)
+			throws IOException {
 		prepareTask(task, "resources/noloads");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), task);
 	}
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenClassDoesNotCallObjectsRequireNonNullShouldNotFail(Task task) throws IOException {
+	void whenClassDoesNotCallObjectsRequireNonNullShouldSucceedAndWriteEmptyReport(Task task) throws IOException {
 		prepareTask(task, "objects/noRequireNonNull");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), task);
 	}
@@ -169,8 +173,8 @@ void whenClassCallsObjectsRequireNonNullWithMessageShouldFailAndWriteReport(Task
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenClassCallsObjectsRequireNonNullWithMessageAndProhibitObjectsRequireNonNullIsFalseShouldNotFail(Task task)
-			throws IOException {
+	void whenClassCallsObjectsRequireNonNullWithMessageAndProhibitObjectsRequireNonNullIsFalseShouldSucceedAndWriteEmptyReport(
+			Task task) throws IOException {
 		prepareTask(task, "objects/requireNonNullWithString");
 		build(this.gradleBuild.withBuildFileCustomizer((builder) -> {
 			builder.append("tasks.named('").append(task).append("') {\n");
@@ -188,8 +192,8 @@ void whenClassCallsObjectsRequireNonNullWithSupplierShouldFailAndWriteReport(Tas
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenClassCallsObjectsRequireNonNullWithSupplierAndProhibitObjectsRequireNonNullIsFalseShouldNotFail(Task task)
-			throws IOException {
+	void whenClassCallsObjectsRequireNonNullWithSupplierAndProhibitObjectsRequireNonNullIsFalseShouldSucceedAndWriteEmptyReport(
+			Task task) throws IOException {
 		prepareTask(task, "objects/requireNonNullWithSupplier");
 		build(this.gradleBuild.withBuildFileCustomizer((builder) -> {
 			builder.append("tasks.named('").append(task).append("') {\n");
@@ -214,14 +218,14 @@ void whenClassCallsStringToLowerCaseWithoutLocaleShouldFailAndWriteReport(Task t
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenClassCallsStringToLowerCaseWithLocaleShouldNotFail(Task task) throws IOException {
+	void whenClassCallsStringToLowerCaseWithLocaleShouldSucceedAndWriteEmptyReport(Task task) throws IOException {
 		prepareTask(task, "string/toLowerCaseWithLocale");
 		build(this.gradleBuild, task);
 	}
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenClassCallsStringToUpperCaseWithLocaleShouldNotFail(Task task) throws IOException {
+	void whenClassCallsStringToUpperCaseWithLocaleShouldSucceedAndWriteEmptyReport(Task task) throws IOException {
 		prepareTask(task, "string/toUpperCaseWithLocale");
 		build(this.gradleBuild, task);
 	}
@@ -260,14 +264,14 @@ void whenBeanMethodExposesPrivateTypeWithMainSourcesShouldFailAndWriteReport() t
 	}
 
 	@Test
-	void whenBeanMethodExposesPrivateTypeWithTestsSourcesShouldNotFail() throws IOException {
+	void whenBeanMethodExposesPrivateTypeWithTestsSourcesShouldSucceedAndWriteEmptyReport() throws IOException {
 		prepareTask(Task.CHECK_ARCHITECTURE_TEST, "beans/privatebean");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), Task.CHECK_ARCHITECTURE_TEST);
 	}
 
 	@ParameterizedTest(name = "{0}")
 	@EnumSource(Task.class)
-	void whenBeanMethodExposesNonPrivateTypeShouldNotFail(Task task) throws IOException {
+	void whenBeanMethodExposesNonPrivateTypeShouldSucceedAndWriteEmptyReport(Task task) throws IOException {
 		prepareTask(task, "beans/regular");
 		build(this.gradleBuild.withDependencies(SPRING_CONTEXT), task);
 	}