Skip to content

Commit a702ff5

Browse files
author
Dave Syer
committed
Make ServerProperties bean conditional on being a webapp
1 parent f8477bd commit a702ff5

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ManagementSecurityAutoConfiguration.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ private static class IgnoredPathsWebSecurityConfigurerAdapter implements
122122
@Autowired
123123
private SecurityProperties security;
124124

125-
@Autowired
125+
@Autowired(required = false)
126126
private ServerProperties server;
127127

128128
@Override
@@ -148,8 +148,10 @@ public void init(WebSecurity builder) throws Exception {
148148
if (this.errorController != null) {
149149
ignored.add(normalizePath(this.errorController.getErrorPath()));
150150
}
151-
String[] paths = this.server.getPathsArray(ignored);
152-
ignoring.antMatchers(paths);
151+
if (this.server != null) {
152+
String[] paths = this.server.getPathsArray(ignored);
153+
ignoring.antMatchers(paths);
154+
}
153155
}
154156

155157
private String normalizePath(String errorPath) {

spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ManagementServerPropertiesAutoConfiguration.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2222
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
23+
import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
2324
import org.springframework.boot.autoconfigure.security.SecurityProperties;
2425
import org.springframework.boot.autoconfigure.web.ServerProperties;
2526
import org.springframework.boot.autoconfigure.web.ServerPropertiesAutoConfiguration;
@@ -55,6 +56,7 @@ public SecurityProperties securityProperties() {
5556
// In case server auto configuration hasn't been included
5657
@Bean
5758
@ConditionalOnMissingBean
59+
@ConditionalOnWebApplication
5860
public ServerProperties serverProperties() {
5961
return new ServerProperties();
6062
}

0 commit comments

Comments
 (0)