Skip tests on Windows that exceed its file system's limitations

Author: wilkinsona

spring-boot-tests/spring-boot-integration-tests/spring-boot-server-tests/src/test/java/org/springframework/boot/context/embedded/AbstractEmbeddedServletContainerIntegrationTests.java

@@ -16,6 +16,7 @@
 
 package org.springframework.boot.context.embedded;
 
+import java.io.File;
 import java.io.IOException;
 import java.net.URI;
 import java.util.ArrayList;
@@ -110,4 +111,8 @@ public URI expand(String uriTemplate, Map<String, ?> uriVariables) {
 		});
 	}
 
+	protected boolean isWindows() {
+		return File.separatorChar == '\\';
+	}
+
 }

spring-boot-tests/spring-boot-integration-tests/spring-boot-server-tests/src/test/java/org/springframework/boot/context/embedded/ApplicationBuilder.java

@@ -90,10 +90,12 @@ private File createResourcesJar() throws IOException {
 			resourcesJarStream.putNextEntry(new ZipEntry("META-INF/resources/nested-meta-inf-resource.txt"));
 			resourcesJarStream.write("nested".getBytes());
 			resourcesJarStream.closeEntry();
-			resourcesJarStream.putNextEntry(
-					new ZipEntry("META-INF/resources/nested-reserved-!#$%&()*+,:=?@[]-meta-inf-resource.txt"));
-			resourcesJarStream.write("encoded-name".getBytes());
-			resourcesJarStream.closeEntry();
+			if (!isWindows()) {
+				resourcesJarStream.putNextEntry(
+						new ZipEntry("META-INF/resources/nested-reserved-!#$%&()*+,:=?@[]-meta-inf-resource.txt"));
+				resourcesJarStream.write("encoded-name".getBytes());
+				resourcesJarStream.closeEntry();
+			}
 			return resourcesJar;
 		}
 	}
@@ -154,4 +156,8 @@ private void packageApplication(File appFolder, File settingsXml) throws MavenIn
 		assertThat(execute.getExitCode()).isEqualTo(0);
 	}
 
+	private boolean isWindows() {
+		return File.separatorChar == '\\';
+	}
+
 }

spring-boot-tests/spring-boot-integration-tests/spring-boot-server-tests/src/test/java/org/springframework/boot/context/embedded/EmbeddedServletContainerJarDevelopmentIntegrationTests.java

@@ -18,6 +18,7 @@
 
 import java.util.Arrays;
 
+import org.junit.Assume;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -56,6 +57,7 @@ public void metaInfResourceFromDependencyIsAvailableViaHttp() {
 
 	@Test
 	public void metaInfResourceFromDependencyWithNameThatContainsReservedCharactersIsAvailableViaHttp() {
+		Assume.assumeFalse(isWindows());
 		ResponseEntity<String> entity = this.rest.getForEntity(
 				"/nested-reserved-%21%23%24%25%26%28%29%2A%2B%2C%3A%3D%3F%40%5B%5D-meta-inf-resource.txt",
 				String.class);

spring-boot-tests/spring-boot-integration-tests/spring-boot-server-tests/src/test/java/org/springframework/boot/context/embedded/EmbeddedServletContainerJarPackagingIntegrationTests.java

@@ -18,6 +18,7 @@
 
 import java.util.Arrays;
 
+import org.junit.Assume;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -56,6 +57,7 @@ public void nestedMetaInfResourceIsAvailableViaHttp() {
 
 	@Test
 	public void nestedMetaInfResourceWithNameThatContainsReservedCharactersIsAvailableViaHttp() {
+		Assume.assumeFalse(isWindows());
 		ResponseEntity<String> entity = this.rest.getForEntity(
 				"/nested-reserved-%21%23%24%25%26%28%29%2A%2B%2C%3A%3D%3F%40%5B%5D-meta-inf-resource.txt",
 				String.class);

spring-boot-tests/spring-boot-integration-tests/spring-boot-server-tests/src/test/java/org/springframework/boot/context/embedded/EmbeddedServletContainerWarDevelopmentIntegrationTests.java

@@ -24,6 +24,7 @@
 import java.util.List;
 import java.util.stream.Collectors;
 
+import org.junit.Assume;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -62,6 +63,7 @@ public void metaInfResourceFromDependencyIsAvailableViaHttp() {
 
 	@Test
 	public void metaInfResourceFromDependencyWithNameThatContainsReservedCharactersIsAvailableViaHttp() {
+		Assume.assumeFalse(isWindows());
 		ResponseEntity<String> entity = this.rest.getForEntity(
 				"/nested-reserved-%21%23%24%25%26%28%29%2A%2B%2C%3A%3D%3F%40%5B%5D-meta-inf-resource.txt",
 				String.class);

spring-boot-tests/spring-boot-integration-tests/spring-boot-server-tests/src/test/java/org/springframework/boot/context/embedded/EmbeddedServletContainerWarPackagingIntegrationTests.java

@@ -24,6 +24,7 @@
 import java.util.List;
 import java.util.stream.Collectors;
 
+import org.junit.Assume;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -62,6 +63,7 @@ public void nestedMetaInfResourceIsAvailableViaHttp() {
 
 	@Test
 	public void nestedMetaInfResourceWithNameThatContainsReservedCharactersIsAvailableViaHttp() {
+		Assume.assumeFalse(isWindows());
 		ResponseEntity<String> entity = this.rest.getForEntity(
 				"/nested-reserved-%21%23%24%25%26%28%29%2A%2B%2C%3A%3D%3F%40%5B%5D-meta-inf-resource.txt",
 				String.class);