Skip to content

Commit c6a070b

Browse files
committed
Merge pull request #14985 from alonbl
* pr/14985: Polish contribution Allow to disable SSL client authentication on the management port
2 parents 476fe6e + 33000b6 commit c6a070b

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@
303303
},
304304
{
305305
"name": "management.server.ssl.client-auth",
306-
"description": "Whether client authentication is wanted (\"want\") or needed (\"need\"). Requires a trust store."
306+
"description": "Whether client authentication is not wanted (\"none\"), wanted (\"want\") or needed (\"need\"). Requires a trust store."
307307
},
308308
{
309309
"name": "management.server.ssl.enabled",

spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@
136136
},
137137
{
138138
"name": "server.ssl.client-auth",
139-
"description": "Whether client authentication is wanted (\"want\") or needed (\"need\"). Requires a trust store."
139+
"description": "Whether client authentication is not wanted (\"none\"), wanted (\"want\") or needed (\"need\"). Requires a trust store."
140140
},
141141
{
142142
"name": "server.ssl.enabled",

spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-application-properties.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ content into your application. Rather, pick only the properties that you need.
233233
server.servlet.session.timeout=30m # Session timeout. If a duration suffix is not specified, seconds will be used.
234234
server.servlet.session.tracking-modes= # Session tracking modes.
235235
server.ssl.ciphers= # Supported SSL ciphers.
236-
server.ssl.client-auth= # Whether client authentication is wanted ("want") or needed ("need"). Requires a trust store.
236+
server.ssl.client-auth= # Whether client authentication is not wanted ("none"), wanted ("want") or needed ("need"). Requires a trust store.
237237
server.ssl.enabled=true # Whether to enable SSL support.
238238
server.ssl.enabled-protocols= # Enabled SSL protocols.
239239
server.ssl.key-alias= # Alias that identifies the key in the key store.
@@ -1205,7 +1205,7 @@ content into your application. Rather, pick only the properties that you need.
12051205
management.server.port= # Management endpoint HTTP port (uses the same port as the application by default). Configure a different port to use management-specific SSL.
12061206
management.server.servlet.context-path= # Management endpoint context-path (for instance, `/management`). Requires a custom management.server.port.
12071207
management.server.ssl.ciphers= # Supported SSL ciphers.
1208-
management.server.ssl.client-auth= # Whether client authentication is wanted ("want") or needed ("need"). Requires a trust store.
1208+
management.server.ssl.client-auth= # Whether client authentication is not wanted ("none"), wanted ("want") or needed ("need"). Requires a trust store.
12091209
management.server.ssl.enabled=true # Whether to enable SSL support.
12101210
management.server.ssl.enabled-protocols= # Enabled SSL protocols.
12111211
management.server.ssl.key-alias= # Alias that identifies the key in the key store.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/server/Ssl.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ public void setEnabled(boolean enabled) {
6969
}
7070

7171
/**
72-
* Return Whether client authentication is wanted ("want") or needed ("need").
73-
* Requires a trust store.
72+
* Return Whether client authentication is not wanted ("none"), wanted ("want") or
73+
* needed ("need"). Requires a trust store.
7474
* @return the {@link ClientAuth} to use
7575
*/
7676
public ClientAuth getClientAuth() {
@@ -243,6 +243,11 @@ public void setProtocol(String protocol) {
243243
*/
244244
public enum ClientAuth {
245245

246+
/**
247+
* Client authentication is not wanted.
248+
*/
249+
NONE,
250+
246251
/**
247252
* Client authentication is wanted but not mandatory.
248253
*/

0 commit comments

Comments
 (0)