Using configureEach instead of all to avoid unnecessary configuration

quaff · quaff · commit c76f481fcd75 · 2024-08-25T11:53:26.000+08:00
Resolving all configurations is usually bad practice, because it might trigger work that could be avoided, which will make the build slower.
diff --git a/build.gradle b/build.gradle
@@ -20,7 +20,7 @@ allprojects {
 		}
 	}
 
-	configurations.all {
+	configurations.configureEach {
 		resolutionStrategy.cacheChangingModulesFor 0, "minutes"
 	}
 }
diff --git a/buildSrc/build.gradle b/buildSrc/build.gradle
@@ -71,7 +71,7 @@ dependencies {
 	testRuntimeOnly("org.junit.platform:junit-platform-launcher")
 }
 
-configurations.all {
+configurations.configureEach {
 	exclude group:"org.slf4j", module:"slf4j-api"
 	exclude group:"ch.qos.logback", module:"logback-classic"
 	exclude group:"ch.qos.logback", module:"logback-core"
diff --git a/spring-boot-project/spring-boot-autoconfigure/build.gradle b/spring-boot-project/spring-boot-autoconfigure/build.gradle
@@ -10,7 +10,7 @@ plugins {
 
 description = "Spring Boot AutoConfigure"
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy.eachDependency { DependencyResolveDetails details ->
 		if (details.requested.module.group == "org.apache.kafka" && details.requested.module.name == "kafka-server-common") {
 			details.artifactSelection {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/configure-platform.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/configure-platform.gradle
@@ -17,7 +17,7 @@ repositories {
 	maven { url 'repository' }
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (it.requested.group == 'org.springframework.boot') {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/configure-platform.gradle.kts b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/configure-platform.gradle.kts
@@ -19,7 +19,7 @@ repositories {
 	}
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (requested.group == "org.springframework.boot") {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/custom-version-with-platform.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/custom-version-with-platform.gradle
@@ -12,7 +12,7 @@ repositories {
 	maven { url 'repository' }
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (it.requested.group == 'org.springframework.boot') {
@@ -23,7 +23,7 @@ configurations.all {
 }
 
 // tag::custom-version[]
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy.eachDependency { DependencyResolveDetails details ->
 		if (details.requested.group == 'org.slf4j') {
 			details.useVersion '1.7.20'
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/custom-version-with-platform.gradle.kts b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/examples/managing-dependencies/custom-version-with-platform.gradle.kts
@@ -14,7 +14,7 @@ repositories {
 	}
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (requested.group == "org.springframework.boot") {
@@ -25,7 +25,7 @@ configurations.all {
 }
 
 // tag::custom-version[]
-configurations.all {
+configurations.configureEach {
     resolutionStrategy.eachDependency {
         if (requested.group == "org.slf4j") {
             useVersion("1.7.20")
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotDoesNotHaveDevelopmentOnlyDependenciesOnItsClasspath.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotDoesNotHaveDevelopmentOnlyDependenciesOnItsClasspath.gradle
@@ -10,7 +10,7 @@ repositories {
 	maven { url 'repository' }
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (it.requested.group == 'org.springframework.boot') {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotHasLibraryResourcesOnItsClasspath.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotHasLibraryResourcesOnItsClasspath.gradle
@@ -9,7 +9,7 @@ repositories {
 	maven { url 'repository' }
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (it.requested.group == 'org.springframework.boot') {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotHasTestAndDevelopmentOnlyDependenciesOnItsClasspath.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotHasTestAndDevelopmentOnlyDependenciesOnItsClasspath.gradle
@@ -10,7 +10,7 @@ repositories {
 	maven { url 'repository' }
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (it.requested.group == 'org.springframework.boot') {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotHasTransitiveRuntimeDependenciesOnItsClasspath.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/SpringBootAotPluginIntegrationTests-processTestAotHasTransitiveRuntimeDependenciesOnItsClasspath.gradle
@@ -9,7 +9,7 @@ repositories {
 	maven { url 'repository' }
 }
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy {
 		eachDependency {
 			if (it.requested.group == 'org.springframework.boot') {
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/tasks/bundling/BootJarIntegrationTests-duplicatesAreHandledGracefully.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/tasks/bundling/BootJarIntegrationTests-duplicatesAreHandledGracefully.gradle
@@ -12,7 +12,7 @@ configurations {
 	provided
 }
 
-sourceSets.all {
+sourceSets.configureEach {
 	compileClasspath += configurations.provided
 	runtimeClasspath += configurations.provided
 }
diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/tasks/bundling/BootWarIntegrationTests-duplicatesAreHandledGracefully.gradle b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/tasks/bundling/BootWarIntegrationTests-duplicatesAreHandledGracefully.gradle
@@ -12,7 +12,7 @@ configurations {
 	provided
 }
 
-sourceSets.all {
+sourceSets.configureEach {
 	compileClasspath += configurations.provided
 	runtimeClasspath += configurations.provided
 }
diff --git a/spring-boot-system-tests/spring-boot-deployment-tests/build.gradle b/spring-boot-system-tests/spring-boot-deployment-tests/build.gradle
@@ -12,7 +12,7 @@ configurations {
 	}
 }
 
-configurations.all {
+configurations.configureEach {
 	exclude module: "spring-boot-starter-logging"
 }
 
diff --git a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-actuator-log4j2/build.gradle b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-actuator-log4j2/build.gradle
@@ -5,7 +5,7 @@ plugins {
 
 description = "Spring Boot Actuator Log4j 2 smoke test"
 
-configurations.all {
+configurations.configureEach {
 	exclude module: "spring-boot-starter-logging"
 }
 
diff --git a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-kafka/build.gradle b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-kafka/build.gradle
@@ -6,7 +6,7 @@ plugins {
 
 description = "Spring Boot Kafka smoke test"
 
-configurations.all {
+configurations.configureEach {
 	resolutionStrategy.eachDependency { DependencyResolveDetails details ->
 		if (details.requested.module.group == "org.apache.kafka" && details.requested.module.name == "kafka-server-common") {
 			details.artifactSelection {
diff --git a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-structure-logging-log4j2/build.gradle b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-structure-logging-log4j2/build.gradle
@@ -5,7 +5,7 @@ plugins {
 
 description = "Spring Boot structure logging Log4j2 smoke test"
 
-configurations.all {
+configurations.configureEach {
 	exclude module: "spring-boot-starter-logging"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ allprojects {`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`
`23`		`- configurations.all {`
	`23`	`+ configurations.configureEach {`
`24`	`24`	`resolutionStrategy.cacheChangingModulesFor 0, "minutes"`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ dependencies {`
`71`	`71`	`testRuntimeOnly("org.junit.platform:junit-platform-launcher")`
`72`	`72`	`}`
`73`	`73`
`74`		`-configurations.all {`
	`74`	`+configurations.configureEach {`
`75`	`75`	`exclude group:"org.slf4j", module:"slf4j-api"`
`76`	`76`	`exclude group:"ch.qos.logback", module:"logback-classic"`
`77`	`77`	`exclude group:"ch.qos.logback", module:"logback-core"`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ repositories {`
`17`	`17`	`maven { url 'repository' }`
`18`	`18`	`}`
`19`	`19`
`20`		`-configurations.all {`
	`20`	`+configurations.configureEach {`
`21`	`21`	`resolutionStrategy {`
`22`	`22`	`eachDependency {`
`23`	`23`	`if (it.requested.group == 'org.springframework.boot') {`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ repositories {`
`19`	`19`	`}`
`20`	`20`	`}`
`21`	`21`
`22`		`-configurations.all {`
	`22`	`+configurations.configureEach {`
`23`	`23`	`resolutionStrategy {`
`24`	`24`	`eachDependency {`
`25`	`25`	`if (requested.group == "org.springframework.boot") {`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ repositories {`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`
`17`		`-configurations.all {`
	`17`	`+configurations.configureEach {`
`18`	`18`	`resolutionStrategy {`
`19`	`19`	`eachDependency {`
`20`	`20`	`if (requested.group == "org.springframework.boot") {`
`@@ -25,7 +25,7 @@ configurations.all {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`// tag::custom-version[]`
`28`		`-configurations.all {`
	`28`	`+configurations.configureEach {`
`29`	`29`	`resolutionStrategy.eachDependency {`
`30`	`30`	`if (requested.group == "org.slf4j") {`
`31`	`31`	`useVersion("1.7.20")`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ repositories {`
`10`	`10`	`maven { url 'repository' }`
`11`	`11`	`}`
`12`	`12`
`13`		`-configurations.all {`
	`13`	`+configurations.configureEach {`
`14`	`14`	`resolutionStrategy {`
`15`	`15`	`eachDependency {`
`16`	`16`	`if (it.requested.group == 'org.springframework.boot') {`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ repositories {`
`9`	`9`	`maven { url 'repository' }`
`10`	`10`	`}`
`11`	`11`
`12`		`-configurations.all {`
	`12`	`+configurations.configureEach {`
`13`	`13`	`resolutionStrategy {`
`14`	`14`	`eachDependency {`
`15`	`15`	`if (it.requested.group == 'org.springframework.boot') {`