Fix URL filtering when loading from a directory

The ExplodedArchive would erroneously always attempt to filter
its contents (and thereby shield them from a classloader that wrapped
it) even if they haven't been explicitly provided.

See gh-1352

Author: Dave Syer

spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/archive/ExplodedArchive.java

@@ -56,7 +56,7 @@ public class ExplodedArchive extends Archive {
 
 	private Manifest manifest;
 
-	private boolean recursive = true;
+	private boolean filtered = false;
 
 	/**
 	 * Create a new {@link ExplodedArchive} instance.
@@ -78,17 +78,18 @@ public ExplodedArchive(File root, boolean recursive) {
 			throw new IllegalArgumentException("Invalid source folder " + root);
 		}
 		this.root = root;
-		this.recursive = recursive;
-		buildEntries(root);
+		buildEntries(root, recursive);
 		this.entries = Collections.unmodifiableMap(this.entries);
 	}
 
 	private ExplodedArchive(File root, Map<AsciiBytes, Entry> entries) {
 		this.root = root;
+		// The entries are pre-filtered
+		this.filtered = true;
 		this.entries = Collections.unmodifiableMap(entries);
 	}
 
-	private void buildEntries(File file) {
+	private void buildEntries(File file, boolean recursive) {
 		if (!file.equals(this.root)) {
 			String name = file.toURI().getPath()
 					.substring(this.root.toURI().getPath().length());
@@ -102,9 +103,9 @@ private void buildEntries(File file) {
 			}
 			for (File child : files) {
 				if (!SKIPPED_NAMES.contains(child.getName())) {
-					if (file.equals(this.root) || this.recursive
+					if (file.equals(this.root) || recursive
 							|| file.getName().equals("META-INF")) {
-						buildEntries(child);
+						buildEntries(child, recursive);
 					}
 				}
 			}
@@ -113,7 +114,8 @@ private void buildEntries(File file) {
 
 	@Override
 	public URL getUrl() throws MalformedURLException {
-		FilteredURLStreamHandler handler = new FilteredURLStreamHandler();
+		FilteredURLStreamHandler handler = this.filtered ? new FilteredURLStreamHandler()
+				: null;
 		return new URL("file", "", -1, this.root.toURI().getPath(), handler);
 	}
 

spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/archive/ExplodedArchiveTests.java

@@ -147,6 +147,7 @@ public AsciiBytes apply(AsciiBytes entryName, Entry entry) {
 				new URL[] { filteredArchive.getUrl() });
 		assertThat(classLoader.getResourceAsStream("1.dat").read(), equalTo(1));
 		assertThat(classLoader.getResourceAsStream("2.dat"), nullValue());
+		classLoader.close();
 	}
 
 	@Test
@@ -173,6 +174,25 @@ public void getNonRecursiveManifestEvenIfNonRecursive() throws Exception {
 		assertThat(entries.size(), equalTo(3));
 	}
 
+	@Test
+	public void getResourceAsStream() throws Exception {
+		ExplodedArchive archive = new ExplodedArchive(new File("src/test/resources/root"));
+		assertNotNull(archive.getManifest());
+		URLClassLoader loader = new URLClassLoader(new URL[] { archive.getUrl() });
+		assertNotNull(loader.getResourceAsStream("META-INF/spring/application.xml"));
+		loader.close();
+	}
+
+	@Test
+	public void getResourceAsStreamNonRecursive() throws Exception {
+		ExplodedArchive archive = new ExplodedArchive(
+				new File("src/test/resources/root"), false);
+		assertNotNull(archive.getManifest());
+		URLClassLoader loader = new URLClassLoader(new URL[] { archive.getUrl() });
+		assertNotNull(loader.getResourceAsStream("META-INF/spring/application.xml"));
+		loader.close();
+	}
+
 	private Map<String, Archive.Entry> getEntriesMap(Archive archive) {
 		Map<String, Archive.Entry> entries = new HashMap<String, Archive.Entry>();
 		for (Archive.Entry entry : archive.getEntries()) {

spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/jar/JarFileTests.java

@@ -97,6 +97,7 @@ public void jdkJarFile() throws Exception {
 		assertThat(urlClassLoader.getResource("special/\u00EB.dat"), notNullValue());
 		assertThat(urlClassLoader.getResource("d/9.dat"), notNullValue());
 		jarFile.close();
+		urlClassLoader.close();
 	}
 
 	@Test
@@ -139,6 +140,7 @@ public void getSpecialResourceViaClassLoader() throws Exception {
 		URLClassLoader urlClassLoader = new URLClassLoader(
 				new URL[] { this.jarFile.getUrl() });
 		assertThat(urlClassLoader.getResource("special/\u00EB.dat"), notNullValue());
+		urlClassLoader.close();
 	}
 
 	@Test