Skip to content

Commit cfb037e

Browse files
committed
Fix tests to compare predicate rather than customizer
1 parent 1f7515d commit cfb037e

File tree

2 files changed

+22
-6
lines changed

2 files changed

+22
-6
lines changed

module/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/autoconfigure/WebFluxAutoConfigurationTests.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import java.util.concurrent.Executor;
3232
import java.util.concurrent.TimeUnit;
3333
import java.util.function.Consumer;
34+
import java.util.function.Predicate;
3435

3536
import jakarta.validation.ValidatorFactory;
3637
import org.aspectj.lang.JoinPoint;
@@ -45,6 +46,7 @@
4546
import org.junit.jupiter.params.provider.ValueSource;
4647

4748
import org.springframework.aop.support.AopUtils;
49+
import org.springframework.beans.factory.annotation.Qualifier;
4850
import org.springframework.boot.autoconfigure.AutoConfigurations;
4951
import org.springframework.boot.autoconfigure.task.TaskExecutionAutoConfiguration;
5052
import org.springframework.boot.http.codec.CodecCustomizer;
@@ -897,7 +899,7 @@ void apiVersionBeansAreInjected() {
897899
.isEqualTo(context.getBean(ApiVersionDeprecationHandler.class));
898900
assertThat(versionStrategy).extracting("versionParser").isEqualTo(context.getBean(ApiVersionParser.class));
899901
assertThat(versionStrategy).extracting("supportedVersionPredicate")
900-
.isEqualTo(context.getBean(ApiVersionCustomizer.class));
902+
.isEqualTo(context.getBean("supportedVersionPredicate"));
901903
});
902904
}
903905

@@ -1315,8 +1317,14 @@ ApiVersionParser<String> apiVersionParser() {
13151317
}
13161318

13171319
@Bean
1318-
ApiVersionCustomizer apiVersionCustomizer() {
1319-
return (configurer) -> configurer.setSupportedVersionPredicate((comparable) -> true);
1320+
Predicate<Comparable<?>> supportedVersionPredicate() {
1321+
return (comparable) -> true;
1322+
}
1323+
1324+
@Bean
1325+
ApiVersionCustomizer apiVersionCustomizer(
1326+
@Qualifier("supportedVersionPredicate") Predicate<Comparable<?>> supportedVersionPredicate) {
1327+
return (configurer) -> configurer.setSupportedVersionPredicate(supportedVersionPredicate);
13201328
}
13211329

13221330
}

module/spring-boot-webmvc/src/test/java/org/springframework/boot/webmvc/autoconfigure/WebMvcAutoConfigurationTests.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import java.util.concurrent.Executor;
3333
import java.util.concurrent.TimeUnit;
3434
import java.util.function.Consumer;
35+
import java.util.function.Predicate;
3536

3637
import jakarta.servlet.http.HttpServletRequest;
3738
import jakarta.servlet.http.HttpServletResponse;
@@ -43,6 +44,7 @@
4344
import org.junit.jupiter.api.Test;
4445

4546
import org.springframework.aop.support.AopUtils;
47+
import org.springframework.beans.factory.annotation.Qualifier;
4648
import org.springframework.boot.autoconfigure.AutoConfigurations;
4749
import org.springframework.boot.autoconfigure.context.PropertyPlaceholderAutoConfiguration;
4850
import org.springframework.boot.autoconfigure.task.TaskExecutionAutoConfiguration;
@@ -1102,7 +1104,7 @@ void apiVersionBeansAreInjected() {
11021104
.isEqualTo(context.getBean(ApiVersionDeprecationHandler.class));
11031105
assertThat(versionStrategy).extracting("versionParser").isEqualTo(context.getBean(ApiVersionParser.class));
11041106
assertThat(versionStrategy).extracting("supportedVersionPredicate")
1105-
.isEqualTo(context.getBean(ApiVersionCustomizer.class));
1107+
.isEqualTo(context.getBean("supportedVersionPredicate"));
11061108
});
11071109
}
11081110

@@ -1686,8 +1688,14 @@ ApiVersionParser<String> apiVersionParser() {
16861688
}
16871689

16881690
@Bean
1689-
ApiVersionCustomizer apiVersionCustomizer() {
1690-
return (configurer) -> configurer.setSupportedVersionPredicate((comparable) -> true);
1691+
Predicate<Comparable<?>> supportedVersionPredicate() {
1692+
return (comparable) -> true;
1693+
}
1694+
1695+
@Bean
1696+
ApiVersionCustomizer apiVersionCustomizer(
1697+
@Qualifier("supportedVersionPredicate") Predicate<Comparable<?>> supportedVersionPredicate) {
1698+
return (configurer) -> configurer.setSupportedVersionPredicate(supportedVersionPredicate);
16911699
}
16921700

16931701
}

0 commit comments

Comments
 (0)