Extract sub-properties methods to PropertySourceUtils

The static convenience methods in RelaxedPropertyResolver were not
really relaxed, so since they are public (and useful) it makes
more sense to extract them to a utility class.

Author: Dave Syer

spring-boot/src/main/java/org/springframework/boot/bind/PropertySourceUtils.java

@@ -0,0 +1,92 @@
+/*
+ * Copyright 2012-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.bind;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.springframework.core.env.EnumerablePropertySource;
+import org.springframework.core.env.PropertySource;
+import org.springframework.core.env.PropertySources;
+
+/**
+ * Convenience class for manipulating PropertySources.
+ * 
+ * @author Dave Syer
+ * 
+ * @see PropertySource
+ * @see PropertySources
+ */
+public abstract class PropertySourceUtils {
+
+	/**
+	 * Return a Map of all values from the specified {@link PropertySources} that start
+	 * with a particular key.
+	 * @param propertySources the property sources to scan
+	 * @param keyPrefix the key prefixes to test
+	 * @return a map of all sub properties starting with the specified key prefixes.
+	 * @see PropertySourceUtils#getSubProperties(PropertySources, String, String)
+	 */
+	public static Map<String, Object> getSubProperties(PropertySources propertySources,
+			String keyPrefix) {
+		return PropertySourceUtils.getSubProperties(propertySources, null, keyPrefix);
+	}
+
+	/**
+	 * Return a Map of all values from the specified {@link PropertySources} that start
+	 * with a particular key.
+	 * @param propertySources the property sources to scan
+	 * @param rootPrefix a root prefix to be prepended to the keyPrefex (can be
+	 * {@code null})
+	 * @param keyPrefix the key prefixes to test
+	 * @return a map of all sub properties starting with the specified key prefixes.
+	 * @see #getSubProperties(PropertySources, String, String)
+	 */
+	public static Map<String, Object> getSubProperties(PropertySources propertySources,
+			String rootPrefix, String keyPrefix) {
+		RelaxedNames keyPrefixes = new RelaxedNames(keyPrefix);
+		Map<String, Object> subProperties = new LinkedHashMap<String, Object>();
+		for (PropertySource<?> source : propertySources) {
+			if (source instanceof EnumerablePropertySource) {
+				for (String name : ((EnumerablePropertySource<?>) source)
+						.getPropertyNames()) {
+					String key = PropertySourceUtils.getSubKey(name, rootPrefix,
+							keyPrefixes);
+					if (key != null) {
+						subProperties.put(key, source.getProperty(name));
+					}
+				}
+			}
+		}
+		return Collections.unmodifiableMap(subProperties);
+	}
+
+	private static String getSubKey(String name, String rootPrefixes,
+			RelaxedNames keyPrefix) {
+		rootPrefixes = (rootPrefixes == null ? "" : rootPrefixes);
+		for (String rootPrefix : new RelaxedNames(rootPrefixes)) {
+			for (String candidateKeyPrefix : keyPrefix) {
+				if (name.startsWith(rootPrefix + candidateKeyPrefix)) {
+					return name.substring((rootPrefix + candidateKeyPrefix).length());
+				}
+			}
+		}
+		return null;
+	}
+
+}

spring-boot/src/main/java/org/springframework/boot/bind/RelaxedPropertyResolver.java

@@ -16,14 +16,10 @@
 
 package org.springframework.boot.bind;
 
-import java.util.Collections;
-import java.util.LinkedHashMap;
 import java.util.Map;
 
 import org.springframework.core.env.ConfigurableEnvironment;
-import org.springframework.core.env.EnumerablePropertySource;
 import org.springframework.core.env.PropertyResolver;
-import org.springframework.core.env.PropertySource;
 import org.springframework.core.env.PropertySources;
 import org.springframework.util.Assert;
 
@@ -141,68 +137,14 @@ public String resolveRequiredPlaceholders(String text)
 	 * {@link ConfigurableEnvironment}.
 	 * @param keyPrefix the key prefix used to filter results
 	 * @return a map of all sub properties starting with the specified key prefix.
-	 * @see #getSubProperties(PropertySources, String)
-	 * @see #getSubProperties(PropertySources, String, String)
+	 * @see PropertySourceUtils#getSubProperties(PropertySources, String)
+	 * @see PropertySourceUtils#getSubProperties(PropertySources, String, String)
 	 */
 	public Map<String, Object> getSubProperties(String keyPrefix) {
 		Assert.isInstanceOf(ConfigurableEnvironment.class, this.resolver,
 				"SubProperties not available.");
 		ConfigurableEnvironment env = (ConfigurableEnvironment) this.resolver;
-		return getSubProperties(env.getPropertySources(), this.prefix, keyPrefix);
-	}
-
-	/**
-	 * Return a Map of all values from the specified {@link PropertySources} that start
-	 * with a particular key.
-	 * @param propertySources the property sources to scan
-	 * @param keyPrefix the key prefixes to test
-	 * @return a map of all sub properties starting with the specified key prefixes.
-	 * @see #getSubProperties(PropertySources, String, String)
-	 */
-	public static Map<String, Object> getSubProperties(PropertySources propertySources,
-			String keyPrefix) {
-		return getSubProperties(propertySources, null, keyPrefix);
-	}
-
-	/**
-	 * Return a Map of all values from the specified {@link PropertySources} that start
-	 * with a particular key.
-	 * @param propertySources the property sources to scan
-	 * @param rootPrefix a root prefix to be prepended to the keyPrefex (can be
-	 * {@code null})
-	 * @param keyPrefix the key prefixes to test
-	 * @return a map of all sub properties starting with the specified key prefixes.
-	 * @see #getSubProperties(PropertySources, String, String)
-	 */
-	public static Map<String, Object> getSubProperties(PropertySources propertySources,
-			String rootPrefix, String keyPrefix) {
-		RelaxedNames keyPrefixes = new RelaxedNames(keyPrefix);
-		Map<String, Object> subProperties = new LinkedHashMap<String, Object>();
-		for (PropertySource<?> source : propertySources) {
-			if (source instanceof EnumerablePropertySource) {
-				for (String name : ((EnumerablePropertySource<?>) source)
-						.getPropertyNames()) {
-					String key = getSubKey(name, rootPrefix, keyPrefixes);
-					if (key != null) {
-						subProperties.put(key, source.getProperty(name));
-					}
-				}
-			}
-		}
-		return Collections.unmodifiableMap(subProperties);
-	}
-
-	private static String getSubKey(String name, String rootPrefixes,
-			RelaxedNames keyPrefix) {
-		rootPrefixes = (rootPrefixes == null ? "" : rootPrefixes);
-		for (String rootPrefix : new RelaxedNames(rootPrefixes)) {
-			for (String candidateKeyPrefix : keyPrefix) {
-				if (name.startsWith(rootPrefix + candidateKeyPrefix)) {
-					return name.substring((rootPrefix + candidateKeyPrefix).length());
-				}
-			}
-		}
-		return null;
+		return PropertySourceUtils.getSubProperties(env.getPropertySources(), this.prefix, keyPrefix);
 	}
 
 }