Skip to content

Commit dcb17a7

Browse files
author
Dave Syer
committed
Enhance @conditionals for JMX autconfig
Fixes gh-1059
1 parent bc85f38 commit dcb17a7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/integration/IntegrationAutoConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2323
import org.springframework.boot.autoconfigure.condition.ConditionalOnExpression;
2424
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
25+
import org.springframework.boot.autoconfigure.condition.SearchStrategy;
2526
import org.springframework.boot.autoconfigure.jmx.JmxAutoConfiguration;
2627
import org.springframework.context.annotation.Bean;
2728
import org.springframework.context.annotation.Configuration;
2829
import org.springframework.integration.config.EnableIntegration;
2930
import org.springframework.integration.jmx.config.EnableIntegrationMBeanExport;
30-
import org.springframework.integration.jmx.config.IntegrationMBeanExportConfiguration;
31+
import org.springframework.integration.monitor.IntegrationMBeanExporter;
3132
import org.springframework.jmx.support.MBeanServerFactoryBean;
3233

3334
/**
@@ -50,7 +51,7 @@ protected static class IntegrationConfiguration {
5051

5152
@Configuration
5253
@ConditionalOnClass(EnableIntegrationMBeanExport.class)
53-
@ConditionalOnMissingBean(IntegrationMBeanExportConfiguration.class)
54+
@ConditionalOnMissingBean(value = IntegrationMBeanExporter.class, search = SearchStrategy.CURRENT)
5455
@ConditionalOnExpression("${spring.jmx.enabled:true}")
5556
@EnableIntegrationMBeanExport(defaultDomain = "${spring.jmx.default_domain:}", server = "${spring.jmx.server:mbeanServer}")
5657
protected static class IntegrationJmxConfiguration {

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2323
import org.springframework.boot.autoconfigure.condition.ConditionalOnExpression;
2424
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
25+
import org.springframework.boot.autoconfigure.condition.SearchStrategy;
2526
import org.springframework.context.annotation.Bean;
2627
import org.springframework.context.annotation.Configuration;
2728
import org.springframework.context.annotation.EnableMBeanExport;
@@ -42,7 +43,7 @@
4243
public class JmxAutoConfiguration {
4344

4445
@Configuration
45-
@ConditionalOnMissingBean({ MBeanExporter.class })
46+
@ConditionalOnMissingBean(value = MBeanExporter.class, search = SearchStrategy.CURRENT)
4647
@EnableMBeanExport(defaultDomain = "${spring.jmx.default_domain:}", server = "${spring.jmx.server:mbeanServer}")
4748
public static class MBeanExport {
4849
}

0 commit comments

Comments
 (0)