Skip to content

Commit e14a2e3

Browse files
committed
Deprecate queue size property for StatsD metrics export
Closes gh-13108
1 parent c826310 commit e14a2e3

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/statsd/StatsdProperties.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import io.micrometer.statsd.StatsdFlavor;
2222

2323
import org.springframework.boot.context.properties.ConfigurationProperties;
24+
import org.springframework.boot.context.properties.DeprecatedConfigurationProperty;
2425

2526
/**
2627
* {@link ConfigurationProperties} for configuring StatsD metrics export.
@@ -122,10 +123,13 @@ public void setPollingFrequency(Duration pollingFrequency) {
122123
this.pollingFrequency = pollingFrequency;
123124
}
124125

126+
@Deprecated
127+
@DeprecatedConfigurationProperty(reason = "No longer configurable and an unbounded queue will always be used")
125128
public Integer getQueueSize() {
126129
return this.queueSize;
127130
}
128131

132+
@Deprecated
129133
public void setQueueSize(Integer queueSize) {
130134
this.queueSize = queueSize;
131135
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/statsd/StatsdPropertiesConfigAdapter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ public Duration pollingFrequency() {
7474
}
7575

7676
@Override
77+
@Deprecated
7778
public int queueSize() {
7879
return get(StatsdProperties::getQueueSize, StatsdConfig.super::queueSize);
7980
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,10 @@
280280
},
281281
{
282282
"name": "management.metrics.export.statsd.queue-size",
283-
"defaultValue": 2147483647
283+
"defaultValue": 2147483647,
284+
"deprecation": {
285+
"level": "error"
286+
}
284287
},
285288
{
286289
"name": "management.trace.http.enabled",

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/statsd/StatsdPropertiesTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public void defaultValuesAreConsistent() {
3838
assertThat(properties.getPort()).isEqualTo(config.port());
3939
assertThat(properties.getMaxPacketLength()).isEqualTo(config.maxPacketLength());
4040
assertThat(properties.getPollingFrequency()).isEqualTo(config.pollingFrequency());
41-
assertThat(properties.getQueueSize()).isEqualTo(config.queueSize());
4241
assertThat(properties.isPublishUnchangedMeters())
4342
.isEqualTo(config.publishUnchangedMeters());
4443
}

0 commit comments

Comments
 (0)