Skip to content

Commit e37dbf8

Browse files
committed
Upgrade to Jetty 12.0.24
Closes gh-46741
1 parent ba9c909 commit e37dbf8

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/reactive/JettyReactiveWebServerFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import org.apache.commons.logging.LogFactory;
2323
import org.eclipse.jetty.ee10.servlet.ServletContextHandler;
2424
import org.eclipse.jetty.ee10.servlet.ServletHolder;
25-
import org.eclipse.jetty.server.ConnectionLimit;
25+
import org.eclipse.jetty.server.NetworkConnectionLimit;
2626
import org.eclipse.jetty.server.Server;
2727
import org.eclipse.jetty.server.handler.StatisticsHandler;
2828
import org.jspecify.annotations.Nullable;
@@ -109,7 +109,7 @@ protected Server createJettyServer(ServletHttpHandlerAdapter servlet) {
109109
server.setHandler(addHandlerWrappers(contextHandler));
110110
logger.info("Server initialized with port: " + port);
111111
if (this.getMaxConnections() > -1) {
112-
server.addBean(new ConnectionLimit(this.getMaxConnections(), server));
112+
server.addBean(new NetworkConnectionLimit(this.getMaxConnections(), server));
113113
}
114114
if (Ssl.isEnabled(getSsl())) {
115115
customizeSsl(server, address);

module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/servlet/JettyServletWebServerFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@
5252
import org.eclipse.jetty.http.MimeTypes;
5353
import org.eclipse.jetty.http.MimeTypes.Wrapper;
5454
import org.eclipse.jetty.http.SetCookieParser;
55-
import org.eclipse.jetty.server.ConnectionLimit;
5655
import org.eclipse.jetty.server.Connector;
5756
import org.eclipse.jetty.server.Handler;
5857
import org.eclipse.jetty.server.HttpCookieUtils;
58+
import org.eclipse.jetty.server.NetworkConnectionLimit;
5959
import org.eclipse.jetty.server.Request;
6060
import org.eclipse.jetty.server.Response;
6161
import org.eclipse.jetty.server.Server;
@@ -165,7 +165,7 @@ public WebServer getWebServer(ServletContextInitializer... initializers) {
165165
server.setHandler(addHandlerWrappers(context));
166166
logger.info("Server initialized with port: " + port);
167167
if (this.getMaxConnections() > -1) {
168-
server.addBean(new ConnectionLimit(this.getMaxConnections(), server.getConnectors()));
168+
server.addBean(new NetworkConnectionLimit(this.getMaxConnections(), server.getConnectors()));
169169
}
170170
if (Ssl.isEnabled(getSsl())) {
171171
customizeSsl(server, address);

module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/reactive/JettyReactiveWebServerFactoryTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import java.util.List;
2424

2525
import org.awaitility.Awaitility;
26-
import org.eclipse.jetty.server.ConnectionLimit;
2726
import org.eclipse.jetty.server.Connector;
27+
import org.eclipse.jetty.server.NetworkConnectionLimit;
2828
import org.eclipse.jetty.server.Server;
2929
import org.eclipse.jetty.server.ServerConnector;
3030
import org.junit.jupiter.api.Disabled;
@@ -148,9 +148,9 @@ void shouldApplyMaxConnections() {
148148
factory.setMaxConnections(1);
149149
this.webServer = factory.getWebServer(new EchoHandler());
150150
Server server = ((JettyWebServer) this.webServer).getServer();
151-
ConnectionLimit connectionLimit = server.getBean(ConnectionLimit.class);
151+
NetworkConnectionLimit connectionLimit = server.getBean(NetworkConnectionLimit.class);
152152
assertThat(connectionLimit).isNotNull();
153-
assertThat(connectionLimit.getMaxConnections()).isOne();
153+
assertThat(connectionLimit.getMaxNetworkConnectionCount()).isOne();
154154
}
155155

156156
@Test

module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/servlet/JettyServletWebServerFactoryTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@
4848
import org.eclipse.jetty.ee10.webapp.Configuration;
4949
import org.eclipse.jetty.ee10.webapp.WebAppContext;
5050
import org.eclipse.jetty.server.AbstractConnector;
51-
import org.eclipse.jetty.server.ConnectionLimit;
5251
import org.eclipse.jetty.server.Connector;
5352
import org.eclipse.jetty.server.Handler;
53+
import org.eclipse.jetty.server.NetworkConnectionLimit;
5454
import org.eclipse.jetty.server.Server;
5555
import org.eclipse.jetty.server.ServerConnector;
5656
import org.eclipse.jetty.server.SslConnectionFactory;
@@ -565,9 +565,9 @@ void shouldApplyMaxConnections() {
565565
factory.setMaxConnections(1);
566566
this.webServer = factory.getWebServer();
567567
Server server = ((JettyWebServer) this.webServer).getServer();
568-
ConnectionLimit connectionLimit = server.getBean(ConnectionLimit.class);
568+
NetworkConnectionLimit connectionLimit = server.getBean(NetworkConnectionLimit.class);
569569
assertThat(connectionLimit).isNotNull();
570-
assertThat(connectionLimit.getMaxConnections()).isOne();
570+
assertThat(connectionLimit.getMaxNetworkConnectionCount()).isOne();
571571
}
572572

573573
@Test
@@ -577,7 +577,7 @@ void shouldApplyMaxConnectionsToConnectors() {
577577
this.webServer = factory.getWebServer();
578578
Server server = ((JettyWebServer) this.webServer).getServer();
579579
assertThat(server.getConnectors()).isEmpty();
580-
ConnectionLimit connectionLimit = server.getBean(ConnectionLimit.class);
580+
NetworkConnectionLimit connectionLimit = server.getBean(NetworkConnectionLimit.class);
581581
assertThat(connectionLimit).extracting("_connectors")
582582
.asInstanceOf(InstanceOfAssertFactories.list(AbstractConnector.class))
583583
.hasSize(1);

platform/spring-boot-dependencies/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,7 @@ bom {
10091009
]
10101010
}
10111011
}
1012-
library("Jetty", "12.0.23") {
1012+
library("Jetty", "12.0.24") {
10131013
prohibit {
10141014
contains ".alpha"
10151015
because "we don't want alpha dependencies"

0 commit comments

Comments
 (0)