Skip to content

Commit e615eb3

Browse files
Mike Turbemhalbritter
authored andcommitted
Add support for virtual threads in OtlpMetricRegistry configuration
See gh-42407
1 parent eb7b6a7 commit e615eb3

File tree

3 files changed

+135
-1
lines changed

3 files changed

+135
-1
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/otlp/OtlpMetricsExportAutoConfiguration.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@
3030
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
3131
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
3232
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
33+
import org.springframework.boot.autoconfigure.condition.ConditionalOnThreading;
34+
import org.springframework.boot.autoconfigure.thread.Threading;
3335
import org.springframework.boot.context.properties.EnableConfigurationProperties;
3436
import org.springframework.context.annotation.Bean;
3537
import org.springframework.core.env.Environment;
38+
import org.springframework.core.task.VirtualThreadTaskExecutor;
3639

3740
/**
3841
* {@link EnableAutoConfiguration Auto-configuration} for exporting metrics to OTLP.
@@ -72,10 +75,19 @@ OtlpConfig otlpConfig(OpenTelemetryProperties openTelemetryProperties,
7275

7376
@Bean
7477
@ConditionalOnMissingBean
75-
public OtlpMeterRegistry otlpMeterRegistry(OtlpConfig otlpConfig, Clock clock) {
78+
@ConditionalOnThreading(Threading.PLATFORM)
79+
public OtlpMeterRegistry otlpMeterRegistryPlatformThreads(OtlpConfig otlpConfig, Clock clock) {
7680
return new OtlpMeterRegistry(otlpConfig, clock);
7781
}
7882

83+
@Bean
84+
@ConditionalOnMissingBean
85+
@ConditionalOnThreading(Threading.VIRTUAL)
86+
public OtlpMeterRegistry otlpMeterRegistryVirtualThreads(OtlpConfig otlpConfig, Clock clock) {
87+
VirtualThreadTaskExecutor taskExecutor = new VirtualThreadTaskExecutor("otlp-meter-registry");
88+
return new OtlpMeterRegistry(otlpConfig, clock, taskExecutor.getVirtualThreadFactory());
89+
}
90+
7991
/**
8092
* Adapts {@link OtlpProperties} to {@link OtlpMetricsConnectionDetails}.
8193
*/

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/otlp/OtlpMetricsExportAutoConfigurationTests.java

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,19 @@
1616

1717
package org.springframework.boot.actuate.autoconfigure.metrics.export.otlp;
1818

19+
import java.util.concurrent.ScheduledExecutorService;
20+
1921
import io.micrometer.core.instrument.Clock;
2022
import io.micrometer.registry.otlp.OtlpConfig;
2123
import io.micrometer.registry.otlp.OtlpMeterRegistry;
2224
import org.junit.jupiter.api.Test;
25+
import org.junit.jupiter.api.condition.EnabledForJreRange;
26+
import org.junit.jupiter.api.condition.JRE;
2327

2428
import org.springframework.boot.actuate.autoconfigure.metrics.export.otlp.OtlpMetricsExportAutoConfiguration.PropertiesOtlpMetricsConnectionDetails;
2529
import org.springframework.boot.autoconfigure.AutoConfigurations;
2630
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
31+
import org.springframework.boot.testsupport.assertj.ScheduledExecutorServiceAssert;
2732
import org.springframework.context.annotation.Bean;
2833
import org.springframework.context.annotation.Configuration;
2934
import org.springframework.context.annotation.Import;
@@ -76,6 +81,32 @@ void allowsCustomConfigToBeUsed() {
7681
.hasBean("customConfig"));
7782
}
7883

84+
@Test
85+
void allowsPlatformThreadsToBeUsed() {
86+
this.contextRunner.withUserConfiguration(BaseConfiguration.class).run((context) -> {
87+
assertThat(context).hasSingleBean(OtlpMeterRegistry.class);
88+
OtlpMeterRegistry registry = context.getBean(OtlpMeterRegistry.class);
89+
assertThat(registry).extracting("scheduledExecutorService")
90+
.satisfies((executor) -> ScheduledExecutorServiceAssert.assertThat((ScheduledExecutorService) executor)
91+
.usesPlatformThreads());
92+
});
93+
}
94+
95+
@Test
96+
@EnabledForJreRange(min = JRE.JAVA_21)
97+
void allowsVirtualThreadsToBeUsed() {
98+
this.contextRunner.withUserConfiguration(BaseConfiguration.class)
99+
.withPropertyValues("spring.threads.virtual.enabled=true")
100+
.run((context) -> {
101+
assertThat(context).hasSingleBean(OtlpMeterRegistry.class);
102+
OtlpMeterRegistry registry = context.getBean(OtlpMeterRegistry.class);
103+
assertThat(registry).extracting("scheduledExecutorService")
104+
.satisfies(
105+
(executor) -> ScheduledExecutorServiceAssert.assertThat((ScheduledExecutorService) executor)
106+
.usesVirtualThreads());
107+
});
108+
}
109+
79110
@Test
80111
void allowsRegistryToBeCustomized() {
81112
this.contextRunner.withUserConfiguration(CustomRegistryConfiguration.class)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
/*
2+
* Copyright 2012-2024 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.boot.testsupport.assertj;
18+
19+
import java.util.concurrent.ExecutionException;
20+
import java.util.concurrent.ScheduledExecutorService;
21+
import java.util.concurrent.ScheduledThreadPoolExecutor;
22+
import java.util.concurrent.TimeUnit;
23+
24+
import org.assertj.core.api.AbstractAssert;
25+
import org.assertj.core.api.Assert;
26+
27+
/**
28+
* AssertJ {@link Assert} for {@link ScheduledThreadPoolExecutor}.
29+
*
30+
* @author Mike Turbe
31+
* @author Moritz Halbritter
32+
*/
33+
public final class ScheduledExecutorServiceAssert
34+
extends AbstractAssert<ScheduledExecutorServiceAssert, ScheduledExecutorService> {
35+
36+
private ScheduledExecutorServiceAssert(ScheduledExecutorService actual) {
37+
super(actual, ScheduledExecutorServiceAssert.class);
38+
}
39+
40+
/**
41+
* Verifies that the actual executor uses platform threads.
42+
* @return {@code this} assertion object
43+
* @throws AssertionError if the actual executor doesn't use platform threads
44+
*/
45+
public ScheduledExecutorServiceAssert usesPlatformThreads() {
46+
isNotNull();
47+
if (producesVirtualThreads()) {
48+
failWithMessage("Expected executor to use platform threads, but it uses virtual threads");
49+
}
50+
return this;
51+
}
52+
53+
/**
54+
* Verifies that the actual executor uses virtual threads.
55+
* @return {@code this} assertion object
56+
* @throws AssertionError if the actual executor doesn't use virtual threads
57+
*/
58+
public ScheduledExecutorServiceAssert usesVirtualThreads() {
59+
isNotNull();
60+
if (!producesVirtualThreads()) {
61+
failWithMessage("Expected executor to use virtual threads, but it uses platform threads");
62+
}
63+
return this;
64+
}
65+
66+
private boolean producesVirtualThreads() {
67+
try {
68+
return this.actual.schedule(() -> {
69+
// https://openjdk.org/jeps/444
70+
// jep 444 specifies that virtual threads will belong to
71+
// a special thread group given the name "VirtualThreads"
72+
ThreadGroup threadGroup = Thread.currentThread().getThreadGroup();
73+
String threadGroupName = (threadGroup != null) ? threadGroup.getName() : "";
74+
return threadGroupName.equalsIgnoreCase("VirtualThreads");
75+
}, 0, TimeUnit.SECONDS).get();
76+
}
77+
catch (InterruptedException | ExecutionException ex) {
78+
throw new AssertionError(ex);
79+
}
80+
}
81+
82+
/**
83+
* Creates a new assertion class with the given {@link ScheduledExecutorService}.
84+
* @param actual the {@link ScheduledExecutorService}
85+
* @return the assertion class
86+
*/
87+
public static ScheduledExecutorServiceAssert assertThat(ScheduledExecutorService actual) {
88+
return new ScheduledExecutorServiceAssert(actual);
89+
}
90+
91+
}

0 commit comments

Comments
 (0)