Fix checkstyle violations in samples

Author: philwebb

spring-boot-parent/src/checkstyle/checkstyle-suppressions.xml

@@ -5,8 +5,7 @@
 <suppressions>
 	<suppress files="SpringApplicationTests\.java" checks="FinalClass" />
 	<suppress files=".+Configuration\.java" checks="HideUtilityClassConstructor" />
-	<suppress files="LaunchScriptTestApplication\.java" checks="HideUtilityClassConstructor" />
-	<suppress files="DevToolsTestApplication\.java" checks="HideUtilityClassConstructor" />
+	<suppress files=".+Application\.java" checks="HideUtilityClassConstructor" />
 	<suppress files="SignalUtils\.java" checks="IllegalImport" />
 	<suppress files="[\\/]src[\\/]test[\\/]java[\\/]cli[\\/]command[\\/]" checks="ImportControl" />
 	<suppress files="[\\/]src[\\/]main[\\/]java[\\/]sample[\\/]" checks="ImportControl" />
@@ -23,4 +22,8 @@
 	<suppress files="LogLevel\.java" checks="JavadocVariable" />
 	<suppress files="HelpMojo\.java" checks=".*"/>
 	<suppress files="[\\/]org.springframework.boot.configurationprocessor.json[\\/].*\.java$" checks=".*"/>
+	<suppress files="TripType\.java" checks="JavadocVariable" />
+	<suppress files="Rating\.java" checks="JavadocVariable" />
+	<suppress files="Direction\.java" checks="JavadocVariable" />
+	<suppress files="JooqExamples\.java" checks="AvoidStaticImport"/>
 </suppressions>

spring-boot-samples/spring-boot-sample-actuator-log4j2/src/main/resources/application.properties

@@ -1,3 +1,2 @@
 endpoints.shutdown.enabled=true
-
-management.security.enabled=false
+management.security.enabled=false

spring-boot-samples/spring-boot-sample-actuator-ui/src/main/resources/application.properties

@@ -1 +1 @@
-health.diskspace.enabled=false
+health.diskspace.enabled=false

spring-boot-samples/spring-boot-sample-actuator/src/test/resources/application-cors.properties

@@ -1,2 +1,2 @@
 endpoints.cors.allowed-origins=http://localhost:8080
-endpoints.cors.allowed-methods=GET
+endpoints.cors.allowed-methods=GET

spring-boot-samples/spring-boot-sample-actuator/src/test/resources/application-endpoints.properties

@@ -1,3 +1,3 @@
 server.error.path: /oops
 management.context-path: /admin
-endpoints.health.sensitive: false
+endpoints.health.sensitive: false

spring-boot-samples/spring-boot-sample-ant/src/test/java/sample/ant/SampleAntApplicationIT.java

@@ -16,17 +16,18 @@
 
 package sample.ant;
 
-import static org.assertj.core.api.Assertions.assertThat;
-
 import java.io.File;
 import java.io.FileFilter;
 import java.io.InputStreamReader;
 import java.util.concurrent.TimeUnit;
 
 import org.junit.Test;
+
 import org.springframework.boot.loader.tools.JavaExecutable;
 import org.springframework.util.FileCopyUtils;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 /**
  * Integration Tests for {@code SampleAntApplication}.
  *

spring-boot-samples/spring-boot-sample-ant/src/test/resources/application.properties

@@ -1 +1 @@
-name: Phil
+name: Phil

spring-boot-samples/spring-boot-sample-aop/src/main/resources/application.properties

@@ -1 +1 @@
-name: Phil
+name: Phil

spring-boot-samples/spring-boot-sample-atmosphere/src/main/java/sample/atmosphere/SampleAtmosphereApplication.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2016 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -59,6 +59,10 @@ public ServletRegistrationBean atmosphereServlet() {
 		return registration;
 	}
 
+	public static void main(String[] args) throws Exception {
+		SpringApplication.run(SampleAtmosphereApplication.class, args);
+	}
+
 	@Configuration
 	static class MvcConfiguration extends WebMvcConfigurerAdapter {
 
@@ -79,8 +83,4 @@ public void onStartup(ServletContext servletContext) throws ServletException {
 
 	}
 
-	public static void main(String[] args) throws Exception {
-		SpringApplication.run(SampleAtmosphereApplication.class, args);
-	}
-
 }

spring-boot-samples/spring-boot-sample-cache/src/main/java/sample/cache/SampleClient.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2016 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -53,7 +53,7 @@ class SampleClient {
 
 	private final Random random;
 
-	public SampleClient(CountryRepository countryService) {
+	SampleClient(CountryRepository countryService) {
 		this.countryService = countryService;
 		this.random = new Random();
 	}