Skip to content

Commit f8c3e0e

Browse files
committed
Respect custom username/password properties
Fix a bug in `DataSourceInitializationConfiguration` and in `R2dbcInitializationConfiguration` that was stopping custom username/password properties from being applied. Fixes gh-26676
1 parent d19b268 commit f8c3e0e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/sql/init/DataSourceInitializationConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ DataSourceScriptDatabaseInitializer dataSourceScriptDatabaseInitializer(DataSour
4444

4545
private static DataSource determineDataSource(DataSource dataSource, String username, String password) {
4646
if (StringUtils.hasText(username) && StringUtils.hasText(password)) {
47-
DataSourceBuilder.derivedFrom(dataSource).username(username).password(password)
47+
return DataSourceBuilder.derivedFrom(dataSource).username(username).password(password)
4848
.type(SimpleDriverDataSource.class).build();
4949
}
5050
return dataSource;

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/sql/init/R2dbcInitializationConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ R2dbcScriptDatabaseInitializer r2dbcScriptDatabaseInitializer(ConnectionFactory
5050
private static ConnectionFactory determineConnectionFactory(ConnectionFactory connectionFactory, String username,
5151
String password) {
5252
if (StringUtils.hasText(username) && StringUtils.hasText(password)) {
53-
ConnectionFactoryBuilder.derivefrom(connectionFactory).username(username).password(password).build();
53+
return ConnectionFactoryBuilder.derivefrom(connectionFactory).username(username).password(password).build();
5454
}
5555
return connectionFactory;
5656
}

0 commit comments

Comments
 (0)