Add rule to prevent calls to Objects.requireNonNull()

[wilkinsona]

From @mhalbritter in spring-io/spring-javaformat#339:

We should add a rule preventing calls to Objects.requireNonNull(), instead we should use Assert.notNull() from Spring Framework. Objects.requireNonNull() throws a NullPointerException, while Assert.notNull() throws a IllegalArgumentException.

Checkstyle can't do this accurately. We can do it in our own build instead using ArchUnit by adding a rule to the ArchitectureCheck task.

[ivamly]

Hello!

I’m relatively new to open source contributions, but I’m confident that I can handle this task. Could I get started on this?

Thank you!

[philwebb]

Thanks @ivamly, you might want to look at this code which is pretty similar to what we want to do.

[ivamly]

Hello!

Thanks for giving me the chance to tackle this task. I’m a bit confused about the code snippet you shared. I was initially thinking we’d be adding a rule directly in ArchitectureCheck.java.

@philwebb, could you clarify how the provided code fits into the task? Any guidance would be super helpful!

Thanks again for the support!

[wilkinsona]

@ivamly I suspect that was a stale clipboard entry and Phil meant to link to this code. It'd also be good to add a test to ArchitectureCheckTests too please.

[philwebb]

Yeah, sorry. Too many tabs open and I copied the wrong thing! I meant to link to

spring-boot/buildSrc/src/main/java/org/springframework/boot/build/architecture/ArchitectureCheck.java

Lines 198 to 203 in f1e98d0

	private ArchRule noClassesShouldCallCollectorsToList() {
	return ArchRuleDefinition.noClasses()
	.should()
	.callMethod(Collectors.class, "toList")
	.because("java.util.stream.Stream.toList() should be used instead");
	}

[ivamly]

Thanks for the clarification! I’ll check out the code and add the rule and tests.

[wilkinsona]

Closing in favor of #41611. Thanks for the PR, @ivamly!