ObservationAnnotationsEnabledCondition breaking change not mentioned in the release notes

[hetzijzo]

In Spring Boot 3.5.0 the ObservationAnnotationsEnabledCondition was removed. On the MetricsAspectsAutoConfiguration this annotation was removed and replaced by @ConditionalOnBooleanProperty("management.observations.annotations.enabled"). This is a breaking change since the earlier ObservationAnnotationsEnabledCondition also had the micrometer.observations.annotations.enabled as conditional property.

When I have micrometer.observations.annotations.enabled=true in my properties, the MetricsAspectsAutoConfiguration is no longer triggered. This is breaking change that needs to be mentioned in the release notes.

[bclozel]

Can you share a minimal sample application? I'm not sure I understand.
I couldn't reproduce the problem you are describing.

With the following properties:

spring.application.name=gh-45788
management.observations.annotations.enabled=true

and dependencies:

    implementation 'org.springframework.boot:spring-boot-starter-aop'
    implementation 'org.springframework.boot:spring-boot-starter-actuator'
    implementation 'org.springframework.boot:spring-boot-starter-web'

I'm getting this auto-configuration report for the auto-configuration class you are mentioning.

   MetricsAspectsAutoConfiguration matched:
      - @ConditionalOnClass found required classes 'io.micrometer.core.instrument.MeterRegistry', 'org.aspectj.weaver.Advice' (OnClassCondition)
      - @ConditionalOnBooleanProperty (management.observations.annotations.enabled=true) matched (OnPropertyCondition)
      - @ConditionalOnBean (types: io.micrometer.core.instrument.MeterRegistry; SearchStrategy: all) found bean 'simpleMeterRegistry' (OnBeanCondition)

   MetricsAspectsAutoConfiguration#countedAspect matched:
      - @ConditionalOnMissingBean (types: io.micrometer.core.aop.CountedAspect; SearchStrategy: all) did not find any beans (OnBeanCondition)

   MetricsAspectsAutoConfiguration#timedAspect matched:
      - @ConditionalOnMissingBean (types: io.micrometer.core.aop.TimedAspect; SearchStrategy: all) did not find any beans (OnBeanCondition)

Can you share your auto-configuration report as well?

[bclozel]

I just read again your report and I think I got it now.
You were relying on a long deprecated property, see #44320.

I'll add a note in the dedicated section in the wiki for 3.5.0 then.

[hetzijzo]

Good to know that is was deprecated. Thanks for linking it in the release notes.