Cache common PersistentProperty attributes.

We now use CachingCassandraPersistentProperty to pre-compute primary key and embedded flags to reduce computation load when using these properties.

Resolves #1082

Author: mp911de

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/mapping/BasicCassandraPersistentTupleProperty.java

@@ -15,6 +15,7 @@
  */
 package org.springframework.data.cassandra.core.mapping;
 
+import org.springframework.data.cassandra.core.cql.Ordering;
 import org.springframework.data.mapping.MappingException;
 import org.springframework.data.mapping.model.Property;
 import org.springframework.data.mapping.model.SimpleTypeHolder;
@@ -93,6 +94,15 @@ public Integer getOrdinal() {
 		return this.ordinal;
 	}
 
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#getPrimaryKeyOrdering()
+	 */
+	@Nullable
+	@Override
+	public Ordering getPrimaryKeyOrdering() {
+		return null;
+	}
+
 	/* (non-Javadoc)
 	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#isClusterKeyColumn()
 	 */
@@ -125,6 +135,14 @@ public boolean isPrimaryKeyColumn() {
 		return false;
 	}
 
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#isEmbedded()
+	 */
+	@Override
+	public boolean isEmbedded() {
+		return false;
+	}
+
 	/* (non-Javadoc)
 	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#setColumnName(org.springframework.data.cassandra.core.cql.CqlIdentifier)
 	 */

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/mapping/CachingCassandraPersistentProperty.java

@@ -0,0 +1,98 @@
+/*
+ * Copyright 2021 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.cassandra.core.mapping;
+
+import org.springframework.data.cassandra.core.cql.Ordering;
+import org.springframework.data.mapping.model.Property;
+import org.springframework.data.mapping.model.SimpleTypeHolder;
+import org.springframework.lang.Nullable;
+
+/**
+ * {@link BasicCassandraPersistentProperty} that pre-computes primary key and embedded flags.
+ *
+ * @author Mark Paluch
+ * @since 3.1.4
+ */
+public class CachingCassandraPersistentProperty extends BasicCassandraPersistentProperty {
+
+	private final @Nullable Ordering primaryKeyOrdering;
+	private final boolean isCompositePrimaryKey;
+	private final boolean isClusterKeyColumn;
+	private final boolean isPartitionKeyColumn;
+	private final boolean isPrimaryKeyColumn;
+	private final boolean isEmbedded;
+
+	public CachingCassandraPersistentProperty(Property property, CassandraPersistentEntity<?> owner,
+			SimpleTypeHolder simpleTypeHolder) {
+		super(property, owner, simpleTypeHolder);
+
+		primaryKeyOrdering = super.getPrimaryKeyOrdering();
+		isCompositePrimaryKey = super.isCompositePrimaryKey();
+		isClusterKeyColumn = super.isClusterKeyColumn();
+		isPartitionKeyColumn = super.isPartitionKeyColumn();
+		isPrimaryKeyColumn = super.isPrimaryKeyColumn();
+		isEmbedded = super.isEmbedded();
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#getPrimaryKeyOrdering()
+	 */
+	@Nullable
+	@Override
+	public Ordering getPrimaryKeyOrdering() {
+		return primaryKeyOrdering;
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#isCompositePrimaryKey()
+	 */
+	@Override
+	public boolean isCompositePrimaryKey() {
+		return isCompositePrimaryKey;
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#isClusterKeyColumn()
+	 */
+	@Override
+	public boolean isClusterKeyColumn() {
+		return isClusterKeyColumn;
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#isPartitionKeyColumn()
+	 */
+	@Override
+	public boolean isPartitionKeyColumn() {
+		return isPartitionKeyColumn;
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.CassandraPersistentProperty#isPrimaryKeyColumn()
+	 */
+	@Override
+	public boolean isPrimaryKeyColumn() {
+		return isPrimaryKeyColumn;
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.cassandra.core.mapping.BasicCassandraPersistentProperty#isEmbedded()
+	 */
+	@Override
+	public boolean isEmbedded() {
+		return isEmbedded;
+	}
+}

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/mapping/CassandraMappingContext.java

@@ -402,7 +402,7 @@ protected CassandraPersistentProperty createPersistentProperty(Property property
 
 		BasicCassandraPersistentProperty persistentProperty = owner.isTupleType()
 				? new BasicCassandraPersistentTupleProperty(property, owner, simpleTypeHolder)
-				: new BasicCassandraPersistentProperty(property, owner, simpleTypeHolder);
+				: new CachingCassandraPersistentProperty(property, owner, simpleTypeHolder);
 
 		persistentProperty.setNamingStrategy(this.namingStrategy);
 		Optional.ofNullable(this.applicationContext).ifPresent(persistentProperty::setApplicationContext);