Implement RepositoryFactorySupport.getEntityInformation(RepositoryMetadata) instead of private overload.

Overriding the proper variant of EntityInformation is now possible because we no longer utilize a private method in addition to the public one leading to partial customization of EntityInformation.

Closes #1576

Author: mp911de

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/repository/support/CassandraRepositoryFactory.java

@@ -84,18 +84,16 @@ protected Class<?> getRepositoryBaseClass(RepositoryMetadata metadata) {
 	@Override
 	protected Object getTargetRepository(RepositoryInformation information) {
 
-		CassandraEntityInformation<?, Object> entityInformation = getEntityInformation(information.getDomainType());
+		CassandraEntityInformation<?, ?> entityInformation = getEntityInformation(information);
 
 		return getTargetRepositoryViaReflection(information, entityInformation, operations);
 	}
 
 	@Override
-	@SuppressWarnings("unchecked")
-	public <T, ID> CassandraEntityInformation<T, ID> getEntityInformation(Class<T> domainClass) {
+	public CassandraEntityInformation<?, ?> getEntityInformation(RepositoryMetadata metadata) {
 
-		CassandraPersistentEntity<?> entity = mappingContext.getRequiredPersistentEntity(domainClass);
-
-		return new MappingCassandraEntityInformation<>((CassandraPersistentEntity<T>) entity, operations.getConverter());
+		CassandraPersistentEntity<?> entity = mappingContext.getRequiredPersistentEntity(metadata.getDomainType());
+		return new MappingCassandraEntityInformation<>(entity, operations.getConverter());
 	}
 
 	@Override

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/repository/support/ReactiveCassandraRepositoryFactory.java

@@ -81,7 +81,7 @@ protected Class<?> getRepositoryBaseClass(RepositoryMetadata metadata) {
 	@Override
 	protected Object getTargetRepository(RepositoryInformation information) {
 
-		CassandraEntityInformation<?, Object> entityInformation = getEntityInformation(information.getDomainType());
+		CassandraEntityInformation<?, ?> entityInformation = getEntityInformation(information);
 
 		return getTargetRepositoryViaReflection(information, entityInformation, operations);
 	}
@@ -93,12 +93,11 @@ protected Optional<QueryLookupStrategy> getQueryLookupStrategy(@Nullable Key key
 				new CachingValueExpressionDelegate(valueExpressionDelegate), mappingContext));
 	}
 
-	@SuppressWarnings("unchecked")
-	public <T, ID> CassandraEntityInformation<T, ID> getEntityInformation(Class<T> domainClass) {
-
-		CassandraPersistentEntity<?> entity = mappingContext.getRequiredPersistentEntity(domainClass);
+	@Override
+	public CassandraEntityInformation<?, ?> getEntityInformation(RepositoryMetadata metadata) {
 
-		return new MappingCassandraEntityInformation<>((CassandraPersistentEntity<T>) entity, operations.getConverter());
+		CassandraPersistentEntity<?> entity = mappingContext.getRequiredPersistentEntity(metadata.getDomainType());
+		return new MappingCassandraEntityInformation<>(entity, operations.getConverter());
 	}
 
 	/**

spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/support/CassandraRepositoryFactoryUnitTests.java

@@ -18,23 +18,23 @@
 import static org.assertj.core.api.Assertions.*;
 import static org.mockito.Mockito.*;
 
-import java.io.Serializable;
-
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.mockito.junit.jupiter.MockitoSettings;
 import org.mockito.quality.Strictness;
+
 import org.springframework.data.cassandra.core.CassandraTemplate;
 import org.springframework.data.cassandra.core.convert.CassandraConverter;
 import org.springframework.data.cassandra.core.mapping.BasicCassandraPersistentEntity;
 import org.springframework.data.cassandra.core.mapping.CassandraMappingContext;
 import org.springframework.data.cassandra.domain.Person;
-import org.springframework.data.cassandra.repository.query.CassandraEntityInformation;
 import org.springframework.data.projection.SpelAwareProxyProjectionFactory;
 import org.springframework.data.repository.Repository;
+import org.springframework.data.repository.core.EntityInformation;
+import org.springframework.data.repository.core.support.AbstractRepositoryMetadata;
 
 /**
  * Unit tests for {@link CassandraRepositoryFactory}.
@@ -66,8 +66,8 @@ void usesMappingCassandraEntityInformationIfMappingContextSet() {
 
 		CassandraRepositoryFactory repositoryFactory = new CassandraRepositoryFactory(template);
 
-		CassandraEntityInformation<Person, Serializable> entityInformation = repositoryFactory
-				.getEntityInformation(Person.class);
+		EntityInformation<?, ?> entityInformation = repositoryFactory
+				.getEntityInformation(AbstractRepositoryMetadata.getMetadata(MyPersonRepository.class));
 
 		assertThat(entityInformation).isInstanceOf(MappingCassandraEntityInformation.class);
 	}

spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/support/ReactiveCassandraRepositoryFactoryUnitTests.java

@@ -18,23 +18,23 @@
 import static org.assertj.core.api.Assertions.*;
 import static org.mockito.Mockito.*;
 
-import java.io.Serializable;
-
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.mockito.junit.jupiter.MockitoSettings;
 import org.mockito.quality.Strictness;
+
 import org.springframework.data.cassandra.core.ReactiveCassandraTemplate;
 import org.springframework.data.cassandra.core.convert.CassandraConverter;
 import org.springframework.data.cassandra.core.mapping.BasicCassandraPersistentEntity;
 import org.springframework.data.cassandra.core.mapping.CassandraMappingContext;
 import org.springframework.data.cassandra.domain.Person;
-import org.springframework.data.cassandra.repository.query.CassandraEntityInformation;
 import org.springframework.data.projection.SpelAwareProxyProjectionFactory;
 import org.springframework.data.repository.Repository;
+import org.springframework.data.repository.core.EntityInformation;
+import org.springframework.data.repository.core.support.AbstractRepositoryMetadata;
 
 /**
  * Unit tests for {@link ReactiveCassandraRepositoryFactory}.
@@ -66,8 +66,8 @@ void usesMappingCassandraEntityInformationIfMappingContextSet() {
 
 		ReactiveCassandraRepositoryFactory repositoryFactory = new ReactiveCassandraRepositoryFactory(template);
 
-		CassandraEntityInformation<Person, Serializable> entityInformation =
-				repositoryFactory.getEntityInformation(Person.class);
+		EntityInformation<?, ?> entityInformation = repositoryFactory
+				.getEntityInformation(AbstractRepositoryMetadata.getMetadata(MyPersonRepository.class));
 
 		assertThat(entityInformation).isInstanceOf(MappingCassandraEntityInformation.class);
 	}