Skip to content

Commit ee7def1

Browse files
committed
Polishing.
Use shorter field names. See #1449
1 parent 75cb544 commit ee7def1

File tree

3 files changed

+101
-100
lines changed

3 files changed

+101
-100
lines changed

spring-data-cassandra/src/test/java/org/springframework/data/cassandra/core/convert/MappingCassandraConverterMappedTupleUnitTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,31 +50,31 @@ class MappingCassandraConverterMappedTupleUnitTests {
5050

5151
private CassandraMappingContext mappingContext;
5252

53-
private MappingCassandraConverter mappingCassandraConverter;
53+
private MappingCassandraConverter converter;
5454

5555
private Row rowMock;
5656

5757
@BeforeEach
5858
void setUp() {
5959

6060
this.mappingContext = new CassandraMappingContext();
61-
this.mappingCassandraConverter = new MappingCassandraConverter(mappingContext);
62-
this.mappingCassandraConverter.afterPropertiesSet();
61+
this.converter = new MappingCassandraConverter(mappingContext);
62+
this.converter.afterPropertiesSet();
6363
}
6464

6565
@Test // DATACASS-523
6666
void shouldReadMappedTupleValue() {
6767

6868
BasicCassandraPersistentEntity<?> entity = this.mappingContext.getRequiredPersistentEntity(MappedTuple.class);
6969

70-
CassandraColumnType type = mappingCassandraConverter.getColumnTypeResolver().resolve(entity.getTypeInformation());
70+
CassandraColumnType type = converter.getColumnTypeResolver().resolve(entity.getTypeInformation());
7171

7272
TupleValue value = ((TupleType) type.getDataType()).newValue("hello", 1);
7373

7474
this.rowMock = RowMockUtil.newRowMock(column("name", "Jon Doe", DataTypes.TEXT),
7575
column("tuple", value, type.getDataType()));
7676

77-
Person person = this.mappingCassandraConverter.read(Person.class, rowMock);
77+
Person person = this.converter.read(Person.class, rowMock);
7878

7979
assertThat(person).isNotNull();
8080
assertThat(person.name()).isEqualTo("Jon Doe");
@@ -93,7 +93,7 @@ void shouldWriteMappedTuple() {
9393

9494
Map<CqlIdentifier, Object> insert = new LinkedHashMap<>();
9595

96-
this.mappingCassandraConverter.write(person, insert);
96+
this.converter.write(person, insert);
9797

9898
TupleValue tupleValue = (TupleValue) insert.get(CqlIdentifier.fromCql("tuple"));
9999
assertThat(tupleValue.getFormattedContents()).contains("('hello',1)");

spring-data-cassandra/src/test/java/org/springframework/data/cassandra/core/convert/MappingCassandraConverterUDTUnitTests.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
@MockitoSettings(strictness = Strictness.LENIENT)
6262
class MappingCassandraConverterUDTUnitTests {
6363

64-
@Mock UserTypeResolver userTypeResolver;
64+
@Mock UserTypeResolver typeResolver;
6565

6666
private com.datastax.oss.driver.api.core.type.UserDefinedType manufacturer = UserDefinedTypeBuilder
6767
.forName("manufacturer").withField("name", DataTypes.TEXT).withField("displayname", DataTypes.TEXT).build();
@@ -93,23 +93,23 @@ class MappingCassandraConverterUDTUnitTests {
9393
void setUp() {
9494

9595
mappingContext = new CassandraMappingContext();
96-
mappingContext.setUserTypeResolver(userTypeResolver);
96+
mappingContext.setUserTypeResolver(typeResolver);
9797

9898
CassandraCustomConversions cassandraCustomConversions = new CassandraCustomConversions(
99-
Arrays.asList(new UDTToCurrencyConverter(), new CurrencyToUDTConverter(userTypeResolver)));
99+
Arrays.asList(new UDTToCurrencyConverter(), new CurrencyToUDTConverter(typeResolver)));
100100
mappingContext.setSimpleTypeHolder(cassandraCustomConversions.getSimpleTypeHolder());
101101

102102
converter = new MappingCassandraConverter(mappingContext);
103103
converter.setCustomConversions(cassandraCustomConversions);
104104
converter.afterPropertiesSet();
105105

106-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("address"))).thenReturn(address);
107-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("engine"))).thenReturn(engine);
108-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("manufacturer"))).thenReturn(manufacturer);
109-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("currency"))).thenReturn(currency);
110-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("withnullableembeddedtype")))
106+
when(typeResolver.resolveType(CqlIdentifier.fromCql("address"))).thenReturn(address);
107+
when(typeResolver.resolveType(CqlIdentifier.fromCql("engine"))).thenReturn(engine);
108+
when(typeResolver.resolveType(CqlIdentifier.fromCql("manufacturer"))).thenReturn(manufacturer);
109+
when(typeResolver.resolveType(CqlIdentifier.fromCql("currency"))).thenReturn(currency);
110+
when(typeResolver.resolveType(CqlIdentifier.fromCql("withnullableembeddedtype")))
111111
.thenReturn(withnullableembeddedtype);
112-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("withprefixednullableembeddedtype")))
112+
when(typeResolver.resolveType(CqlIdentifier.fromCql("withprefixednullableembeddedtype")))
113113
.thenReturn(withprefixednullableembeddedtype);
114114
}
115115

@@ -476,7 +476,7 @@ void shouldWriteNestedUdt() {
476476
@Test // #1098
477477
void shouldWriteMapWithTypeHintToUdtValue() {
478478

479-
when(userTypeResolver.resolveType(CqlIdentifier.fromCql("udt"))).thenReturn(manufacturer);
479+
when(typeResolver.resolveType(CqlIdentifier.fromCql("udt"))).thenReturn(manufacturer);
480480

481481
MapWithUdt mapWithUdt = new MapWithUdt();
482482
mapWithUdt.map = Collections.singletonMap("key", new Manufacturer("name", "display"));

0 commit comments

Comments
 (0)