Add support for RepositoryFragmentsContributor#1574
Closed
onobc wants to merge 4 commits intospring-projects:5.0.xfrom
Closed
Add support for RepositoryFragmentsContributor#1574onobc wants to merge 4 commits intospring-projects:5.0.xfrom
RepositoryFragmentsContributor#1574onobc wants to merge 4 commits intospring-projects:5.0.xfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
May 8, 2025
...ringframework/data/cassandra/repository/support/CassandraRepositoryFragmentsContributor.java
Outdated
Show resolved
Hide resolved
This change adopts the newly added AOT changes from spring-projects/spring-data-commons#3282 to Cassandra repositories. - Introduces repository fragments contributor and updates the repository factories and factory beans w/ to use the default implementations. - Also makes the `CassandraRepositoryFactoryBean` consistent with its reactive counterpart by only setting the mapping context from the `CassandraOperations` in `afterPropertiesSet` iff the mapping context was not specified by the user. See: spring-projects#1566
mp911de
requested changes
May 9, 2025
Member
mp911de
left a comment
mp911de
left a comment
There was a problem hiding this comment.
Great start, left two comments about visibility.
...ringframework/data/cassandra/repository/support/CassandraRepositoryFragmentsContributor.java
Outdated
Show resolved
Hide resolved
...ework/data/cassandra/repository/support/ReactiveCassandraRepositoryFragmentsContributor.java
Outdated
Show resolved
Hide resolved
Moves default fragment contributors into their own file and sets their visiblity to package-protected.
onobc
commented
May 9, 2025
| * @author Chris Bono | ||
| * @since 5.0 | ||
| */ | ||
| enum DefaultCassandraRepositoryFragmentsContributor implements CassandraRepositoryFragmentsContributor { |
Contributor
Author
There was a problem hiding this comment.
Question on naming of "default impls".... what is our team standard on this? I have seen so far quite a bit of Foo -> FooSupport rather than Foo -> DefaultFoo. I am happy to rename.
Member
There was a problem hiding this comment.
Mostly, SimpleFoo or DefaultFoo. In JPA and MongoDB I went for QuerydslContributor because the name is already quite long. How about EmptyContributor for Cassandra?
Contributor
Author
There was a problem hiding this comment.
Yeh, I like EmptyContributor. I will adjust.
Shorten name of default fragment contributors to `EmptyFragmentsContributor` and `ReactiveEmptyFragmentsContributor`.
mp911de
added
type: enhancement
mp911de
changed the title
RepositoryFragmentsContributor
mp911de
pushed a commit
that referenced
this pull request
May 13, 2025
This change adopts the newly added AOT changes from spring-projects/spring-data-commons#3282 to Cassandra repositories. - Introduces repository fragments contributor and updates the repository factories and factory beans w/ to use the default implementations. - Also makes the `CassandraRepositoryFactoryBean` consistent with its reactive counterpart by only setting the mapping context from the `CassandraOperations` in `afterPropertiesSet` iff the mapping context was not specified by the user. Closes #1574
mp911de
added a commit
that referenced
this pull request
May 13, 2025
Adopt to deprecations in Commons. See #1574
Member
|
Thank you for your contribution. That's merged and polished now. |
mp911de
pushed a commit
that referenced
this pull request
May 16, 2025
This change adopts the newly added AOT changes from spring-projects/spring-data-commons#3282 to Cassandra repositories. - Introduces repository fragments contributor and updates the repository factories and factory beans w/ to use the default implementations. - Also makes the `CassandraRepositoryFactoryBean` consistent with its reactive counterpart by only setting the mapping context from the `CassandraOperations` in `afterPropertiesSet` iff the mapping context was not specified by the user. Closes #1574
mp911de
added a commit
that referenced
this pull request
May 16, 2025
Adopt to deprecations in Commons. See #1574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code proposal adopts the newly added AOT changes (spring-data-commons/3282) to Cassandra repositories.
Note
While the AOT repositories support has not been added yet, I think it still makes sense to add these changes in as they will be required by AOT and this is a small enough change to focus on in a single PR.
Introduces repository fragments contributor and updates the repository factories and factory beans w/ to use the default implementations.
Also makes the
CassandraRepositoryFactoryBeanconsistent with its reactive counterpart by only setting the mapping context from theCassandraOperationsinafterPropertiesSetiff the mapping context was not specified by the user.See: #1566