DATACMNS-300 - Fixed exception handling in ReflectionEntityInstantiator.

ReflectionEntityInstantiator now actually throws the wrapped exception created in the catch block handling BeanInstantiationExceptions.

Pull request: #25.

Author: Johannes Mockenhaupt

src/main/java/org/springframework/data/convert/ReflectionEntityInstantiator.java

@@ -61,7 +61,7 @@ public <T, E extends PersistentEntity<? extends T, P>, P extends PersistentPrope
 					return BeanUtils.instantiateClass(entity.getType());
 				}
 			} catch (BeanInstantiationException e) {
-				new MappingInstantiationException(entity, Collections.emptyList(), e);
+				throw new MappingInstantiationException(entity, Collections.emptyList(), e);
 			}
 		}
 

src/test/java/org/springframework/data/convert/ReflectionEntityInstantiatorUnitTests.java

@@ -47,6 +47,7 @@
  * Unit tests for {@link ReflectionEntityInstantiator}.
  * 
  * @author Oliver Gierke
+ * @author Johannes Mockenhaupt
  */
 @RunWith(MockitoJUnitRunner.class)
 public class ReflectionEntityInstantiatorUnitTests<P extends PersistentProperty<P>> {
@@ -91,6 +92,19 @@ public void instantiatesTypeWithPreferredConstructorUsingParameterValueProvider(
 		verify(provider, times(1)).getParameterValue((Parameter) constructor.getParameters().iterator().next());
 	}
 
+	/**
+	 * @see DATACMNS-300
+	 */
+	@Test(expected = MappingInstantiationException.class)
+	@SuppressWarnings({ "unchecked", "rawtypes" })
+	public void throwsExceptionOnBeanInstantiationException() {
+
+		when(entity.getPersistenceConstructor()).thenReturn(null);
+		when(entity.getType()).thenReturn((Class) PersistentEntity.class);
+
+		INSTANCE.createInstance(entity, provider);
+	}
+
 	/**
 	 * @see DATACMNS-134
 	 */
@@ -134,8 +148,10 @@ public void capturesContextOnInstantiationException() throws Exception {
 		List<Object> parameters = Arrays.asList((Object) "FOO", (Object) "FOO");
 
 		try {
+
 			INSTANCE.createInstance(entity, provider);
 			fail("Expected MappingInstantiationException!");
+
 		} catch (MappingInstantiationException o_O) {
 
 			assertThat(o_O.getConstructor(), is(constructor));
@@ -146,7 +162,6 @@ public void capturesContextOnInstantiationException() throws Exception {
 			assertThat(o_O.getMessage(), containsString(Long.class.getName()));
 			assertThat(o_O.getMessage(), containsString(String.class.getName()));
 			assertThat(o_O.getMessage(), containsString("FOO"));
-			System.out.println(o_O.getMessage());
 		}
 	}