refactor: extract magic number 0L to constant for new entity check

Author: currenjin

src/main/java/org/springframework/data/repository/core/support/AbstractEntityInformation.java

@@ -30,6 +30,7 @@
  */
 public abstract class AbstractEntityInformation<T, ID> implements EntityInformation<T, ID> {
 
+	public static final long NEW_ID = 0L;
 	private final Class<T> domainClass;
 
 	public AbstractEntityInformation(Class<T> domainClass) {
@@ -50,7 +51,7 @@ public boolean isNew(T entity) {
 		}
 
 		if (id instanceof Number n) {
-			return n.longValue() == 0L;
+			return n.longValue() == NEW_ID;
 		}
 
 		throw new IllegalArgumentException(String.format("Unsupported primitive id type %s", idType));

src/test/java/org/springframework/data/repository/core/support/AbstractEntityInformationUnitTests.java

@@ -49,7 +49,7 @@ void considersEntityNewIfGetIdReturnsNull() throws Exception {
 	}
 
 	@Test // DATACMNS-357
-	void detectsNewStateForPrimitiveIds() {
+	void detectsNewStateForZeroIds() {
 
 		var fooEn = new CustomEntityInformation<PrimitiveIdEntity, Serializable>(
 				PrimitiveIdEntity.class);
@@ -61,6 +61,16 @@ void detectsNewStateForPrimitiveIds() {
 		assertThat(fooEn.isNew(entity)).isFalse();
 	}
 
+	@Test // DATACMNS-357
+	void detectsNewStateForPrimitiveIds() {
+
+		var fooEn = new CustomEntityInformation<PrimitiveWithIdEntity, Serializable>(
+				PrimitiveWithIdEntity.class);
+
+		var entity = new PrimitiveWithIdEntity(0L);
+		assertThat(fooEn.isNew(entity)).isTrue();
+	}
+
 	@Test // DATACMNS-357
 	void detectsNewStateForPrimitiveWrapperIds() {
 
@@ -85,6 +95,16 @@ void rejectsUnsupportedPrimitiveIdType() {
 				.withMessageContaining(boolean.class.getName());
 	}
 
+	static class PrimitiveWithIdEntity {
+
+		@Id long id;
+
+
+		public PrimitiveWithIdEntity(long id) {
+			this.id = id;
+		}
+	}
+
 	static class PrimitiveIdEntity {
 
 		@Id long id;