Avoid reversing List collected by Collector.toList() to ensure safety

>> There are no guarantees on the type, mutability, serializability, or thread-safety of the List returned

`Collector.toList()` doesn't guarantee mutability, then passing it to `Collections.reverse()` is not safe.

Signed-off-by: Yanming Zhou <[email protected]>

Author: quaff

src/main/java/org/springframework/data/convert/CustomConversions.java

@@ -120,15 +120,13 @@ public CustomConversions(ConverterConfiguration converterConfiguration) {
 
 		this.converterConfiguration = converterConfiguration;
 
-		List<Object> registeredConverters = collectPotentialConverterRegistrations(
+		this.converters = collectPotentialConverterRegistrations(
 				converterConfiguration.getStoreConversions(), converterConfiguration.getUserConverters()).stream()
 				.filter(this::isSupportedConverter).filter(this::shouldRegister)
 				.map(ConverterRegistrationIntent::getConverterRegistration).map(this::register).distinct()
-				.collect(Collectors.toList());
+				.sorted(Collections.reverseOrder())
+				.toList();
 
-		Collections.reverse(registeredConverters);
-
-		this.converters = Collections.unmodifiableList(registeredConverters);
 		this.simpleTypeHolder = new SimpleTypeHolder(customSimpleTypes,
 				converterConfiguration.getStoreConversions().getStoreTypeHolder());
 		this.propertyValueConversions = converterConfiguration.getPropertyValueConversions();

src/main/java/org/springframework/data/spel/ExtensionAwareEvaluationContextProvider.java

@@ -183,13 +183,14 @@ EvaluationContextExtensionInformation getOrCreateInformation(Class<? extends Eva
 	 * @param extensions
 	 * @return
 	 */
-	private List<EvaluationContextExtensionAdapter> toAdapters(
+	private List<EvaluationContextExtensionAdapter> toReversedAdapters(
 			Collection<? extends EvaluationContextExtension> extensions) {
 
-		return extensions.stream()//
-				.sorted(AnnotationAwareOrderComparator.INSTANCE)//
+		return extensions.stream() //
+				.sorted(AnnotationAwareOrderComparator.INSTANCE) //
 				.map(it -> new EvaluationContextExtensionAdapter(it, getOrCreateInformation(it))) //
-				.collect(Collectors.toList());
+				.sorted(Collections.reverseOrder()) //
+				.toList();
 	}
 
 	/**
@@ -211,11 +212,9 @@ public ExtensionAwarePropertyAccessor(Collection<? extends EvaluationContextExte
 
 			Assert.notNull(extensions, "Extensions must not be null");
 
-			this.adapters = toAdapters(extensions);
+			this.adapters = toReversedAdapters(extensions);
 			this.adapterMap = adapters.stream()//
 					.collect(Collectors.toMap(EvaluationContextExtensionAdapter::getExtensionId, it -> it));
-
-			Collections.reverse(this.adapters);
 		}
 
 		@Override