Polishing.

Add missing Override annotations. Eagerly compute input properties.

See #3163

Author: mp911de

src/main/java/org/springframework/data/projection/DefaultProjectionInformation.java

@@ -29,6 +29,7 @@
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import org.springframework.beans.BeanUtils;
 import org.springframework.core.log.LogMessage;
 import org.springframework.core.type.AnnotationMetadata;
@@ -53,6 +54,7 @@ class DefaultProjectionInformation implements ProjectionInformation {
 
 	private final Class<?> projectionType;
 	private final List<PropertyDescriptor> properties;
+	private final List<PropertyDescriptor> inputProperties;
 
 	/**
 	 * Creates a new {@link DefaultProjectionInformation} for the given type.
@@ -65,19 +67,20 @@ class DefaultProjectionInformation implements ProjectionInformation {
 
 		this.projectionType = type;
 		this.properties = new PropertyDescriptorSource(type).getDescriptors();
+		this.inputProperties = properties.stream()//
+				.filter(this::isInputProperty)//
+				.distinct()//
+				.toList();
 	}
 
 	@Override
 	public Class<?> getType() {
 		return projectionType;
 	}
 
+	@Override
 	public List<PropertyDescriptor> getInputProperties() {
-
-		return properties.stream()//
-				.filter(this::isInputProperty)//
-				.distinct()//
-				.collect(Collectors.toList());
+		return inputProperties;
 	}
 
 	@Override

src/main/java/org/springframework/data/repository/query/ReturnedType.java

@@ -155,6 +155,7 @@ private static final class ReturnedInterface extends ReturnedType {
 
 		private final ProjectionInformation information;
 		private final Class<?> domainType;
+		private final List<String> inputProperties;
 
 		/**
 		 * Creates a new {@link ReturnedInterface} from the given {@link ProjectionInformation} and domain type.
@@ -170,13 +171,28 @@ public ReturnedInterface(ProjectionInformation information, Class<?> domainType)
 
 			this.information = information;
 			this.domainType = domainType;
+			this.inputProperties = detectInputProperties(information);
+		}
+
+		private static List<String> detectInputProperties(ProjectionInformation information) {
+
+			List<String> properties = new ArrayList<>();
+
+			for (PropertyDescriptor descriptor : information.getInputProperties()) {
+				if (!properties.contains(descriptor.getName())) {
+					properties.add(descriptor.getName());
+				}
+			}
+
+			return Collections.unmodifiableList(properties);
 		}
 
 		@Override
 		public Class<?> getReturnedType() {
 			return information.getType();
 		}
 
+		@Override
 		public boolean needsCustomConstruction() {
 			return isProjecting() && information.isClosed();
 		}
@@ -194,16 +210,7 @@ public Class<?> getTypeToRead() {
 
 		@Override
 		public List<String> getInputProperties() {
-
-			List<String> properties = new ArrayList<>();
-
-			for (PropertyDescriptor descriptor : information.getInputProperties()) {
-				if (!properties.contains(descriptor.getName())) {
-					properties.add(descriptor.getName());
-				}
-			}
-
-			return properties;
+			return inputProperties;
 		}
 	}
 
@@ -243,6 +250,7 @@ public Class<?> getReturnedType() {
 			return type;
 		}
 
+		@Override
 		@NonNull
 		public Class<?> getTypeToRead() {
 			return type;
@@ -253,6 +261,7 @@ public boolean isProjecting() {
 			return isDto();
 		}
 
+		@Override
 		public boolean needsCustomConstruction() {
 			return isDto() && !inputProperties.isEmpty();
 		}
@@ -280,7 +289,7 @@ private List<String> detectConstructorParameterNames(Class<?> type) {
 				properties.add(parameter.getName());
 			}
 
-			return properties;
+			return Collections.unmodifiableList(properties);
 		}
 
 		private boolean isDto() {