Extend query method special parameter types to any subclasses.

Spring Data Commons has a hard-coded list of special types than can be included in query methods including Pageable and Sort.

A custom finder with PageRequest, even though it extends Pageable, will fail when it would work fine with a narrowed input. This extends the list using an assignability check.

Related: spring-projects/spring-data-jpa#2013
See #2626.

Author: gregturn

src/main/java/org/springframework/data/repository/query/Parameter.java

@@ -42,6 +42,7 @@
  * @author Oliver Gierke
  * @author Mark Paluch
  * @author Jens Schauder
+ * @author Greg Turnquist
  */
 public class Parameter {
 
@@ -79,7 +80,7 @@ protected Parameter(MethodParameter parameter) {
 		this.parameter = parameter;
 		this.parameterType = potentiallyUnwrapParameterType(parameter);
 		this.isDynamicProjectionParameter = isDynamicProjectionParameter(parameter);
-		this.name = TYPES.contains(parameter.getParameterType()) ? Lazy.of(Optional.empty()) : Lazy.of(() -> {
+		this.name = isSpecialParameterType(parameter.getParameterType()) ? Lazy.of(Optional.empty()) : Lazy.of(() -> {
 			Param annotation = parameter.getParameterAnnotation(Param.class);
 			return Optional.ofNullable(annotation == null ? parameter.getParameterName() : annotation.value());
 		});
@@ -92,7 +93,7 @@ protected Parameter(MethodParameter parameter) {
 	 * @see #TYPES
 	 */
 	public boolean isSpecialParameter() {
-		return isDynamicProjectionParameter || TYPES.contains(parameter.getParameterType());
+		return isDynamicProjectionParameter || isSpecialParameterType(parameter.getParameterType());
 	}
 
 	/**
@@ -269,4 +270,22 @@ private static Class<?> potentiallyUnwrapParameterType(MethodParameter parameter
 
 		return originalType;
 	}
+
+	/**
+	 * Identify is a given {@link Class} is either part of {@code TYPES} or an instanceof of one of its members. For
+	 * example, {@code PageRequest} is an instance of {@code Pageable} (a member of {@code TYPES}).
+	 *
+	 * @param parameterType must not be {@literal null}.
+	 * @return boolean
+	 */
+	private static boolean isSpecialParameterType(Class<?> parameterType) {
+
+		for (Class<?> specialParameterType : TYPES) {
+			if (specialParameterType.isAssignableFrom(parameterType)) {
+				return true;
+			}
+		}
+
+		return false;
+	}
 }

src/test/java/org/springframework/data/repository/query/ParametersParameterAccessorUnitTests.java

@@ -19,14 +19,14 @@
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-
 import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Pageable;
 
 /**
  * Unit tests for {@link ParametersParameterAccessor}.
  *
  * @author Oliver Gierke
+ * @author Greg Turnquist
  */
 class ParametersParameterAccessorUnitTests {
 
@@ -69,16 +69,30 @@ void iteratesonlyOverBindableValues() throws Exception {
 		var method = Sample.class.getMethod("method", Pageable.class, String.class);
 		var parameters = new DefaultParameters(method);
 
-		var accessor = new ParametersParameterAccessor(parameters,
-				new Object[] { PageRequest.of(0, 10), "Foo" });
+		var accessor = new ParametersParameterAccessor(parameters, new Object[] { PageRequest.of(0, 10), "Foo" });
 
 		assertThat(accessor).hasSize(1);
+		assertThat(accessor.getBindableValue(0)).isEqualTo("Foo");
+	}
+
+	@Test // #2626
+	void handlesPageRequestAsAParameterType() throws NoSuchMethodException {
+
+		var method = Sample.class.getMethod("methodWithPageRequest", PageRequest.class, String.class);
+		var parameters = new DefaultParameters(method);
+
+		var accessor = new ParametersParameterAccessor(parameters, new Object[] { PageRequest.of(0, 10), "Foo" });
+
+		assertThat(accessor).hasSize(1);
+		assertThat(accessor.getBindableValue(0)).isEqualTo("Foo");
 	}
 
 	interface Sample {
 
 		void method(String string, int integer);
 
 		void method(Pageable pageable, String string);
+
+		void methodWithPageRequest(PageRequest pageRequest, String string);
 	}
 }