Polishing.

Add missing Override annotations. Use instanceof pattern variables, use diamond operator where possible.

Closes #3162

Author: ngocnhan-tran1996

src/main/java/org/springframework/data/aot/DefaultAotContext.java

@@ -39,7 +39,7 @@ class DefaultAotContext implements AotContext {
 	private final ConfigurableListableBeanFactory factory;
 
 	public DefaultAotContext(BeanFactory beanFactory) {
-		factory = beanFactory instanceof ConfigurableListableBeanFactory ? (ConfigurableListableBeanFactory) beanFactory
+		factory = beanFactory instanceof ConfigurableListableBeanFactory cbf ? cbf
 				: new DefaultListableBeanFactory(beanFactory);
 	}
 

src/main/java/org/springframework/data/convert/ConfigurableTypeInformationMapper.java

@@ -66,6 +66,7 @@ public ConfigurableTypeInformationMapper(Map<? extends Class<?>, String> sourceT
 		}
 	}
 
+	@Override
 	public Alias createAliasFor(TypeInformation<?> type) {
 		return typeToAlias.getOrDefault(type, Alias.NONE);
 	}

src/main/java/org/springframework/data/convert/MappingContextTypeInformationMapper.java

@@ -58,6 +58,7 @@ public MappingContextTypeInformationMapper(MappingContext<? extends PersistentEn
 		}
 	}
 
+	@Override
 	public Alias createAliasFor(TypeInformation<?> type) {
 
 		return typeMap.computeIfAbsent(type.getRawTypeInformation(), key -> {

src/main/java/org/springframework/data/convert/SimplePropertyValueConverterRegistry.java

@@ -81,6 +81,7 @@ public int size() {
 		return converterRegistrationMap.size();
 	}
 
+	@Override
 	public boolean isEmpty() {
 		return converterRegistrationMap.isEmpty();
 	}

src/main/java/org/springframework/data/crossstore/HashMapChangeSet.java

@@ -41,6 +41,7 @@ public HashMapChangeSet() {
 		this(new HashMap<>());
 	}
 
+	@Override
 	public void set(String key, Object o) {
 		values.put(key, o);
 	}
@@ -49,15 +50,18 @@ public String toString() {
 		return "HashMapChangeSet: values=[" + values + "]";
 	}
 
+	@Override
 	public Map<String, Object> getValues() {
 		return Collections.unmodifiableMap(values);
 	}
 
+	@Override
 	@Nullable
 	public Object removeProperty(String k) {
 		return this.values.remove(k);
 	}
 
+	@Override
 	@Nullable
 	public <T> T get(String key, Class<T> requiredClass, ConversionService conversionService) {
 

src/main/java/org/springframework/data/domain/Chunk.java

@@ -54,42 +54,52 @@ public Chunk(List<T> content, Pageable pageable) {
 		this.pageable = pageable;
 	}
 
+	@Override
 	public int getNumber() {
 		return pageable.isPaged() ? pageable.getPageNumber() : 0;
 	}
 
+	@Override
 	public int getSize() {
 		return pageable.isPaged() ? pageable.getPageSize() : content.size();
 	}
 
+	@Override
 	public int getNumberOfElements() {
 		return content.size();
 	}
 
+	@Override
 	public boolean hasPrevious() {
 		return getNumber() > 0;
 	}
 
+	@Override
 	public boolean isFirst() {
 		return !hasPrevious();
 	}
 
+	@Override
 	public boolean isLast() {
 		return !hasNext();
 	}
 
+	@Override
 	public Pageable nextPageable() {
 		return hasNext() ? pageable.next() : Pageable.unpaged();
 	}
 
+	@Override
 	public Pageable previousPageable() {
 		return hasPrevious() ? pageable.previousOrFirst() : Pageable.unpaged();
 	}
 
+	@Override
 	public boolean hasContent() {
 		return !content.isEmpty();
 	}
 
+	@Override
 	public List<T> getContent() {
 		return Collections.unmodifiableList(content);
 	}

src/main/java/org/springframework/data/domain/Page.java

@@ -69,5 +69,6 @@ static <T> Page<T> empty(Pageable pageable) {
 	 * @return a new {@link Page} with the content of the current one mapped by the given {@link Function}.
 	 * @since 1.10
 	 */
+	@Override
 	<U> Page<U> map(Function<? super T, ? extends U> converter);
 }

src/main/java/org/springframework/data/domain/PageRequest.java

@@ -97,6 +97,7 @@ public static PageRequest ofSize(int pageSize) {
 		return PageRequest.of(0, pageSize);
 	}
 
+	@Override
 	public Sort getSort() {
 		return sort;
 	}

src/main/java/org/springframework/data/domain/Slice.java

@@ -136,6 +136,7 @@ default Pageable getPageable() {
 	 * @return a new {@link Slice} with the content of the current one mapped by the given {@link Converter}.
 	 * @since 1.10
 	 */
+	@Override
 	<U> Slice<U> map(Function<? super T, ? extends U> converter);
 
 	/**

src/main/java/org/springframework/data/domain/SliceImpl.java

@@ -15,6 +15,7 @@
  */
 package org.springframework.data.domain;
 
+import java.io.Serial;
 import java.util.List;
 import java.util.function.Function;
 
@@ -29,6 +30,7 @@
  */
 public class SliceImpl<T> extends Chunk<T> {
 
+	@Serial
 	private static final long serialVersionUID = 867755909294344406L;
 
 	private final boolean hasNext;
@@ -59,6 +61,7 @@ public SliceImpl(List<T> content) {
 		this(content, Pageable.unpaged(), false);
 	}
 
+	@Override
 	public boolean hasNext() {
 		return hasNext;
 	}
@@ -74,7 +77,7 @@ public String toString() {
 		String contentType = "UNKNOWN";
 		List<T> content = getContent();
 
-		if (content.size() > 0) {
+		if (!content.isEmpty()) {
 			contentType = content.get(0).getClass().getName();
 		}