Throw exception if Kotlin projection requires non-null value but null result present #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… result present Fix spring-projectsGH-3242 Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
quaff
commented
Feb 14, 2025
| KFunction<?> function = KotlinDetector.isKotlinType(method.getDeclaringClass()) ? | ||
| KotlinReflectionUtils.findKotlinFunction(method) : null; | ||
| if (function != null && !function.getReturnType().isMarkedNullable()) { | ||
| throw new IllegalArgumentException("Kotlin function '%s' requires non-null return value".formatted(method.toString())); |
There was a problem hiding this comment.
Not sure exception type and message is appropriate.
christophstrobl
pushed a commit
that referenced
this pull request
Mar 6, 2025
… result present Closes: #3242 Original Pull Request: #3244 Signed-off-by: Yanming Zhou <[email protected]>
christophstrobl
added a commit
that referenced
this pull request
Mar 6, 2025
Original Pull Request: #3244
christophstrobl
pushed a commit
that referenced
this pull request
Mar 6, 2025
Align nullness/nullability wording. Use template methods instead of functions to create exceptions. Original Pull Request: #3244
|
Thank you @quaff! Merged to main development line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-3242