Skip to content

Allow overriding DateTimeProvider via Bean Definition #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow overriding DateTimeProvider via Bean Definition #3385

wants to merge 1 commit into from

Conversation

@ghgh415263
Copy link
Contributor

use autowired properties for AuditorAware and DateTimeProvider when explicit references are not provided

See: #3177

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 21, 2025
@mp911de
Copy link
Member

mp911de commented Oct 22, 2025

We could certainly enable autowiring for dateTimeProvider, however, this PR is incomplete as it is missing tests and it breaks applications that do not declare an AuditorAware bean.

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Oct 22, 2025
@ghgh415263
Copy link
Contributor Author

ghgh415263 commented Oct 22, 2025 •
edited
Loading

Thank you for the feedback.

  1. unit tests are required for AuditingBeanDefinitionRegistrarSupport.java
  2. application( with @EnableJpaAudting) can start even if no AuditorAware bean is defined.

new PR covers the second requirement. I will add the unit tests soon.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Oct 22, 2025
@ghgh415263
Copy link
Contributor Author

ghgh415263 commented Oct 23, 2025 •
edited
Loading

@mp911de I added unit tests.
I would appreciate any feedback if you notice any issues.

@ghgh415263
Allow overriding DateTimeProvider via Bean Definition
b54ef9a 
use autowired properties for AuditorAware and DateTimeProvider when explicit references are not provided

See: spring-projects#3177

Signed-off-by: JaeYeon Kim <[email protected]>
@mp911de mp911de self-assigned this Oct 27, 2025
mp911de pushed a commit that referenced this pull request Oct 28, 2025
@ghgh415263 @mp911de
Allow autowiring of DateTimeProvider for AuditingHandler.
038eae6 
Use autowired properties for AuditorAware and DateTimeProvider when explicit references are not provided

Closes: #3177
Original pull request: #3385

Signed-off-by: JaeYeon Kim <[email protected]>
mp911de added a commit that referenced this pull request Oct 28, 2025
@mp911de
Polishing.
f9e097e 
Add autowriting support to auditing handler properties.

See: #3177
Original pull request: #3385
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Oct 28, 2025
@mp911de mp911de added this to the 4.0 RC2 (2025.1.0) milestone Oct 28, 2025
@mp911de
Copy link
Member

mp911de commented Oct 28, 2025

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Oct 28, 2025
@mp911de mp911de linked an issue Oct 28, 2025 that may be closed by this pull request
Allow overriding DateTimeProvider via Bean Definition #3177
Closed
mp911de added a commit that referenced this pull request Oct 28, 2025
@mp911de
Polishing.
6c3e1ac 
Add autowriting support to auditing handler properties.

See: #3177
Original pull request: #3385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

4.0 RC2 (2025.1.0)

Development

Successfully merging this pull request may close these issues.

Allow overriding DateTimeProvider via Bean Definition

3 participants

@ghgh415263 @mp911de @spring-projects-issues