Skip to content

Commit 0ce2c49

Browse files
authored
Original PR: #537
1 parent e13c948 commit 0ce2c49

File tree

3 files changed

+0
-31
lines changed

3 files changed

+0
-31
lines changed

src/main/java/org/springframework/data/elasticsearch/repository/ElasticsearchRepository.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,6 @@ default <S extends T> S index(S entity) {
7575
*/
7676
Page<T> search(Query searchQuery);
7777

78-
/**
79-
* execute the given query and return the result in a SearchPage.
80-
*
81-
* @since 4.1
82-
*/
83-
SearchPage<T> searchQuery(Query query);
84-
8578
/**
8679
* Search for similar entities using a morelikethis query
8780
*

src/main/java/org/springframework/data/elasticsearch/repository/support/SimpleElasticsearchRepository.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -253,12 +253,6 @@ public Page<T> search(Query query) {
253253
return (Page<T>) SearchHitSupport.unwrapSearchHits(page);
254254
}
255255

256-
@Override
257-
public SearchPage<T> searchQuery(Query query) {
258-
SearchHits<T> searchHits = execute(operations -> operations.search(query, entityClass, getIndexCoordinates()));
259-
return SearchHitSupport.searchPageFor(searchHits, query.getPageable());
260-
}
261-
262256
@SuppressWarnings("unchecked")
263257
@Override
264258
public Page<T> searchSimilar(T entity, @Nullable String[] fields, Pageable pageable) {

src/test/java/org/springframework/data/elasticsearch/repository/support/simple/SimpleElasticsearchRepositoryIntegrationTests.java

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -718,24 +718,6 @@ void shouldNotReturnNullValuesInFindAllById() throws IOException {
718718
.containsExactlyInAnyOrder("id-one", "id-two", "id-three");
719719
}
720720

721-
@Test // DATAES-934
722-
@DisplayName("should use query and return SearchPage")
723-
void shouldUseQueryAndReturnSearchPage() {
724-
725-
List<SampleEntity> entities = createSampleEntitiesWithMessage("test", 20);
726-
repository.saveAll(entities);
727-
728-
Criteria criteria = new Criteria("message").is("test");
729-
CriteriaQuery query = new CriteriaQuery(new Criteria("message").is("test"));
730-
query.setPageable(PageRequest.of(0, 8));
731-
732-
SearchPage<SampleEntity> searchPage = repository.searchQuery(query);
733-
734-
assertThat(searchPage.getTotalElements()).isEqualTo(20l);
735-
assertThat(searchPage.stream().count()).isEqualTo(8l);
736-
assertThat(searchPage.nextPageable().getOffset()).isEqualTo(8l);
737-
}
738-
739721
private static List<SampleEntity> createSampleEntitiesWithMessage(String message, int numberOfEntities) {
740722

741723
List<SampleEntity> sampleEntities = new ArrayList<>();

0 commit comments

Comments
 (0)