Skip to content

Commit e0199e3

Browse files
committed
Polishing.
Simplify test dependency setup, remove no longer required servlet/xbean dependencies, exclude commons-lang3 in favor of the Testcontainers variant. Remove outdated commons-codec dependency in favor of the Testcontainers variant. See #3212
1 parent 1e5341a commit e0199e3

File tree

1 file changed

+21
-30
lines changed

1 file changed

+21
-30
lines changed

pom.xml

Lines changed: 21 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,27 @@
9191
<url>https://github.com/spring-projects/spring-data-elasticsearch/issues</url>
9292
</issueManagement>
9393

94+
95+
<dependencyManagement>
96+
<dependencies>
97+
98+
<dependency>
99+
<groupId>org.apache.commons</groupId>
100+
<artifactId>commons-lang3</artifactId>
101+
<version>3.19.0</version>
102+
<scope>test</scope>
103+
</dependency>
104+
105+
<dependency>
106+
<groupId>commons-io</groupId>
107+
<artifactId>commons-io</artifactId>
108+
<version>2.20.0</version>
109+
<scope>test</scope>
110+
</dependency>
111+
112+
</dependencies>
113+
</dependencyManagement>
114+
94115
<dependencies>
95116

96117
<!-- Spring -->
@@ -316,49 +337,19 @@
316337
<scope>test</scope>
317338
</dependency>
318339

319-
<!-- Upgrade xbean to 4.5 to prevent incompatibilities due to ASM versions -->
320-
<dependency>
321-
<groupId>org.apache.xbean</groupId>
322-
<artifactId>xbean-asm5-shaded</artifactId>
323-
<version>4.5</version>
324-
<scope>test</scope>
325-
</dependency>
326-
327-
<dependency>
328-
<groupId>javax.servlet</groupId>
329-
<artifactId>javax.servlet-api</artifactId>
330-
<version>3.1.0</version>
331-
<scope>test</scope>
332-
</dependency>
333-
334340
<dependency>
335341
<groupId>org.mockito</groupId>
336342
<artifactId>mockito-junit-jupiter</artifactId>
337343
<version>${mockito}</version>
338344
<scope>test</scope>
339345
</dependency>
340346

341-
<dependency>
342-
<groupId>org.apache.commons</groupId>
343-
<artifactId>commons-lang3</artifactId>
344-
<version>3.19.0</version>
345-
<scope>test</scope>
346-
</dependency>
347-
348347
<dependency>
349348
<groupId>org.testcontainers</groupId>
350349
<artifactId>testcontainers-elasticsearch</artifactId>
351350
<scope>test</scope>
352351
</dependency>
353352

354-
<!--we need Murmur3Hash in a test, before 5.2 we had it from the old Elasticsearch dependency -->
355-
<dependency>
356-
<groupId>commons-codec</groupId>
357-
<artifactId>commons-codec</artifactId>
358-
<version>1.15</version>
359-
<scope>test</scope>
360-
</dependency>
361-
362353
<dependency>
363354
<groupId>com.tngtech.archunit</groupId>
364355
<artifactId>archunit-junit5</artifactId>

0 commit comments

Comments
 (0)