Skip to content

Commit 4838fa1

Browse files
committed
Polishing.
Move warning suppression to the class-level. See #3901
1 parent 15e4096 commit 4838fa1

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

spring-data-jpa/src/test/java/org/springframework/data/jpa/convert/threeten/Jsr310JpaConvertersUnitTests.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
import static org.assertj.core.api.Assertions.*;
1919

20-
import java.util.Arrays;
21-
2220
import jakarta.persistence.AttributeConverter;
2321

22+
import java.util.Arrays;
23+
2424
import org.junit.jupiter.params.ParameterizedTest;
2525
import org.junit.jupiter.params.provider.MethodSource;
2626

@@ -40,7 +40,6 @@ static Iterable<?> data() {
4040
new Jsr310JpaConverters.ZoneIdConverter());
4141
}
4242

43-
4443
@ParameterizedTest
4544
@MethodSource("data")
4645
void convertersHandleNullValuesCorrectly(AttributeConverter<?, ?> converter) {

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
* @author Mark Paluch
4747
* @author Daniel Shuy
4848
*/
49-
@SuppressWarnings("removal")
49+
@SuppressWarnings({ "unchecked", "deprecation", "removal" })
5050
@ExtendWith(MockitoExtension.class)
5151
@MockitoSettings(strictness = Strictness.LENIENT)
5252
class SpecificationUnitTests {
@@ -55,7 +55,6 @@ class SpecificationUnitTests {
5555
@Mock(serializable = true) Root<Object> root;
5656
@Mock(serializable = true) CriteriaQuery<?> query;
5757
@Mock(serializable = true) CriteriaBuilder builder;
58-
5958
@Mock(serializable = true) Predicate predicate;
6059

6160
@BeforeEach
@@ -163,7 +162,6 @@ void specificationsShouldBeSerializable() {
163162

164163
assertThat(specification).isNotNull();
165164

166-
@SuppressWarnings({ "unchecked", "deprecation" })
167165
Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
168166

169167
assertThat(transferredSpecification).isNotNull();
@@ -178,7 +176,6 @@ void complexSpecificationsShouldBeSerializable() {
178176

179177
assertThat(specification).isNotNull();
180178

181-
@SuppressWarnings({ "unchecked", "deprecation" })
182179
Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
183180

184181
assertThat(transferredSpecification).isNotNull();
@@ -191,7 +188,6 @@ void andCombinesSpecificationsInOrder() {
191188
Predicate secondPredicate = mock(Predicate.class);
192189

193190
Specification<Object> first = ((root1, query1, criteriaBuilder) -> firstPredicate);
194-
195191
Specification<Object> second = ((root1, query1, criteriaBuilder) -> secondPredicate);
196192

197193
first.and(second).toPredicate(root, query, builder);

0 commit comments

Comments
 (0)