Skip to content

Commit 6128cfd

Browse files
committed
Polishing.
See #1943.
1 parent 2e5ed1d commit 6128cfd

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
import static org.springframework.data.jpa.domain.Specification.not;
2222
import static org.springframework.util.SerializationUtils.*;
2323

24-
import java.io.Serializable;
25-
2624
import jakarta.persistence.criteria.CriteriaBuilder;
2725
import jakarta.persistence.criteria.CriteriaQuery;
2826
import jakarta.persistence.criteria.Predicate;
2927
import jakarta.persistence.criteria.Root;
3028

29+
import java.io.Serializable;
30+
3131
import org.junit.jupiter.api.BeforeEach;
3232
import org.junit.jupiter.api.Test;
3333
import org.junit.jupiter.api.extension.ExtendWith;
@@ -119,7 +119,7 @@ void orConcatenatesNullSpecToSpec() {
119119
assertThat(specification.toPredicate(root, query, builder)).isEqualTo(predicate);
120120
}
121121

122-
@Test // DATAJPA-1651
122+
@Test // GH-1943
123123
public void allOfConcatenatesNull() {
124124

125125
Specification<Object> specification = Specification.allOf(null, spec, null);
@@ -128,7 +128,7 @@ public void allOfConcatenatesNull() {
128128
assertThat(specification.toPredicate(root, query, builder)).isEqualTo(predicate);
129129
}
130130

131-
@Test // DATAJPA-1651
131+
@Test // GH-1943
132132
public void anyOfConcatenatesNull() {
133133

134134
Specification<Object> specification = Specification.anyOf(null, spec, null);
@@ -137,7 +137,7 @@ public void anyOfConcatenatesNull() {
137137
assertThat(specification.toPredicate(root, query, builder)).isEqualTo(predicate);
138138
}
139139

140-
@Test // DATAJPA-1651
140+
@Test // GH-1943
141141
public void emptyAllOfReturnsEmptySpecification() {
142142

143143
Specification<Object> specification = Specification.allOf();
@@ -146,7 +146,7 @@ public void emptyAllOfReturnsEmptySpecification() {
146146
assertThat(specification.toPredicate(root, query, builder)).isNull();
147147
}
148148

149-
@Test // DATAJPA-1651
149+
@Test // GH-1943
150150
public void emptyAnyOfReturnsEmptySpecification() {
151151

152152
Specification<Object> specification = Specification.anyOf();

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ void throwsExceptionForUnderSpecifiedSingleEntitySpecification() {
490490
.isThrownBy(() -> repository.findOne(userHasFirstnameLike("e")));
491491
}
492492

493-
@Test // DATAJPA-1651
493+
@Test // GH-1943
494494
void executesCombinedSpecificationsCorrectly() {
495495

496496
flushTestUsers();
@@ -516,7 +516,7 @@ void executesNegatingSpecificationCorrectly() {
516516
assertThat(repository.findAll(spec)).containsOnly(secondUser);
517517
}
518518

519-
@Test // DATAJPA-1651
519+
@Test // GH-1943
520520
void executesCombinedSpecificationsWithPageableCorrectly() {
521521

522522
flushTestUsers();
@@ -623,22 +623,22 @@ void removeDetachedObject() {
623623
assertThat(repository.count()).isEqualTo(3L);
624624
}
625625

626-
@Test // DATAJPA-1651
626+
@Test
627627
void executesPagedSpecificationsCorrectly() {
628628

629629
Page<User> result = executeSpecWithSort(Sort.unsorted());
630630
assertThat(result.getContent()).isSubsetOf(firstUser, thirdUser);
631631
}
632632

633-
@Test // DATAJPA-1651
633+
@Test
634634
void executesPagedSpecificationsWithSortCorrectly() {
635635

636636
Page<User> result = executeSpecWithSort(Sort.by(Direction.ASC, "lastname"));
637637

638638
assertThat(result.getContent()).contains(firstUser).doesNotContain(secondUser, thirdUser);
639639
}
640640

641-
@Test // DATAJPA-1651
641+
@Test
642642
void executesPagedSpecificationWithSortCorrectly2() {
643643

644644
Page<User> result = executeSpecWithSort(Sort.by(Direction.DESC, "lastname"));

0 commit comments

Comments
 (0)